From aa1f8244e6a7a5f795dd606c68969604534135e4 Mon Sep 17 00:00:00 2001 From: Martijn Dekker Date: Fri, 19 Aug 2022 22:28:38 +0100 Subject: [PATCH] Disable -b/--notify pty regress test for now (re: 667034ff) The referenced commit made -b/--notify much better at notifying multiple terminating background jobs, but it still occasionally misses one if multiple jobs terminate all at once. This race condition will hopefully be worked out at some point, but it's a low-priority problem as the notification will appear at the next prompt in any case, and we still have many worse bugs to fix. But the associated pty regression test is failing fairly often on the github runners in the meantime, so this disables it for now. --- src/cmd/ksh93/tests/pty.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cmd/ksh93/tests/pty.sh b/src/cmd/ksh93/tests/pty.sh index 806ceb904..0c0bc2edd 100755 --- a/src/cmd/ksh93/tests/pty.sh +++ b/src/cmd/ksh93/tests/pty.sh @@ -1011,6 +1011,9 @@ r echo r ^ok\r\n$ ! +# TODO: fails too often on github runners; 'set -b' must still +# have a race condition when several jobs terminate all at once +: <<\DISABLED tst $LINENO <<"!" L --notify does not report all simultaneously terminated jobs @@ -1021,6 +1024,7 @@ u Done u Done u Done ! +DISABLED ((SHOPT_HISTEXPAND)) && HISTFILE=$tmp/tmp_histfile tst $LINENO <<"!" L history expansion: history comment character stops line from being processed