Commit Graph

263 Commits

Author SHA1 Message Date
Patrick Georgi 7ab683d29a handle missing return values 2025-12-18 22:58:26 +01:00
Patrick Georgi de2c06c54d remove system library prototypes 2025-12-18 22:58:26 +01:00
Patrick Georgi ae001c320f fix misleading indentation
Mostly to shut up the compiler, but some real bugs hidden in there.
2025-12-18 22:58:26 +01:00
Patrick Georgi 5787ee456e avoid use-after-free 2025-12-18 22:58:26 +01:00
Patrick Georgi c0ad5170c9 Avoid "bool" variable name
C23 has a type of that name.
2025-12-18 22:58:26 +01:00
Jon Trulson 5bfdd6f533 dtcm/cm_i18n.c: remove use of fcvt (obsolete), fix sign
Fixes #184
2025-12-06 18:57:59 -07:00
hyousatsu f0123efa84 Fix some warnings. 2024-07-21 00:43:27 +00:00
Jon Trulson 3fa42c44a8 dtcm: Chase FreeBSD src bb421be6c117 which moved ftime(3)
Patch from Cy Schubert:

FreeBSD bb421be6c117 moved ftime(3) from libcompat to libutil. This
results in the following error,

ld: error: undefined symbol: ftime
>>> referenced by getdate.c
>>>               libDtCmP_a-getdate.o:(cm_getdate) in archive
../libDtCmP/libDtCmP.a
>>> did you mean: ctime

Signed off by:	Cy Schubert <cy@FreeBSD.org>
2024-06-02 17:51:26 -06:00
Jon Trulson e03eabfd59 #127: dtcm: solaris - use readdir instead of readdir_r 2022-08-07 15:11:21 -06:00
Chase 60e60b9836 configure: detect libm 2022-07-31 18:33:49 -06:00
Chase 9a9d586e87 configure: detect libdl 2022-07-31 18:33:49 -06:00
Chase edf4319548 Discontinue HPUX support 2022-07-23 17:49:33 -06:00
Liang Chang c051e6d3bc dtcm: set default calendar version to avoid segfault. 2022-04-15 11:09:05 +00:00
Peter Howkins 04fcc11f12 dtcm: Resolve format-overflow issues 2021-12-24 10:50:28 -07:00
Peter Howkins 2c134302c8 dtcm: Resolve uninitialized warnings 2021-12-24 10:50:28 -07:00
Jon Trulson 3a0e92adb6 Rename autotools_config.h to cde_config.h to better reflect it's ownership. 2021-12-22 13:21:43 -07:00
Jon Trulson e10d06f210 configure/Makefiles: add checks for Xmu, Xext, and Xdmcp
We also remove sun pro specific options, and do some general cleanup
as well as remove hardcoded library refs like -lXm, -lXext, etc...
2021-12-21 16:42:22 -07:00
Jon Trulson 4029c5b813 dtcm/RFCMIME: fix a guaranteed buffer overflow 2021-12-19 12:25:50 -07:00
Jon Trulson 05fa4044f4 Look over the install rules and adjust where appropriate
These are just minor tweaks to make sure the 'make install' part does
what it is supposed to do.  I also removed some commented code in the
dtmail Makefile related to SunOS, as that is not currently suppoerted
anyway.
2021-12-15 15:41:53 -07:00
Jon Trulson ab409095d6 Fix a couple of unused-comparison clang warnings 2021-12-12 12:52:14 -07:00
Jon Trulson 0ee97b3645 dtcm: fix implicit-function-declaration warnings 2021-11-16 14:46:48 -07:00
Jon Trulson 9369d1d5b9 dtcm: timeops.c/getdate.y: fix fbsd build errors
Commit e0508b31 introduced build errors on FreeBSD.  This corrects
them.

HAVE_DECL_TIMEZONE should only be used to determine whether or not the
'timezone' variable is defined in a header file or whether it must be
specifically 'extern'ed.

On fbsd, a definition exists, but it is a function in libc and not an
integer timezone value that can be mutliplied or divided.
2021-10-23 21:59:33 -06:00
OBATA Akio e0508b3130 dtcm: change to detect TZ offset way with configure 2021-10-23 18:29:04 +09:00
OBATA Akio 87bdee3d19 dtcm: change to use `_XLocaltime` instead of `localtime` consitently 2021-10-23 16:54:35 +09:00
OBATA Akio fb91c9416d dtcm: resolve mismatch between `tm.tm_gmtoff` and global `timezone`
`timezone` and `tm.tm_gmtoff` represent reversed sign value each other.
Change `tm.tm_gmtoff` usage to be matched with `timezone`.
2021-10-23 16:54:35 +09:00
OBATA Akio 224f04cb29 dtcm: fix `localtime()` usage
It is expexted the first argument is `*time_t`, not `time_t`.
2021-10-23 16:54:35 +09:00
OBATA Akio 16eb6092b0 dtcm: prevent to use `NULL` as a Tick type
Tick (aka time_t) shall be an integer type, not a pointer.
Change to use `0` instead of `NULL`.
2021-10-16 17:07:37 +09:00
OBATA Akio 2c9db8fe37 dtcm: include <iso8601.h> of libcsa to resolve type mismatch 2021-10-12 17:24:26 +09:00
OBATA Akio 2390217a75 Fix to decide data and return type explicity 2021-10-08 17:25:17 +09:00
OBATA Akio 16fe76ed65 Fix to include system header files for using functions 2021-10-08 14:40:56 +09:00
OBATA Akio 20c1768a19 Change to detect iconv implementation with autoconf
Use iconv.m4 (and required macros) form gettext-0.21.
2021-09-21 14:04:40 +09:00
Jon Trulson 93e280b05b dtcm: install-exec-hook needs $(DESTDIR) 2021-07-22 19:50:18 -06:00
Jon Trulson 51646fb06a programs/: remove Imakefiles for completed modules 2021-07-03 19:12:43 -06:00
Edmond Orignac 53c35daea1 misc.c: in cm_mbchar check string!=NULL before dereferencing it 2021-06-02 19:56:28 -06:00
Liang Chang ff952fcfbc dtcm: Avoid to leave an unclosable window when there is no appointment in
"Appointment List...".
2021-06-02 19:56:27 -06:00
Liang Chang e7402803df dtcm: fix a segfault that occurred when opening the "Appointment List..." in
the "View" menu.
2021-06-02 19:56:26 -06:00
Liang Chang 4190143c91 dtcm: fix a segfault when "Drag Appt" in the dtcm_editor. 2021-06-02 19:56:26 -06:00
Lev Kujawski a6ea2a2d52 Centralize catgets() calls through MsgCat
CDE has relied upon catgets() implementations following a relaxed
interpretation of the XPG internationalization standard that ignored
-1, the standard error value returned by catopen, as the catalog
argument. However, this same behavior causes segmentation faults with
the musl C library.

This patch:

- Centralizes (with the exception of ToolTalk) all calls to catopen(),
  catgets(), and catclose() through MsgCat within the DtSvc library.
- Prevents calls to catgets() and catclose() that rely upon
  undefined behavior.
- Eliminates a number of bespoke catgets() wrappers, including multiple
  redundant caching implementations designed to work around a design
  peculiarity in HP/UX.
- Eases building CDE without XPG internationalization support by providing
  the appropriate macros.
2021-06-02 19:55:15 -06:00
Jon Trulson e8345c9241 autotools: specify tirpc lib to link the tooltalk binaries
Newer ubuntu's do not seem to honor the implied library dependency of
libtt->libtirpc, so we must explicitly specify libtirpc when linking
them.
2021-06-01 18:23:46 -06:00
Chase 2642674ed4 dtcm: make /var/spool/calendar for user 2021-03-14 15:09:03 -06:00
Jon Trulson ece5c0ea14 Merge branch 'master' into autotools-conversion
Lost the ksh93 submodule so will re-add in a later commit.
2021-01-30 19:04:10 -07:00
Lev Kujawski 13c173d22c On Linux, use SVR4's (now POSIX) mktime() instead of BSD's non-standard timelocal(). 2021-01-10 18:08:00 -07:00
Peter Howkins d98b2c4c34 dtcm: Always use ANSI function prototypes 2020-11-29 01:55:09 +00:00
Jon Trulson 90e61dda5f Merge branch 'master' into autotools-conversion 2020-11-24 16:53:24 -07:00
Peter Howkins 67f62e5a8a all: remove deprecated sys_errlist[] and replace with ANSI C strerror() 2020-11-02 05:30:08 +00:00
Jon Trulson 264871cefb Fix up a couple issues with multi-core builds and 2 race conditions 2019-11-22 13:42:02 -07:00
Jon Trulson c329d5cfd7 Remove $(TIRPCINC) from all Makefile.am files - it no longer exists
Also, restructure some of the dependencies in the lib/tt binaries.  We
will link with libtt (which will include libtirpc as a dependency),
and XTOOLLIB - all the right X11 stuff without needing to add it to
every OS.  Removed several uneeded OS specializations ("if LINUX",
etc) as a result.
2019-11-20 18:52:29 -07:00
Jon Trulson 444aa700c0 dtcm: make it build 2019-11-20 17:31:53 -07:00
Jon Trulson 730da7747c Change "if SUN" conditionals in remaining Makefile.am files to "if SOLARIS" 2019-10-28 18:54:17 -06:00
Chase ca20cfe55b programs/dtcm: add automake files 2019-10-23 15:34:20 -06:00