Commit Graph

795 Commits

Author SHA1 Message Date
Jon Trulson 51b7590c63 dtfile/File: CID 88195,88595,88627,88794 2018-04-11 16:25:52 -06:00
Jon Trulson d30719f3a2 dtfile/SharedProcs: CID 88158,88337,89104,89118 2018-04-11 16:25:52 -06:00
Jon Trulson dd03c9cbf7 dtfile/FileDialog: CID 88141,88451,88658,89058 2018-04-11 16:25:52 -06:00
Jon Trulson 7e61925f1b dtfile/Desktop: CID 88133,88159,88339,88798,89331,89466 2018-04-11 16:25:52 -06:00
Jon Trulson 694b6ef5eb dtfile/Prefs: CID 88095,88407,89162,89164,89283,89445 2018-04-11 16:25:52 -06:00
Peter Howkins db88cb0d13 dtpad: resove coverity issues 2018-04-11 18:05:06 +01:00
Jon Trulson 56b53a30a1 Reimplement reverted commit 7fa35c to fix readlink() issues
Original implementation:

Commit: 7fa35cA
dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink

That commit caused dtfile to be unable to resolve symbolic links and
was later reverted.  This commit reimplements the fixes correctly, and
should hopefully still resolve the coverity issues as well.
2018-04-10 19:12:58 -06:00
Peter Howkins 10468068ac dthelp: more coverity fixes 2018-04-11 02:07:55 +01:00
Jon Trulson 9a3a9e3010 Revert "dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink"
This reverts commit 7fa35c29c4.
2018-04-05 15:44:37 -06:00
Jon Trulson 70f85d77cc dtfile/sharedFuncs: CID 88085; resource leak 2018-04-05 13:28:04 -06:00
Jon Trulson caa95ba67c dtfile: define MAX_PATH to PATH_MAX rather than 1024, also CID 87557 2018-04-05 12:49:06 -06:00
Peter Howkins 494fd64314 dtinfo/dtinfogen: Fix segfault introduced by over zealously fixing coverity resource leak 2018-04-05 18:16:10 +01:00
Peter Howkins bc28c20524 dtinfo: fix coverity issues related to null checks after dereference 2018-04-04 22:42:06 +01:00
Peter Howkins 2b15c4057e dtinfo: Fix coverity issues for resource leaks 2018-04-04 22:07:10 +01:00
Peter Howkins 9ef3b9ec68 dtspcd: Cov 89547, 175089 2018-04-04 20:37:13 +01:00
Peter Howkins 2d91ff7a6f dsdm: cov 86572, free mem in error condition 2018-04-04 16:50:19 +01:00
Peter Howkins d87f6ce29d Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code 2018-04-04 16:37:12 +01:00
Peter Howkins 4fc13a6e27 dtwm: cov 175166, check for pointer 2018-04-04 16:33:45 +01:00
Jon Trulson f7d09f054d dtfile/SharedProcs.c: rework coverity 174852 fix to unbreak dtfile 2018-04-03 21:28:49 -06:00
Jon Trulson 8f7c874ba0 fontaliases: use copy rather than symlink since bdftopcf can't handle those
bdftopcf specifically will not read symbolic links.  This causes it to
fail when creating the programs/fontaliases/*/C/dtinfo.pcf.Z file and
subsequently, the fonts.dir file.

So, we add a new Imake macro: CopySourceFile(), to copy rather than
symlink the dtinfo.bdf file so these operations can complete
successfully.  The dtinfo.bdf file is only 5KB, so there's very little
impact having an extra copy created during a build.
2018-04-03 13:03:26 -06:00
Jon Trulson 7f70748d65 Disable building of dtudcfonted and dtudcexch
This software has a variety of problems, like including renamed X11
header files, and other nuttery.

These programs also have a very limited use, I doubt most people even
know what they are for or will miss them.

This commit prevents them from being built and installed.  If no-one
volunteers to get these into decent shape after the next release, they
will be removed from the repository.
2018-04-02 19:38:14 -06:00
Jon Trulson c4e7d35519 dtcm/dssw.c: fix typo 2018-04-02 18:43:14 -06:00
Jon Trulson ba95bbc073 dtudcfonted/gpftobdf.c: Coverity CID 175168; NULL deref 2018-04-02 18:23:22 -06:00
Jon Trulson 45bccb474c dtcalc/ds_xlib.c: Coverity CID 175167; uninit value 2018-04-02 18:07:54 -06:00
Jon Trulson d5c304d476 dtcm/dssw.c: Coverity CID 88672; dest buf too small 2018-04-02 17:02:16 -06:00
Jon Trulson f269c2a074 dtsr/dtsrclean.c: Coverity CID 86876; dest buf too small 2018-04-02 17:02:16 -06:00
Peter Howkins bcee6be5d8 Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code 2018-04-02 20:32:56 +01:00
Peter Howkins 0b38496bd8 dtmail: resolve 'deference before null check' errors related to if(!NULL) checks around free() calls 2018-04-02 20:29:28 +01:00
Jon Trulson 2cac2a29ac dtwm/WmResource.c: remove errant ')' added in previous commit 2018-04-02 12:22:32 -06:00
Peter Howkins 8362f92ceb dtwm: Resolve coverity warnings 2018-04-02 18:08:40 +01:00
Jon Trulson 4b9bcae29f dtcreate/fileio.c: coverity CID 175094; dref bef NULL 2018-04-01 18:41:54 -06:00
Jon Trulson dbe044c24c dtcreate/CreateActionAppShell.c: coverity CID 175092; uninit ptr read 2018-04-01 18:35:14 -06:00
Jon Trulson 2363b97d60 dtcalc: remove MAX_PATH, use standard PATH_MAX 2018-04-01 18:33:00 -06:00
Jon Trulson ce471d7068 dtcalc/ds_xlib.c: coverity CID 175093; wrong sizeof/bad free 2018-04-01 18:30:10 -06:00
Jon Trulson 75a892d93f dtudcfonted/_faludcInf.c: coverity CIDs 175096,175092; uninit ptr read 2018-04-01 18:06:10 -06:00
Jon Trulson 03ba4e454c dtudcfonted/gpftobdf.c: coverity CIDs 87073,87008,87029,86919,86898,86715; uninit scalar 2018-04-01 14:42:38 -06:00
Jon Trulson 3020b050ff dtfile/File.c: coverity CID 88919; uninit array read 2018-04-01 14:21:57 -06:00
Jon Trulson cd70f1660d dthelp/Initialize.c: coverity CID 89569; unbounded src buf 2018-04-01 14:16:18 -06:00
Jon Trulson 0843325a43 dtcm/props.c: coverity CID 88573; unbounded src buf 2018-04-01 14:04:25 -06:00
Jon Trulson adb0acbaf5 dtudcfonted/getfname.c: coverity CID 86392; insecure readlink 2018-04-01 13:46:14 -06:00
Jon Trulson 7fa35c29c4 dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink 2018-04-01 13:46:04 -06:00
Jon Trulson b4c4fb594d dtfile/SharedProcs.c: coverity CID 174852; int overflow 2018-03-31 19:12:32 -06:00
Jon Trulson 77d10002bf dtmail/MsgScrollingList.C: coverity CID 87360; memset no effect 2018-03-31 18:55:56 -06:00
Jon Trulson 05773d7499 dtinfo/OutlineListViewMotif.C: coverity CID 87754; memset truncated 2018-03-31 18:53:29 -06:00
Jon Trulson 7752966865 dthelp/helpgen.c: coverity CID 175085; use after free 2018-03-31 18:21:14 -06:00
Jon Trulson ec93faffe7 dtfile/Help.c: coverity CID 88484; use after free 2018-03-31 18:11:14 -06:00
Jon Trulson bbf028becc dthelp/htag/malloc: coverity CID 86955; use after free 2018-03-31 17:52:27 -06:00
Jon Trulson ecee8b3f3a dtmail/DtMailRc.C: coverity CID 88975; use after free 2018-03-31 17:46:53 -06:00
Jon Trulson a8102e85e0 dtfile/Main.c: coverity CID 89623; uninit var 2018-03-31 17:34:40 -06:00
Jon Trulson e7269115b5 dtfile/sharedFuncs.c: coverity CID 88625; use after free 2018-03-31 17:25:35 -06:00
Jon Trulson c32b5db653 dtfile/SharedProcs.c: coverity CID 89068; use after free 2018-03-31 17:21:34 -06:00
Jon Trulson 0c0b77a509 dtinfo/MixedGen.C: coverity CID 89495; use after free 2018-03-31 14:42:22 -06:00
Jon Trulson 3c72e21cb2 dtspcd: coverity CID 174742; potential NULL derefs 2018-03-31 14:33:31 -06:00
Jon Trulson af58b6be10 dtinfo/DtSR: coverity CID 88552; memory corruption 2018-03-31 14:33:31 -06:00
Jon Trulson 8862366f00 dtinfo/TextParser.C: coverity CID 89054; mem corruption 2018-03-31 14:33:23 -06:00
Peter Howkins edd928caf5 dtpdmd: Resolve some coverity warnings 2018-03-30 23:48:00 +01:00
Peter Howkins bcccf559ce dtcreate: Resolve coverity issues 2018-03-30 23:35:39 +01:00
Peter Howkins e195df4b50 dtudcfonted: Resolve further coverity issues 2018-03-30 22:09:47 +01:00
Peter Howkins e507de959e dtcalc: resolve coverity issues 2018-03-30 20:24:04 +01:00
Peter Howkins e12e009eb5 dthelp: compiler warning and coverity warning fixes 2018-03-29 00:21:44 +01:00
Peter Howkins f65f512981 dtcalc: resolve coverity issues 2018-03-28 02:24:27 +01:00
Peter Howkins 0b93afd2ca dtscpd: resolve compiler and coverity warnings 2018-03-28 02:08:36 +01:00
Peter Howkins 55c59be795 dtcudcfonted: Resolve compiler and coverity warnings 2018-03-28 01:29:28 +01:00
Peter Howkins 49d1ca38e4 dtdocbook: glibc 2.27 drops support for matherr() support in math.h 2018-03-27 03:55:32 +01:00
Peter Howkins a6b5ef552f dtcalc: change from obsoleted MAXFLOAT to FLT_MAX from std C 2018-03-27 03:25:58 +01:00
Peter Howkins d41d87be27 dtksh: Linux modern glibc compile HACK prevent system wide definition of __FILE that we define to Sfio_t 2018-03-27 01:51:58 +01:00
Peter Howkins 1acf08c5ef dtksh: make sure you can still build on linux older c library too 2018-03-23 04:17:17 +00:00
Peter Howkins 9d69ea3d97 dtksh: HACKY fix for compilation on later linux C library where FILE definition has moved 2018-03-23 01:51:39 +00:00
Peter Howkins b1c3729e88 Change dtmmdb class from tuple to mmdb_tuple 2018-03-21 01:03:31 +00:00
Peter Howkins abd209a83c Change how read and write errors are detected on fstream based streams. 2018-03-21 01:01:09 +00:00
Peter Howkins 490890cd23 Resolve some compiler warnings 2018-03-18 00:21:51 +00:00
Peter Howkins 555abfa53b Fixed for wrong cased filename on depends creation 2018-03-18 00:20:55 +00:00
Peter Howkins 637abd5d5c Resolve some coverity warnings 2018-03-08 23:03:21 +00:00
Michael McConville 35a16f47df Remove needless zeroing after calloc 2017-12-09 02:33:44 -07:00
Cody Kotichas 1d037477f1 Fix typographical error 2017-08-09 16:52:44 -06:00
Jon Trulson 129ef945b9 dtappbuilder: Add patches from Robert Pangrazio fixing coredumps 2017-08-05 18:49:07 -06:00
Peter Howkins e4ba1fad36 Change pid wait types to int on Linux as well. Fixes compile issue
in dtudc programs on ubuntu 16.10+
2017-04-11 20:40:43 +01:00
Edmond ORIGNAC 9b1f60a713 DtMail translations and improvements of vcal2xampia.awk
dtmail: messages of the 'Mail Retrieval' menu of dtmail  were left untranslated.
	French, Italian, Spanish translations were added.
vcal2xapia.awk: capacity to handle UTC+n timezones and TODO items added.
2017-01-03 13:23:23 -07:00
alx acb2dd330d dtksh/sfio: resolved a naming collision on FreeBSD 11 2016-12-31 15:15:04 -07:00
alx 2ea10ef612 dtlogin: center the mouse pointer on the login screen on multi-head setups 2016-12-31 15:14:54 -07:00
alx 39031e9dea dtfile: added Xinerama support to dialog positioning routines 2016-12-31 15:14:49 -07:00
Swift Griggs 1fdcd4c93d Patches from pkgsrc-WIP 2016-08-05 11:21:06 -06:00
Matthew R. Trower 341494d91c dtwm: basic multihead(xinerama only) support
* maximization (also partially fixes strange Firefox behaviour)
* sane initial window placement

Firefox is stranger than most; it appears to maximize to double
X Screen width even on single head displays.  Fixed (on multihead).
2016-06-24 17:16:19 -06:00
Ulrich Wilkens 45ab8a3532 dtlogin: FreeBSD build fix 2016-06-12 17:13:20 -06:00
Ulrich Wilkens 574cf20b31 Fix dtinfo document build on OpenBSD 2016-06-10 16:15:57 -06:00
Pascal de Bruijn 4aedbf2796 dtlogin: openbsd build fix
Amend ced27aa1f6 to prevent openbsd
make from failing because of the tab.
2016-06-09 10:05:35 -06:00
Giacomo Comes 542fce33d4 call fclose(infile) after print_progress()
The function print_progress uses the pointer infile.
If fclose is called before print_progress then the build process
can fail to build the files:
  doc/C/cde.dti/CDEDOC/dtsearch/CDEDOC.d99
  doc/C/cde.dti/CDEDOC/dtsearch/dtsearch.ocf
  doc/C/cde.dti/cde.oli
To fix the issue move the call fclose(infile) after print_progress()
2016-06-07 20:00:11 -06:00
Giacomo Comes a650c6214e Use /var/spool instead of /usr/spool on linux 2016-06-07 19:59:42 -06:00
Peter Howkins e1333a5160 dtstyle: remove some accidentally commited debug code 2016-04-21 01:48:40 +01:00
Peter Howkins 066adcac5e dtstyle: backdrops, allow jpg/png if motif supports it
add file extensions to all types but .pm/.bm. This lets XmGetPixmap() load them.
2016-04-21 01:43:27 +01:00
Peter Howkins 2ea057d511 Disable all code related to libXp
deprecated and mostly no longer included on current OSes
2016-04-20 20:17:22 +01:00
alx b251a15844 dtfile: Enable FILE_MAP_OPTIMIZE on Linux. This avoids unnecessary tt_file_netfile calls on local host. 2016-04-18 19:16:48 -06:00
alx 2e5bd045ed dtwm: Resolved some compiler warnings 2016-04-18 19:16:48 -06:00
alx 720fd9365a dtwm: 0 is not NULL 2016-04-18 19:16:48 -06:00
alx ed2c149bfc dtsession: Enable X11 screensaver extension on FreeBSD 2016-04-18 19:16:47 -06:00
alx 7cddb0d165 dtlogin: Enable XDM authentication on FreeBSD 2016-04-18 19:16:47 -06:00
alx ff7c7d72cf dtfile: Enable FILE_MAP_OPTIMIZE on FreeBSD. This avoids unnecessary tt_file_netfile calls on local host. 2016-04-18 19:16:47 -06:00
Jon Trulson 6bc5c658b8 dtappbuilder: replace accidental %a with %% in write_func_as_strings() 2015-12-18 10:28:37 -07:00
Pascal de Bruijn ced27aa1f6 dtlogin: don't use crypt(3) on openbsd
des support has been removed from crypt(3) on openbsd since version 5.8
2015-11-28 12:24:20 -07:00
Jon Trulson 1e2e373082 dtlogin: use XDM authentication instead of MIT/DES on linux 2015-11-26 14:08:23 -07:00
Jon Trulson 05445493d9 ksh: fix up shipin for more modern systems WRT test and wc
Patch submitted by Giacomo Comes.
2015-11-22 15:37:40 -07:00
Ulrich Wilkens f8fdf4920f Fix FreeBSD 10.2 build 2015-10-21 19:23:05 -06:00
alx 307981f3e5 dtfile: fixed ambiguity in the translation table 2015-07-23 18:51:39 -06:00
alx 84f725bd54 dtfile: fixed file view scrolling with Page Up/Down keys 2015-07-23 18:51:34 -06:00
alx 5c6ddfd0c1 dtfile: 0 is not NULL 2015-07-16 19:21:18 -06:00
alx 304f99d26c dticon: KeySym is not char 2015-07-02 17:50:26 -06:00
alx bd4a4532f0 dtfile: fixed double free in copy/move collision handler 2015-07-02 17:50:21 -06:00
alx cbd5abb33a dtsession: fixed errorlog rotation 2015-07-02 17:50:16 -06:00
Douglas Carmichael aaab59761f Patches to enable compilation on OpenBSD 5.7/FreeBSD 10.1. 2015-06-17 11:31:31 -06:00
Isaac Dunham 87d863b8a4 programs/dtappintegrate: make PATH include /bin.
Without this, we fail without the /usr merge because 'date' is
unavailable.
2015-06-16 15:56:21 -06:00
Jon Trulson 6400908cc1 dtscreen: don't use old version of round() on linux either 2015-05-09 16:37:04 -06:00
Ulrich Wilkens 8b38d9ea49 Fix broken build on OpenBSD 2015-05-09 16:21:32 -06:00
Ulrich Wilkens 2b8b5f25b5 Support for new Solaris/OpenIndiana versions 2015-05-09 16:19:08 -06:00
Edmond ORIGNAC 51afe76f07 Fix dtprintinfo parser
When using a non C locale such as fr_FR.ISO8859-1, the CUPS messages
returned by lpq are translated. However, the parser in ParseJobs.C can only
handle messages in English. As a result, dtprintinfo exits immediately with
an error message. To fix that problem we force a LANG=C environment when calling
lpq so that messages will be in English and will be processed correctly by dtprintinfo
parser.
2015-03-21 20:14:16 -06:00
Peter Howkins 917343911e dtudcfonted: Resolve CID 86560 2015-01-21 14:15:31 +00:00
Peter Howkins 8c340c1984 dtudcfonted: Resolve CID 86547 2015-01-21 14:10:58 +00:00
Peter Howkins 8ba625d41d dtudcfonted: Resolve CID 86495 2015-01-21 14:09:39 +00:00
Peter Howkins 9e849c3f25 dtudecfonted: Resolve CID 86417 2015-01-21 14:04:04 +00:00
Peter Howkins 343a78b225 dtudcfonted: Resolve CID 86391 2015-01-21 14:02:34 +00:00
Peter Howkins 0669358b82 dtudcfonted: Resolve CID 86328 2015-01-21 14:00:44 +00:00
Peter Howkins 1e904a31d8 dtudcfonted: Resolve CID 86280 2015-01-21 13:56:00 +00:00
Johannes von Rotz f6e025b3af Let "make World" run through on OpenBSD 2015-01-21 13:47:20 +00:00
Peter Howkins 83af6d8431 dtudcfonted: Resolve CID 86389 2015-01-16 16:51:37 +00:00
Peter Howkins 15434b1787 dtudcfonted: Resolve CID 86232 2015-01-16 16:49:42 +00:00
Peter Howkins 1380cb7c8e dtudcfonted: Resolve CID 86153 2015-01-16 16:29:55 +00:00
Peter Howkins e987e48f9a dtprintinfo: Resolve CID 87253 2015-01-15 16:07:10 +00:00
Peter Howkins d3dbc00c1f dtfile: Resolve CID 89277 2015-01-15 15:37:32 +00:00
Peter Howkins 6a86dba654 dtfile: Resolve CID 88830 2015-01-15 15:30:59 +00:00
Peter Howkins 639081c8f1 dtfile: Resolve CID 89009 2015-01-15 15:26:22 +00:00
Peter Howkins 17ef8a8b34 dtfile: Resolve CID 89319 2015-01-15 15:25:13 +00:00
Peter Howkins 1ed848709d dtfile: Resolve CID 88199 2015-01-15 15:23:24 +00:00
Peter Howkins 7f70f509c8 dtfile: Resolve CID 88133, 88261 2015-01-15 15:18:21 +00:00
Peter Howkins 24880e4e05 dtfile: Resolve CID 87776. OkCallback is of type XtCallbackProc, it doesn't return one 2015-01-15 15:15:31 +00:00
Peter Howkins 74afeadda3 dtfile: Resolve CID 87308 2015-01-15 15:05:45 +00:00
Peter Howkins f506dd71ac dtcm: Resolve CID 88003 2015-01-15 14:23:45 +00:00
Peter Howkins dcdf4e2a65 dtcm: Resolve CID 87983 2015-01-15 14:21:34 +00:00
Peter Howkins e063ab47d3 dtcm: Resolve CID 87822 2015-01-15 14:20:02 +00:00
Peter Howkins 9388ef6c5b dtcm: Resolve CID 87801 2015-01-15 14:18:17 +00:00
Peter Howkins 8ef7da82a3 dtcm: Resolve CID 87713 2015-01-15 14:16:06 +00:00
Peter Howkins d5c37e1ad6 dtcm: Resolve CID 87562 2015-01-15 12:10:25 +00:00
Peter Howkins 85b7e823c4 dtcm: Resolve CID 87408 2015-01-15 11:59:20 +00:00
Peter Howkins b578e9cc3a dtcm: Resolve CID 87384 2015-01-15 11:55:09 +00:00
Peter Howkins d53a979639 dtscreen: convert K&R prototypes to ansi C 2015-01-14 15:06:33 +00:00
Peter Howkins 917e6cfc49 dthello: Resolve 8 compiler warnings that would be introduced with -Wall 2015-01-14 10:42:44 +00:00
Peter Howkins f913c616ee dtpad: Resolve 7 compiler warnings. 2015-01-13 14:50:05 +00:00
Peter Howkins 8baeb4c0a0 dtcm: Resolve 303 compiler warnings. 2015-01-13 14:22:25 +00:00
Peter Howkins fe39b630b3 dtstyle: Fix CID 100252 2015-01-13 10:13:03 +00:00
Peter Howkins 90bd9101e3 dtmail: add a stdint.h include for openbsd, as reported by Daniel Diaz via the wiki. 2015-01-09 16:30:43 +00:00
Peter Howkins 22830f478a dtfile: resolve 19 compiler warnings. 2015-01-09 16:16:53 +00:00
Peter Howkins 561d858140 dticon: resolve 3 compiler warnings 2015-01-07 14:19:38 +00:00
Peter Howkins 93f3878b4e dtdocbook: resolve 49 compiler warnings. 2015-01-06 17:22:50 +00:00
Peter Howkins 0a0e1eebf5 dtmail: Resolve 50 compiler warnings. 2015-01-06 15:07:55 +00:00
Peter Howkins 3fab71345b dtsr: resolve all 12 compiler warnings. 2015-01-05 16:54:12 +00:00
Peter Howkins 466b8d0df5 dtstyle: resolve 30 compiler warnings. 2015-01-05 16:07:49 +00:00
Peter Howkins 8ed5281e3e dtwm: resolve 92 compiler warnings (related to 64 bit pointer to int coversions) 2014-12-30 17:13:41 +00:00
Peter Howkins 4a66f1ab61 dtaction: resolve 2 compiler warnings. 2014-12-30 16:12:54 +00:00
Peter Howkins 59bcb8d08f dsdm: convert k&r function declarations to ansi, and correct the warnings this then uncovered. 2014-12-30 15:57:12 +00:00
Peter Howkins 4fc0bcef0f dsdm: resolve coverity warnings CID 86139 86255 86331 86345 86418 86517 86526 86567 86590 86616 2014-12-30 15:13:47 +00:00
Peter Howkins 2fc7807ee5 dtcalc: resolve 13 compiler warnings on 64 bit builds. 2014-12-30 14:43:12 +00:00
alx 123d4ba8fc dtcopy: Fix file removal 2014-12-28 12:53:39 -07:00
Jon Trulson f6d6aafc93 Merge branch 'coverity_dtsession'
Fix up a bunch (55) issues in dtsession identified by Coverity's
static analysis.
2014-12-27 20:25:26 -07:00
Jon Trulson 4dae64c891 dtsession/SrvPalette: fix CID 89227 2014-12-27 20:09:09 -07:00
Jon Trulson 722cfc70eb dtsession/SrvFile_io: fix CID's 88299 and 89441 2014-12-27 20:06:53 -07:00
Jon Trulson aa2daba4af dtsession/SmUI: fix tainted var (CID 88216) 2014-12-27 19:52:37 -07:00
Jon Trulson db8280189d dtsession/SmSave: use absolute path to rm in system() 2014-12-27 19:42:21 -07:00
Jon Trulson e02c703af7 dtsession/SmSave: get rid of use of tempnam (CID 89359) 2014-12-27 19:33:03 -07:00
Jon Trulson 7c702bff6e dtsession/SmRestore: redo defaultCwd detection in StartClient() to be safer 2014-12-27 19:01:30 -07:00
Jon Trulson a657f302f7 dtsession/SmRestore: fixup 8 coverity issues. 2014-12-27 18:19:55 -07:00
Jon Trulson 65dcf12c82 dtsession/SmGlobals: re-add smGD.savePath to generated paths, was lost in mkstemp changes. 2014-12-27 17:50:28 -07:00
Jon Trulson 93783917ab dtsession/SmGlobals: unlink mkstemp generated files. 2014-12-27 17:24:04 -07:00
Peter Howkins ab743c37e6 dtlogin: resolve more static analysis warnings 2014-12-27 23:13:59 +00:00
Jon Trulson 4b38955b01 dtsession/SmGlobals: use of tainted string (CID 89450) 2014-12-27 16:12:45 -07:00
Jon Trulson 1bde7d8c5c dtsession/SmLock: potential null deref (CID 87561, 87957, 88181) 2014-12-27 16:06:23 -07:00
Jon Trulson f14df58edb dtsession/SmDB: error handling issues (CID 87778, 87926) 2014-12-27 15:54:55 -07:00
Jon Trulson 1148ae8794 dtsession/SmCommun: fix bogus check (CID 89326) 2014-12-27 15:50:29 -07:00
Jon Trulson 881b0e1ed0 dtsession/SmGlobals: fixup 17 coverity issues. 2014-12-27 15:42:04 -07:00
Peter Howkins c768260785 dtlogin: resolve 8 compiler warnings. 2014-12-27 20:56:29 +00:00
Jon Trulson 61e925f3c5 dtlogin/xdmcp: fixup many warnings and a possible declaration bug 2014-12-27 13:01:26 -07:00
Jon Trulson a71cde075e dtwm/WmFP: Coverity (memory corruption, moderate) 2014-12-26 18:10:07 -07:00
Jon Trulson f05c124807 dtwm/PopUpMenu: Coverity (memory corruption, moderate) 2014-12-26 17:30:50 -07:00
Jon Trulson 611dda1831 dtsession: Coverity (memory corruption, moderate) 2014-12-26 17:23:16 -07:00
Jon Trulson 055d98cafb dtscreen: Coverity (memory corruption, moderate) 2014-12-26 17:17:58 -07:00
Jon Trulson a5c7512782 dtprintinfo: Coverity (memory corruption, moderate) 2014-12-26 17:17:06 -07:00
Jon Trulson b881408be0 dtlogin: Coverity (memory corruption, moderate) 2014-12-26 16:55:46 -07:00
Jon Trulson 235a75c03c dtlogin: Coverity (memory corruption, moderate) 2014-12-26 16:23:54 -07:00
Jon Trulson 00540cb375 dtcalc: Coverity (memory corruption, moderate) 2014-12-26 16:19:23 -07:00
Jon Trulson ff3cd78ac0 dtcalc: Coverity (memory corruption, moderate) 2014-12-26 16:17:43 -07:00
Jon Trulson 07dc336b96 dtsession: Coverity (memory corruption) 2014-12-26 14:24:31 -07:00
Jon Trulson b41a74b595 dtsession: Coverity (memory corruption) 2014-12-26 14:22:05 -07:00
Jon Trulson 2e7ab68300 dtappbuilder: Coverity (memory corruption) 2014-12-26 14:14:32 -07:00
Peter Howkins bc842043d2 dtlogin: Resolve 27 compiler warnings 2014-12-23 22:01:51 +00:00
Peter Howkins e54c164fe1 dtlogin: start to resolve static analysis warnings
Also convert some K&R function declarations to ansi
2014-12-23 17:49:11 +00:00
Ulrich Wilkens 29294e0373 Fix FreeBSD 10.1 build 2014-11-20 17:48:57 -07:00
Jon Trulson bf0666a330 it_IT.ISO8859-1/types/_common.dt.tmsg: Apply manual one-line patch 2014-10-28 13:58:32 -06:00
Ulrich Wilkens 01d6c363fa OpenIndiana and Solaris port 2014-10-28 13:40:11 -06:00
Ulrich Wilkens 42e891d9e7 Resolve many build warnings
This patch fixes many warnings from the beginning of the build up to
and including the depend stage. Nearly all warnings should be gone
even with -Wall.
2014-09-23 17:57:50 -06:00
Jon Trulson 2bf29e5d63 dtappbuilder: abmf.c: more warnings killed 2014-09-20 20:10:01 -06:00
Jon Trulson 9842ee3d96 dttypes: use regex on linux too. 2014-09-20 20:00:38 -06:00
Jon Trulson 0b68ebe610 dthelp: fixup some warnings with special.h(s) 2014-09-20 19:10:19 -06:00
Jon Trulson bf399748ad dtappbuilder/dtcodegen: Fix up some warnings, remove use of sys_errlist[].
Removed all the cases of sys_errlist[], no one should be using that
today.  Also, correct code generation so that declarations like
'Widget w = NULL; Pixmap p = NULL;' etc, aren't produced, which is
wrong.  Use '0', not NULL for these.

This should also correct the 2 mis-definitions of Pixmap that commit
6a9327f2ab attempted to fix in ttsnoop.

dtappbuilder still needs a lot of work.
2014-09-20 16:47:11 -06:00
Jon Trulson ba0f3a250d Revert "ttsnoop: NULL is not 0"
This reverts commit 6a9327f2ab.

The real fix for this (and other issues) needs to be done in dtcodegen.
2014-09-16 18:09:21 -06:00
Jon Trulson 6a9327f2ab ttsnoop: NULL is not 0
This fix is a bit of a hack, I just moved the declarations into the
'user code' portion of main().

dtcodegen needs to be fixed so as not to generate this type of code in
the first place.
2014-09-14 14:25:55 -06:00
Jon Trulson abfcb71d1d dtmail: MotifCmds.C: NULL is not False 2014-09-14 14:20:21 -06:00
Jon Trulson 5a205388e3 Add new Dtlogo from Jeff Pierquet. Original renamed to TOGDtlogo.pm 2014-09-12 10:44:13 -06:00
Ulrich Wilkens c6fd291e84 Fix panel right click 2014-09-12 10:39:06 -06:00
Ulrich Wilkens c3f74eec17 FreeBSD 10 clang port 2014-07-27 12:32:35 -06:00
Jon Trulson 7b5d1eb8c0 el_GR _common.dt.tmsg: fix corrupted msg line at line 1763 2014-07-22 16:42:55 -06:00
Jon Trulson c1d24e0bb3 fr_FR.ISO8859-1/types/_common.dt.tmsg: Fix up a couple of backslash errors.
Reported by Edmond Orignac.
2014-07-19 17:48:38 -06:00
Eugene Doudine a9dbe60805 Fixes a small bug in grid registration: when an object is placed over another object (can be done manually) and then removed from there, the registration of the covered object is removed as well (that is it's cell is considered empty).
The patch converts desktop_grid[] from Boolean array into array of
counters of objects, which are placed on cells. When object is
placed on /removed from   the screen  the counter gets incremented/decremented.
2014-04-19 18:57:57 -06:00
Eugene Doudine 5544a0fb39 Fixes several issues with grid registration of the dtwm panel on dtfile startup and on workspace addition:
The panel registration code rather stupidly assumed that display
  size is always 1280x1024 pixels. Because of this, depending on screen
  size, the panel could be registered somewhere in the center of the screen
  or completely or partially beyond of it.

  The panels were registered only on startup, not  those, which were added
  from UI.

The fix moves panel registration into separate routine and removes assumption
about display size. The fix yet is not complete since it still makes assumption
about panel's geometry: from dtfile there is still no way to find out
dinamically  the size of panel and it's location.
2014-04-19 18:57:57 -06:00
Eugene Doudine 8bafd85d9a Fixes the off-by-one bug in RegisterInGrid(), which caused dtfile's desktop icons on the right edge of the screen (if desktop width is not a multiple of icon with) to be registered on the next workspace or (in the case of the last workspace) beyond the desktop_grid array (possibly causing segfaults).
On small screens segfaults could be also triggered without any icons on dtfile
startup if dtwm panel (or part of it) was registered beyond the screen when
RegisterInGrid() was called by InitializeDesktopGrid().

The patch also makes grid registration work for large objects (larger than
2 cells in any direction, like dtwm panel or icon with long file name).
Previously only rectangle vertices were registered.
2014-04-19 18:57:57 -06:00
Jon Trulson 1e2bdf93a8 dtappbuilder: bil_store.c: don't return local variables 2014-04-06 16:59:56 -06:00
Jon Trulson aa15240c22 ttsnoop.C.src: NULL is not 0 2014-04-06 16:55:45 -06:00
Jon Trulson 10e295b967 WMSaveSession.C: NULL is not 0 2014-04-06 16:54:31 -06:00
Jon Trulson 4a22f0671b SendMsgDialog.C: NULL is not 0 2014-04-06 16:53:05 -06:00
Jon Trulson 20265cd088 RoamMenuWindow.C: NULL is not 0 2014-04-06 16:51:16 -06:00
Jon Trulson 0080185db9 RoamInterruptibleCmd.C: NULL is not 0 2014-04-06 16:49:24 -06:00
Jon Trulson b241414cda AttachArea.C: NULL is not 0, sprintf needs a format 2014-04-06 16:48:40 -06:00
Jon Trulson 8a96463f2e InterruptibleCmd.C, WorkingDialogManager.C: NULL is not 0 2014-04-06 16:46:09 -06:00
Jon Trulson 5f99b8045b dtsession: screensaver don't pass random attributes to XScreenSaverSetAttributes()
This should fix the "tiny window appearing in the screensavers"
problem.
2014-04-05 18:09:01 -06:00
Ulrich Wilkens 38dfc9e235 Fix dtinfo search engine 2014-04-01 16:52:36 -06:00
Jon Trulson 3c35e2d14d xtclient.c, spcd_event.c: stop referencing fds_bits directly 2014-03-24 19:37:09 -06:00
Jon Trulson 4312a1190b cleanup: eliminate missing sentinel warnings 2014-03-24 18:26:10 -06:00
Jon Trulson 165af415d1 dtcm/rfp.c: NULL is not 0 2014-03-24 17:49:19 -06:00
Jon Trulson 0a74d63db4 dtcm/reminders.c: NULL is not 0 2014-03-24 17:48:01 -06:00
Jon Trulson 9b699d3fb1 linux: build with thread safety and REENTRANT enabled.
There was a check in linux.cf for the Linux libc version that didn't
work, since these were never set anywhere.  Presumably current Xorg
imake sets these, but since we aren't using that... (yet)

As a result, the build assumed that thread-safe API's were not
supported.  Setting the default libc major version to '6' allows the
proper build to take place.  libc5 was never threadsafe and no one has
probably used it in over 10 years.

As a result, some earlier porting fixes that referenced '__fds_bits'
on linux systems had to be reverted as these are not valid in an MT
environment.  They are also not neccessary when building in such an
environment, as the normal 'fds_bits' works fine.

This patch defintely needs testing on many linux systems.
2014-03-24 17:15:40 -06:00
Jon Trulson b2db23c0af cleanup: eliminate "implicit declaration" warnings.
Also fixed a potential core/memory corruption in dticon.
2014-03-24 15:58:11 -06:00
Eugene Doudine 3ed9f06cce Fixed bug #32 dtfile table formatting bug with non-latin filenames 2014-03-23 13:53:44 -06:00
Eugene Doudine 5e9185dda5 Fixed bug #27 dtfile space handling bug 2014-03-23 13:53:44 -06:00
Eugene Doudine cd82567977 Fixes the bug #17 dtsession can't validate passwords longer than 8 characters when the session is locked 2014-03-23 13:53:44 -06:00
Jon Trulson 23e62e5782 dtcm/server/: just return NULL, not the address of a dummy local variable. Geez. 2014-03-22 19:23:46 -06:00
Jon Trulson 9ed39fd5f2 MotifUI.C: NULL is not 0 2014-03-22 19:14:38 -06:00
Jon Trulson 78fec87fa6 Threads.C: NULL is not 0 2014-03-22 19:09:46 -06:00
Jon Trulson 23d2ba3445 localized/util/merge.h: include string.h and fix up some warnings 2014-03-22 19:06:54 -06:00
Jon Trulson 4568a22f99 Icon.c: include stdlib.h 2014-03-22 19:01:49 -06:00
Jon Trulson daffaf7045 getdate.y: include string.h 2014-03-22 18:59:26 -06:00
Jon Trulson b9d1a4114e pax.h: include stdio.h 2014-03-22 18:56:21 -06:00
Jon Trulson 57ac9e33f9 PrintTopics.c: fix up some warnings 2014-03-22 18:50:15 -06:00
alx 2c162726c7 dtstyle: enable palette editor on true/direct color screens 2014-03-22 18:00:56 -06:00
Jon Trulson 6b0d0cd71e Updated Greek (el_GR.UTF-8) translations from Antonis Tsolomitis. 2014-03-22 17:37:50 -06:00
Peter Tribble 468d576030 initial illumos port 2014-03-22 16:33:11 -06:00
Ulrich Wilkens d24fd29b52 Fix dtfile and dtterm on NetBSD 2014-03-11 13:06:55 -06:00
Jon Trulson 1e0eb4e522 dtinfo: stub out XmPrint stuff if there is no XmPrint support. 2014-03-10 20:58:17 -06:00
Jon Trulson 7cbb2fa2a7 dtcm: stub out XmPrint stuff if there is no XmPrint support. 2014-03-10 20:43:32 -06:00
Jon Trulson b282d3fa87 dtmail: stub out XmPrint stuff if there is no XmPrint support. 2014-03-10 20:30:24 -06:00
Jon Trulson c39212f684 dtpad: stub out XmPrint stuff if there is no XmPrint support. 2014-03-10 20:07:16 -06:00
Jon Trulson 362a921245 dtdocbook/instant: *always* link with local libtcl.a
On some systems with libtcl installed, it might be linked into instant
rather than the locally provided version.  This can result in random
coredumps.

Seen on Ubuntu 12.04, x86_64.

Now, we force linking with ../tcl/libtcl.a.
2014-03-10 17:06:24 -06:00
Jon Trulson 0394dde3f9 nsgmls: fix up some gcc 4.8 warnings. 2014-03-09 14:24:00 -06:00
Eugene Doudine 1ff0741538 Addition of the en_US.UTF-8 locale: installation support 2014-02-26 19:49:20 -07:00
Eugene Doudine 46473a9ccb addition of en_US.UTF-8 locale: fonts.alias and fonts.dir files 2014-02-26 19:49:20 -07:00