Commit Graph

71 Commits

Author SHA1 Message Date
Jon Trulson 32e8827cbc dtfile/IconWindow: CID 88242,88702,89030 2018-04-11 16:25:52 -06:00
Jon Trulson 19d824c2cc dtfile/dtcopy/sharedFuncs: CID 88204,88291,88852,88861,88876 2018-04-11 16:25:52 -06:00
Jon Trulson 51b7590c63 dtfile/File: CID 88195,88595,88627,88794 2018-04-11 16:25:52 -06:00
Jon Trulson d30719f3a2 dtfile/SharedProcs: CID 88158,88337,89104,89118 2018-04-11 16:25:52 -06:00
Jon Trulson dd03c9cbf7 dtfile/FileDialog: CID 88141,88451,88658,89058 2018-04-11 16:25:52 -06:00
Jon Trulson 7e61925f1b dtfile/Desktop: CID 88133,88159,88339,88798,89331,89466 2018-04-11 16:25:52 -06:00
Jon Trulson 694b6ef5eb dtfile/Prefs: CID 88095,88407,89162,89164,89283,89445 2018-04-11 16:25:52 -06:00
Jon Trulson 56b53a30a1 Reimplement reverted commit 7fa35c to fix readlink() issues
Original implementation:

Commit: 7fa35cA
dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink

That commit caused dtfile to be unable to resolve symbolic links and
was later reverted.  This commit reimplements the fixes correctly, and
should hopefully still resolve the coverity issues as well.
2018-04-10 19:12:58 -06:00
Jon Trulson 9a3a9e3010 Revert "dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink"
This reverts commit 7fa35c29c4.
2018-04-05 15:44:37 -06:00
Jon Trulson 70f85d77cc dtfile/sharedFuncs: CID 88085; resource leak 2018-04-05 13:28:04 -06:00
Jon Trulson caa95ba67c dtfile: define MAX_PATH to PATH_MAX rather than 1024, also CID 87557 2018-04-05 12:49:06 -06:00
Jon Trulson f7d09f054d dtfile/SharedProcs.c: rework coverity 174852 fix to unbreak dtfile 2018-04-03 21:28:49 -06:00
Jon Trulson 3020b050ff dtfile/File.c: coverity CID 88919; uninit array read 2018-04-01 14:21:57 -06:00
Jon Trulson 7fa35c29c4 dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink 2018-04-01 13:46:04 -06:00
Jon Trulson b4c4fb594d dtfile/SharedProcs.c: coverity CID 174852; int overflow 2018-03-31 19:12:32 -06:00
Jon Trulson ec93faffe7 dtfile/Help.c: coverity CID 88484; use after free 2018-03-31 18:11:14 -06:00
Jon Trulson a8102e85e0 dtfile/Main.c: coverity CID 89623; uninit var 2018-03-31 17:34:40 -06:00
Jon Trulson e7269115b5 dtfile/sharedFuncs.c: coverity CID 88625; use after free 2018-03-31 17:25:35 -06:00
Jon Trulson c32b5db653 dtfile/SharedProcs.c: coverity CID 89068; use after free 2018-03-31 17:21:34 -06:00
alx 39031e9dea dtfile: added Xinerama support to dialog positioning routines 2016-12-31 15:14:49 -07:00
alx b251a15844 dtfile: Enable FILE_MAP_OPTIMIZE on Linux. This avoids unnecessary tt_file_netfile calls on local host. 2016-04-18 19:16:48 -06:00
alx ff7c7d72cf dtfile: Enable FILE_MAP_OPTIMIZE on FreeBSD. This avoids unnecessary tt_file_netfile calls on local host. 2016-04-18 19:16:47 -06:00
alx 307981f3e5 dtfile: fixed ambiguity in the translation table 2015-07-23 18:51:39 -06:00
alx 84f725bd54 dtfile: fixed file view scrolling with Page Up/Down keys 2015-07-23 18:51:34 -06:00
alx 5c6ddfd0c1 dtfile: 0 is not NULL 2015-07-16 19:21:18 -06:00
alx bd4a4532f0 dtfile: fixed double free in copy/move collision handler 2015-07-02 17:50:21 -06:00
Ulrich Wilkens 8b38d9ea49 Fix broken build on OpenBSD 2015-05-09 16:21:32 -06:00
Peter Howkins d3dbc00c1f dtfile: Resolve CID 89277 2015-01-15 15:37:32 +00:00
Peter Howkins 6a86dba654 dtfile: Resolve CID 88830 2015-01-15 15:30:59 +00:00
Peter Howkins 639081c8f1 dtfile: Resolve CID 89009 2015-01-15 15:26:22 +00:00
Peter Howkins 17ef8a8b34 dtfile: Resolve CID 89319 2015-01-15 15:25:13 +00:00
Peter Howkins 1ed848709d dtfile: Resolve CID 88199 2015-01-15 15:23:24 +00:00
Peter Howkins 7f70f509c8 dtfile: Resolve CID 88133, 88261 2015-01-15 15:18:21 +00:00
Peter Howkins 24880e4e05 dtfile: Resolve CID 87776. OkCallback is of type XtCallbackProc, it doesn't return one 2015-01-15 15:15:31 +00:00
Peter Howkins 74afeadda3 dtfile: Resolve CID 87308 2015-01-15 15:05:45 +00:00
Peter Howkins 22830f478a dtfile: resolve 19 compiler warnings. 2015-01-09 16:16:53 +00:00
alx 123d4ba8fc dtcopy: Fix file removal 2014-12-28 12:53:39 -07:00
Ulrich Wilkens 01d6c363fa OpenIndiana and Solaris port 2014-10-28 13:40:11 -06:00
Eugene Doudine a9dbe60805 Fixes a small bug in grid registration: when an object is placed over another object (can be done manually) and then removed from there, the registration of the covered object is removed as well (that is it's cell is considered empty).
The patch converts desktop_grid[] from Boolean array into array of
counters of objects, which are placed on cells. When object is
placed on /removed from   the screen  the counter gets incremented/decremented.
2014-04-19 18:57:57 -06:00
Eugene Doudine 5544a0fb39 Fixes several issues with grid registration of the dtwm panel on dtfile startup and on workspace addition:
The panel registration code rather stupidly assumed that display
  size is always 1280x1024 pixels. Because of this, depending on screen
  size, the panel could be registered somewhere in the center of the screen
  or completely or partially beyond of it.

  The panels were registered only on startup, not  those, which were added
  from UI.

The fix moves panel registration into separate routine and removes assumption
about display size. The fix yet is not complete since it still makes assumption
about panel's geometry: from dtfile there is still no way to find out
dinamically  the size of panel and it's location.
2014-04-19 18:57:57 -06:00
Eugene Doudine 8bafd85d9a Fixes the off-by-one bug in RegisterInGrid(), which caused dtfile's desktop icons on the right edge of the screen (if desktop width is not a multiple of icon with) to be registered on the next workspace or (in the case of the last workspace) beyond the desktop_grid array (possibly causing segfaults).
On small screens segfaults could be also triggered without any icons on dtfile
startup if dtwm panel (or part of it) was registered beyond the screen when
RegisterInGrid() was called by InitializeDesktopGrid().

The patch also makes grid registration work for large objects (larger than
2 cells in any direction, like dtwm panel or icon with long file name).
Previously only rectangle vertices were registered.
2014-04-19 18:57:57 -06:00
Eugene Doudine 3ed9f06cce Fixed bug #32 dtfile table formatting bug with non-latin filenames 2014-03-23 13:53:44 -06:00
Eugene Doudine 5e9185dda5 Fixed bug #27 dtfile space handling bug 2014-03-23 13:53:44 -06:00
Ulrich Wilkens d24fd29b52 Fix dtfile and dtterm on NetBSD 2014-03-11 13:06:55 -06:00
Ulrich Wilkens 2712d5f787 NetBSD port 2014-02-22 19:12:19 -07:00
alx 9dd8ea27bf dtfile: fclose called twice on same handle 2014-02-22 19:05:47 -07:00
Ulrich Wilkens 6b0da8f335 Introduction of BSDArchitecture 2013-10-20 16:23:40 -06:00
Ulrich Wilkens 2d08153289 correction of message files 2013-09-15 19:35:53 -06:00
Pascal Stumpf d821557ca4 Use same SIGCHLD handling for OpenBSD as for OSF. 2012-11-20 17:17:18 -07:00
Pascal Stumpf b64f79b1b8 On OpenBSD, use FILE_MAP_OPTIMIZED.
This has the effect of not performing a tt call each time in
ResolveLocalPathName() if we're on the local host anyway.  Drastically reduces
dtfile startup time.
2012-11-19 19:44:32 -07:00