Commit Graph

519 Commits

Author SHA1 Message Date
Peter Howkins d3dbc00c1f dtfile: Resolve CID 89277 2015-01-15 15:37:32 +00:00
Peter Howkins 6a86dba654 dtfile: Resolve CID 88830 2015-01-15 15:30:59 +00:00
Peter Howkins 639081c8f1 dtfile: Resolve CID 89009 2015-01-15 15:26:22 +00:00
Peter Howkins 17ef8a8b34 dtfile: Resolve CID 89319 2015-01-15 15:25:13 +00:00
Peter Howkins 1ed848709d dtfile: Resolve CID 88199 2015-01-15 15:23:24 +00:00
Peter Howkins 7f70f509c8 dtfile: Resolve CID 88133, 88261 2015-01-15 15:18:21 +00:00
Peter Howkins 24880e4e05 dtfile: Resolve CID 87776. OkCallback is of type XtCallbackProc, it doesn't return one 2015-01-15 15:15:31 +00:00
Peter Howkins 74afeadda3 dtfile: Resolve CID 87308 2015-01-15 15:05:45 +00:00
Peter Howkins f506dd71ac dtcm: Resolve CID 88003 2015-01-15 14:23:45 +00:00
Peter Howkins dcdf4e2a65 dtcm: Resolve CID 87983 2015-01-15 14:21:34 +00:00
Peter Howkins e063ab47d3 dtcm: Resolve CID 87822 2015-01-15 14:20:02 +00:00
Peter Howkins 9388ef6c5b dtcm: Resolve CID 87801 2015-01-15 14:18:17 +00:00
Peter Howkins 8ef7da82a3 dtcm: Resolve CID 87713 2015-01-15 14:16:06 +00:00
Peter Howkins d5c37e1ad6 dtcm: Resolve CID 87562 2015-01-15 12:10:25 +00:00
Peter Howkins 85b7e823c4 dtcm: Resolve CID 87408 2015-01-15 11:59:20 +00:00
Peter Howkins b578e9cc3a dtcm: Resolve CID 87384 2015-01-15 11:55:09 +00:00
Peter Howkins d53a979639 dtscreen: convert K&R prototypes to ansi C 2015-01-14 15:06:33 +00:00
Peter Howkins 917e6cfc49 dthello: Resolve 8 compiler warnings that would be introduced with -Wall 2015-01-14 10:42:44 +00:00
Peter Howkins f913c616ee dtpad: Resolve 7 compiler warnings. 2015-01-13 14:50:05 +00:00
Peter Howkins 8baeb4c0a0 dtcm: Resolve 303 compiler warnings. 2015-01-13 14:22:25 +00:00
Peter Howkins fe39b630b3 dtstyle: Fix CID 100252 2015-01-13 10:13:03 +00:00
Peter Howkins 90bd9101e3 dtmail: add a stdint.h include for openbsd, as reported by Daniel Diaz via the wiki. 2015-01-09 16:30:43 +00:00
Peter Howkins 22830f478a dtfile: resolve 19 compiler warnings. 2015-01-09 16:16:53 +00:00
Peter Howkins 561d858140 dticon: resolve 3 compiler warnings 2015-01-07 14:19:38 +00:00
Peter Howkins 93f3878b4e dtdocbook: resolve 49 compiler warnings. 2015-01-06 17:22:50 +00:00
Peter Howkins 0a0e1eebf5 dtmail: Resolve 50 compiler warnings. 2015-01-06 15:07:55 +00:00
Peter Howkins 3fab71345b dtsr: resolve all 12 compiler warnings. 2015-01-05 16:54:12 +00:00
Peter Howkins 466b8d0df5 dtstyle: resolve 30 compiler warnings. 2015-01-05 16:07:49 +00:00
Peter Howkins 8ed5281e3e dtwm: resolve 92 compiler warnings (related to 64 bit pointer to int coversions) 2014-12-30 17:13:41 +00:00
Peter Howkins 4a66f1ab61 dtaction: resolve 2 compiler warnings. 2014-12-30 16:12:54 +00:00
Peter Howkins 59bcb8d08f dsdm: convert k&r function declarations to ansi, and correct the warnings this then uncovered. 2014-12-30 15:57:12 +00:00
Peter Howkins 4fc0bcef0f dsdm: resolve coverity warnings CID 86139 86255 86331 86345 86418 86517 86526 86567 86590 86616 2014-12-30 15:13:47 +00:00
Peter Howkins 2fc7807ee5 dtcalc: resolve 13 compiler warnings on 64 bit builds. 2014-12-30 14:43:12 +00:00
alx 123d4ba8fc dtcopy: Fix file removal 2014-12-28 12:53:39 -07:00
Jon Trulson f6d6aafc93 Merge branch 'coverity_dtsession'
Fix up a bunch (55) issues in dtsession identified by Coverity's
static analysis.
2014-12-27 20:25:26 -07:00
Jon Trulson 4dae64c891 dtsession/SrvPalette: fix CID 89227 2014-12-27 20:09:09 -07:00
Jon Trulson 722cfc70eb dtsession/SrvFile_io: fix CID's 88299 and 89441 2014-12-27 20:06:53 -07:00
Jon Trulson aa2daba4af dtsession/SmUI: fix tainted var (CID 88216) 2014-12-27 19:52:37 -07:00
Jon Trulson db8280189d dtsession/SmSave: use absolute path to rm in system() 2014-12-27 19:42:21 -07:00
Jon Trulson e02c703af7 dtsession/SmSave: get rid of use of tempnam (CID 89359) 2014-12-27 19:33:03 -07:00
Jon Trulson 7c702bff6e dtsession/SmRestore: redo defaultCwd detection in StartClient() to be safer 2014-12-27 19:01:30 -07:00
Jon Trulson a657f302f7 dtsession/SmRestore: fixup 8 coverity issues. 2014-12-27 18:19:55 -07:00
Jon Trulson 65dcf12c82 dtsession/SmGlobals: re-add smGD.savePath to generated paths, was lost in mkstemp changes. 2014-12-27 17:50:28 -07:00
Jon Trulson 93783917ab dtsession/SmGlobals: unlink mkstemp generated files. 2014-12-27 17:24:04 -07:00
Peter Howkins ab743c37e6 dtlogin: resolve more static analysis warnings 2014-12-27 23:13:59 +00:00
Jon Trulson 4b38955b01 dtsession/SmGlobals: use of tainted string (CID 89450) 2014-12-27 16:12:45 -07:00
Jon Trulson 1bde7d8c5c dtsession/SmLock: potential null deref (CID 87561, 87957, 88181) 2014-12-27 16:06:23 -07:00
Jon Trulson f14df58edb dtsession/SmDB: error handling issues (CID 87778, 87926) 2014-12-27 15:54:55 -07:00
Jon Trulson 1148ae8794 dtsession/SmCommun: fix bogus check (CID 89326) 2014-12-27 15:50:29 -07:00
Jon Trulson 881b0e1ed0 dtsession/SmGlobals: fixup 17 coverity issues. 2014-12-27 15:42:04 -07:00
Peter Howkins c768260785 dtlogin: resolve 8 compiler warnings. 2014-12-27 20:56:29 +00:00
Jon Trulson 61e925f3c5 dtlogin/xdmcp: fixup many warnings and a possible declaration bug 2014-12-27 13:01:26 -07:00
Jon Trulson a71cde075e dtwm/WmFP: Coverity (memory corruption, moderate) 2014-12-26 18:10:07 -07:00
Jon Trulson f05c124807 dtwm/PopUpMenu: Coverity (memory corruption, moderate) 2014-12-26 17:30:50 -07:00
Jon Trulson 611dda1831 dtsession: Coverity (memory corruption, moderate) 2014-12-26 17:23:16 -07:00
Jon Trulson 055d98cafb dtscreen: Coverity (memory corruption, moderate) 2014-12-26 17:17:58 -07:00
Jon Trulson a5c7512782 dtprintinfo: Coverity (memory corruption, moderate) 2014-12-26 17:17:06 -07:00
Jon Trulson b881408be0 dtlogin: Coverity (memory corruption, moderate) 2014-12-26 16:55:46 -07:00
Jon Trulson 235a75c03c dtlogin: Coverity (memory corruption, moderate) 2014-12-26 16:23:54 -07:00
Jon Trulson 00540cb375 dtcalc: Coverity (memory corruption, moderate) 2014-12-26 16:19:23 -07:00
Jon Trulson ff3cd78ac0 dtcalc: Coverity (memory corruption, moderate) 2014-12-26 16:17:43 -07:00
Jon Trulson 07dc336b96 dtsession: Coverity (memory corruption) 2014-12-26 14:24:31 -07:00
Jon Trulson b41a74b595 dtsession: Coverity (memory corruption) 2014-12-26 14:22:05 -07:00
Jon Trulson 2e7ab68300 dtappbuilder: Coverity (memory corruption) 2014-12-26 14:14:32 -07:00
Peter Howkins bc842043d2 dtlogin: Resolve 27 compiler warnings 2014-12-23 22:01:51 +00:00
Peter Howkins e54c164fe1 dtlogin: start to resolve static analysis warnings
Also convert some K&R function declarations to ansi
2014-12-23 17:49:11 +00:00
Ulrich Wilkens 29294e0373 Fix FreeBSD 10.1 build 2014-11-20 17:48:57 -07:00
Jon Trulson bf0666a330 it_IT.ISO8859-1/types/_common.dt.tmsg: Apply manual one-line patch 2014-10-28 13:58:32 -06:00
Ulrich Wilkens 01d6c363fa OpenIndiana and Solaris port 2014-10-28 13:40:11 -06:00
Ulrich Wilkens 42e891d9e7 Resolve many build warnings
This patch fixes many warnings from the beginning of the build up to
and including the depend stage. Nearly all warnings should be gone
even with -Wall.
2014-09-23 17:57:50 -06:00
Jon Trulson 2bf29e5d63 dtappbuilder: abmf.c: more warnings killed 2014-09-20 20:10:01 -06:00
Jon Trulson 9842ee3d96 dttypes: use regex on linux too. 2014-09-20 20:00:38 -06:00
Jon Trulson 0b68ebe610 dthelp: fixup some warnings with special.h(s) 2014-09-20 19:10:19 -06:00
Jon Trulson bf399748ad dtappbuilder/dtcodegen: Fix up some warnings, remove use of sys_errlist[].
Removed all the cases of sys_errlist[], no one should be using that
today.  Also, correct code generation so that declarations like
'Widget w = NULL; Pixmap p = NULL;' etc, aren't produced, which is
wrong.  Use '0', not NULL for these.

This should also correct the 2 mis-definitions of Pixmap that commit
6a9327f2ab attempted to fix in ttsnoop.

dtappbuilder still needs a lot of work.
2014-09-20 16:47:11 -06:00
Jon Trulson ba0f3a250d Revert "ttsnoop: NULL is not 0"
This reverts commit 6a9327f2ab.

The real fix for this (and other issues) needs to be done in dtcodegen.
2014-09-16 18:09:21 -06:00
Jon Trulson 6a9327f2ab ttsnoop: NULL is not 0
This fix is a bit of a hack, I just moved the declarations into the
'user code' portion of main().

dtcodegen needs to be fixed so as not to generate this type of code in
the first place.
2014-09-14 14:25:55 -06:00
Jon Trulson abfcb71d1d dtmail: MotifCmds.C: NULL is not False 2014-09-14 14:20:21 -06:00
Jon Trulson 5a205388e3 Add new Dtlogo from Jeff Pierquet. Original renamed to TOGDtlogo.pm 2014-09-12 10:44:13 -06:00
Ulrich Wilkens c6fd291e84 Fix panel right click 2014-09-12 10:39:06 -06:00
Ulrich Wilkens c3f74eec17 FreeBSD 10 clang port 2014-07-27 12:32:35 -06:00
Jon Trulson 7b5d1eb8c0 el_GR _common.dt.tmsg: fix corrupted msg line at line 1763 2014-07-22 16:42:55 -06:00
Jon Trulson c1d24e0bb3 fr_FR.ISO8859-1/types/_common.dt.tmsg: Fix up a couple of backslash errors.
Reported by Edmond Orignac.
2014-07-19 17:48:38 -06:00
Eugene Doudine a9dbe60805 Fixes a small bug in grid registration: when an object is placed over another object (can be done manually) and then removed from there, the registration of the covered object is removed as well (that is it's cell is considered empty).
The patch converts desktop_grid[] from Boolean array into array of
counters of objects, which are placed on cells. When object is
placed on /removed from   the screen  the counter gets incremented/decremented.
2014-04-19 18:57:57 -06:00
Eugene Doudine 5544a0fb39 Fixes several issues with grid registration of the dtwm panel on dtfile startup and on workspace addition:
The panel registration code rather stupidly assumed that display
  size is always 1280x1024 pixels. Because of this, depending on screen
  size, the panel could be registered somewhere in the center of the screen
  or completely or partially beyond of it.

  The panels were registered only on startup, not  those, which were added
  from UI.

The fix moves panel registration into separate routine and removes assumption
about display size. The fix yet is not complete since it still makes assumption
about panel's geometry: from dtfile there is still no way to find out
dinamically  the size of panel and it's location.
2014-04-19 18:57:57 -06:00
Eugene Doudine 8bafd85d9a Fixes the off-by-one bug in RegisterInGrid(), which caused dtfile's desktop icons on the right edge of the screen (if desktop width is not a multiple of icon with) to be registered on the next workspace or (in the case of the last workspace) beyond the desktop_grid array (possibly causing segfaults).
On small screens segfaults could be also triggered without any icons on dtfile
startup if dtwm panel (or part of it) was registered beyond the screen when
RegisterInGrid() was called by InitializeDesktopGrid().

The patch also makes grid registration work for large objects (larger than
2 cells in any direction, like dtwm panel or icon with long file name).
Previously only rectangle vertices were registered.
2014-04-19 18:57:57 -06:00
Jon Trulson 1e2bdf93a8 dtappbuilder: bil_store.c: don't return local variables 2014-04-06 16:59:56 -06:00
Jon Trulson aa15240c22 ttsnoop.C.src: NULL is not 0 2014-04-06 16:55:45 -06:00
Jon Trulson 10e295b967 WMSaveSession.C: NULL is not 0 2014-04-06 16:54:31 -06:00
Jon Trulson 4a22f0671b SendMsgDialog.C: NULL is not 0 2014-04-06 16:53:05 -06:00
Jon Trulson 20265cd088 RoamMenuWindow.C: NULL is not 0 2014-04-06 16:51:16 -06:00
Jon Trulson 0080185db9 RoamInterruptibleCmd.C: NULL is not 0 2014-04-06 16:49:24 -06:00
Jon Trulson b241414cda AttachArea.C: NULL is not 0, sprintf needs a format 2014-04-06 16:48:40 -06:00
Jon Trulson 8a96463f2e InterruptibleCmd.C, WorkingDialogManager.C: NULL is not 0 2014-04-06 16:46:09 -06:00
Jon Trulson 5f99b8045b dtsession: screensaver don't pass random attributes to XScreenSaverSetAttributes()
This should fix the "tiny window appearing in the screensavers"
problem.
2014-04-05 18:09:01 -06:00
Ulrich Wilkens 38dfc9e235 Fix dtinfo search engine 2014-04-01 16:52:36 -06:00
Jon Trulson 3c35e2d14d xtclient.c, spcd_event.c: stop referencing fds_bits directly 2014-03-24 19:37:09 -06:00
Jon Trulson 4312a1190b cleanup: eliminate missing sentinel warnings 2014-03-24 18:26:10 -06:00
Jon Trulson 165af415d1 dtcm/rfp.c: NULL is not 0 2014-03-24 17:49:19 -06:00
Jon Trulson 0a74d63db4 dtcm/reminders.c: NULL is not 0 2014-03-24 17:48:01 -06:00
Jon Trulson 9b699d3fb1 linux: build with thread safety and REENTRANT enabled.
There was a check in linux.cf for the Linux libc version that didn't
work, since these were never set anywhere.  Presumably current Xorg
imake sets these, but since we aren't using that... (yet)

As a result, the build assumed that thread-safe API's were not
supported.  Setting the default libc major version to '6' allows the
proper build to take place.  libc5 was never threadsafe and no one has
probably used it in over 10 years.

As a result, some earlier porting fixes that referenced '__fds_bits'
on linux systems had to be reverted as these are not valid in an MT
environment.  They are also not neccessary when building in such an
environment, as the normal 'fds_bits' works fine.

This patch defintely needs testing on many linux systems.
2014-03-24 17:15:40 -06:00