Commit Graph

592 Commits

Author SHA1 Message Date
Jon Trulson 7e61925f1b dtfile/Desktop: CID 88133,88159,88339,88798,89331,89466 2018-04-11 16:25:52 -06:00
Jon Trulson 694b6ef5eb dtfile/Prefs: CID 88095,88407,89162,89164,89283,89445 2018-04-11 16:25:52 -06:00
Peter Howkins db88cb0d13 dtpad: resove coverity issues 2018-04-11 18:05:06 +01:00
Jon Trulson 56b53a30a1 Reimplement reverted commit 7fa35c to fix readlink() issues
Original implementation:

Commit: 7fa35cA
dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink

That commit caused dtfile to be unable to resolve symbolic links and
was later reverted.  This commit reimplements the fixes correctly, and
should hopefully still resolve the coverity issues as well.
2018-04-10 19:12:58 -06:00
Peter Howkins 10468068ac dthelp: more coverity fixes 2018-04-11 02:07:55 +01:00
Jon Trulson 9a3a9e3010 Revert "dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink"
This reverts commit 7fa35c29c4.
2018-04-05 15:44:37 -06:00
Jon Trulson 70f85d77cc dtfile/sharedFuncs: CID 88085; resource leak 2018-04-05 13:28:04 -06:00
Jon Trulson caa95ba67c dtfile: define MAX_PATH to PATH_MAX rather than 1024, also CID 87557 2018-04-05 12:49:06 -06:00
Peter Howkins 494fd64314 dtinfo/dtinfogen: Fix segfault introduced by over zealously fixing coverity resource leak 2018-04-05 18:16:10 +01:00
Peter Howkins bc28c20524 dtinfo: fix coverity issues related to null checks after dereference 2018-04-04 22:42:06 +01:00
Peter Howkins 2b15c4057e dtinfo: Fix coverity issues for resource leaks 2018-04-04 22:07:10 +01:00
Peter Howkins 9ef3b9ec68 dtspcd: Cov 89547, 175089 2018-04-04 20:37:13 +01:00
Peter Howkins 2d91ff7a6f dsdm: cov 86572, free mem in error condition 2018-04-04 16:50:19 +01:00
Peter Howkins d87f6ce29d Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code 2018-04-04 16:37:12 +01:00
Peter Howkins 4fc13a6e27 dtwm: cov 175166, check for pointer 2018-04-04 16:33:45 +01:00
Jon Trulson f7d09f054d dtfile/SharedProcs.c: rework coverity 174852 fix to unbreak dtfile 2018-04-03 21:28:49 -06:00
Jon Trulson 8f7c874ba0 fontaliases: use copy rather than symlink since bdftopcf can't handle those
bdftopcf specifically will not read symbolic links.  This causes it to
fail when creating the programs/fontaliases/*/C/dtinfo.pcf.Z file and
subsequently, the fonts.dir file.

So, we add a new Imake macro: CopySourceFile(), to copy rather than
symlink the dtinfo.bdf file so these operations can complete
successfully.  The dtinfo.bdf file is only 5KB, so there's very little
impact having an extra copy created during a build.
2018-04-03 13:03:26 -06:00
Jon Trulson 7f70748d65 Disable building of dtudcfonted and dtudcexch
This software has a variety of problems, like including renamed X11
header files, and other nuttery.

These programs also have a very limited use, I doubt most people even
know what they are for or will miss them.

This commit prevents them from being built and installed.  If no-one
volunteers to get these into decent shape after the next release, they
will be removed from the repository.
2018-04-02 19:38:14 -06:00
Jon Trulson c4e7d35519 dtcm/dssw.c: fix typo 2018-04-02 18:43:14 -06:00
Jon Trulson ba95bbc073 dtudcfonted/gpftobdf.c: Coverity CID 175168; NULL deref 2018-04-02 18:23:22 -06:00
Jon Trulson 45bccb474c dtcalc/ds_xlib.c: Coverity CID 175167; uninit value 2018-04-02 18:07:54 -06:00
Jon Trulson d5c304d476 dtcm/dssw.c: Coverity CID 88672; dest buf too small 2018-04-02 17:02:16 -06:00
Jon Trulson f269c2a074 dtsr/dtsrclean.c: Coverity CID 86876; dest buf too small 2018-04-02 17:02:16 -06:00
Peter Howkins bcee6be5d8 Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code 2018-04-02 20:32:56 +01:00
Peter Howkins 0b38496bd8 dtmail: resolve 'deference before null check' errors related to if(!NULL) checks around free() calls 2018-04-02 20:29:28 +01:00
Jon Trulson 2cac2a29ac dtwm/WmResource.c: remove errant ')' added in previous commit 2018-04-02 12:22:32 -06:00
Peter Howkins 8362f92ceb dtwm: Resolve coverity warnings 2018-04-02 18:08:40 +01:00
Jon Trulson 4b9bcae29f dtcreate/fileio.c: coverity CID 175094; dref bef NULL 2018-04-01 18:41:54 -06:00
Jon Trulson dbe044c24c dtcreate/CreateActionAppShell.c: coverity CID 175092; uninit ptr read 2018-04-01 18:35:14 -06:00
Jon Trulson 2363b97d60 dtcalc: remove MAX_PATH, use standard PATH_MAX 2018-04-01 18:33:00 -06:00
Jon Trulson ce471d7068 dtcalc/ds_xlib.c: coverity CID 175093; wrong sizeof/bad free 2018-04-01 18:30:10 -06:00
Jon Trulson 75a892d93f dtudcfonted/_faludcInf.c: coverity CIDs 175096,175092; uninit ptr read 2018-04-01 18:06:10 -06:00
Jon Trulson 03ba4e454c dtudcfonted/gpftobdf.c: coverity CIDs 87073,87008,87029,86919,86898,86715; uninit scalar 2018-04-01 14:42:38 -06:00
Jon Trulson 3020b050ff dtfile/File.c: coverity CID 88919; uninit array read 2018-04-01 14:21:57 -06:00
Jon Trulson cd70f1660d dthelp/Initialize.c: coverity CID 89569; unbounded src buf 2018-04-01 14:16:18 -06:00
Jon Trulson 0843325a43 dtcm/props.c: coverity CID 88573; unbounded src buf 2018-04-01 14:04:25 -06:00
Jon Trulson adb0acbaf5 dtudcfonted/getfname.c: coverity CID 86392; insecure readlink 2018-04-01 13:46:14 -06:00
Jon Trulson 7fa35c29c4 dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink 2018-04-01 13:46:04 -06:00
Jon Trulson b4c4fb594d dtfile/SharedProcs.c: coverity CID 174852; int overflow 2018-03-31 19:12:32 -06:00
Jon Trulson 77d10002bf dtmail/MsgScrollingList.C: coverity CID 87360; memset no effect 2018-03-31 18:55:56 -06:00
Jon Trulson 05773d7499 dtinfo/OutlineListViewMotif.C: coverity CID 87754; memset truncated 2018-03-31 18:53:29 -06:00
Jon Trulson 7752966865 dthelp/helpgen.c: coverity CID 175085; use after free 2018-03-31 18:21:14 -06:00
Jon Trulson ec93faffe7 dtfile/Help.c: coverity CID 88484; use after free 2018-03-31 18:11:14 -06:00
Jon Trulson bbf028becc dthelp/htag/malloc: coverity CID 86955; use after free 2018-03-31 17:52:27 -06:00
Jon Trulson ecee8b3f3a dtmail/DtMailRc.C: coverity CID 88975; use after free 2018-03-31 17:46:53 -06:00
Jon Trulson a8102e85e0 dtfile/Main.c: coverity CID 89623; uninit var 2018-03-31 17:34:40 -06:00
Jon Trulson e7269115b5 dtfile/sharedFuncs.c: coverity CID 88625; use after free 2018-03-31 17:25:35 -06:00
Jon Trulson c32b5db653 dtfile/SharedProcs.c: coverity CID 89068; use after free 2018-03-31 17:21:34 -06:00
Jon Trulson 0c0b77a509 dtinfo/MixedGen.C: coverity CID 89495; use after free 2018-03-31 14:42:22 -06:00
Jon Trulson 3c72e21cb2 dtspcd: coverity CID 174742; potential NULL derefs 2018-03-31 14:33:31 -06:00