e9bb2bcf09
libDtSvc: Resolve 89 compiler warnings.
2012-09-01 21:35:10 +01:00
92743e0999
libDtSearch: Resolve 26 compiler warnings.
2012-09-01 20:54:23 +01:00
ceb49b9130
DtWidget: Improve portability of Motif interface
...
- Add missing includes and prototypes
- Improve type compatibility
- Use <Xm/XmPrivate.h> for unofficial libXm headers
With this patch, dtpad no longer crashes on startup
on FreeBSD/amd64 because of a truncated 64-bit pointer.
2012-08-30 19:43:56 -06:00
71f8af6943
dthelp: Resolve 106 compiler warnings.
2012-08-30 21:37:25 +01:00
31c2131935
libDtTerm: Resolve all -Wformat-security warnings.
2012-08-27 20:36:59 +01:00
3911acddf6
libDtSearch: resolve -Wformat-secuirty warning
2012-08-27 20:24:06 +01:00
8479d150e2
libtt: Resolve all remaining format-security warnings.
2012-08-26 22:19:27 +01:00
8c8a5380ca
libtt: Warning prevention
...
One missing stdlib include and one security warning about not
using varargs func correctly.
2012-08-26 19:48:55 +01:00
98b17d3551
64bit: Fix crash in dtexec
...
No ANSI prototype for malloc() caused
the returned pointer to be truncated
to 32 bits.
2012-08-23 19:56:43 -06:00
8a78cc767e
libtt: resolve implicit delaration of free() and exit() warnings
2012-08-22 12:39:25 +01:00
0b623d4b63
lib/DtHelp: Include <stdio.h> to prevent warnings about implicit declartion of free()
2012-08-22 12:10:10 +01:00
f6f54a4037
libcsa: Warning prevention
...
Remove 'implicit declaration' warnings by included correct ANSI C headers.
Correct some format strings for long ints.
2012-08-22 11:53:08 +01:00
e7ec2a4bdd
Merge branch 'EnvControl-fixes'
2012-08-17 06:01:19 -06:00
90376fc6d8
Merge branch 'master' of https://git.code.sf.net/p/cdesktopenv/code
2012-08-17 10:26:09 +01:00
27d5cc033d
DtSvc:EnvControl: Use more modern and less dangerous methods of manipulating the env.
...
This should work for both linux and the BSD's... It should hopefully
solve the corrupted environment errors Marcin sees on fbsd 9 amd64.
2012-08-16 18:26:50 -06:00
d8db13985c
Fix compiler warnings in dtsession
2012-08-16 16:15:49 -06:00
0cbd88018a
Merge branch 'master' of https://git.code.sf.net/p/cdesktopenv/code
2012-08-16 15:41:15 +01:00
7bdb847210
Process sgml and man files in doc directory for FreeBSD.
2012-08-15 15:56:03 -06:00
91b33b7158
Merge branch 'master' of https://git.code.sf.net/p/cdesktopenv/code
2012-08-15 17:07:35 +01:00
66e428596b
mp_session: Always use global displayname
...
This code tried to automatically generate the X DISPLAY
from the combination of the hostname and display number;
however 127.0.0.1:0 is normally rejected by X11, so this
technique is no good. Fixes dticon hang on startup, caused by
XOpenDisplay failure leading to this message from tttrace:
tt_default_session_set(0x0x875190=="X 127.0.0.1 0") = 1032 (TT_ERR_ACCESS)
2012-08-14 20:37:59 -06:00
e8ff159737
const char maze: unbreak ToolTalk build
...
Follow up to de82eebdd5
2012-08-14 20:37:23 -06:00
de82eebdd5
Have to pass a const char * to function expecting char * here, otherwise it fails to link thanks to the declaration of a stub wth non-const param.
2012-08-14 12:44:20 -06:00
e738704385
Fix most of the following classes of warnings in the ToolTalk libraries:
...
- Const strings referenced by non-const variables.
- Incorrect format specifers for printing addresses
- Unused variables
- Signed comparison to unsigned
Also fix an incorrect enumeration value in a switch statement.
2012-08-14 12:43:44 -06:00
31aaa48344
FreeBSD port: dtsearch, dtterm, dtwidget, dthelp
...
FreeBSD portability of dtsearch, dtterm, dtwidget, dthelp
Work in progress for dtlogin and dtmail
2012-08-13 19:53:10 -06:00
50e6c86bf4
lib/csa: Use ANSI C prototypes
...
Improve type compatibility and enable
ANSI C prototypes.
2012-08-13 19:24:23 -06:00
aa12f819dd
Cast registerrpc args to xdrproc_t explicitly
...
Fixes:
agent.c: In function '_DtCm_init_agent':
agent.c:160: warning: passing argument 5 of 'registerrpc' from incompatible pointer type
agent.c:160: warning: passing argument 6 of 'registerrpc' from incompatible pointer type
agent.c:167: warning: passing argument 5 of 'registerrpc' from incompatible pointer type
agent.c:167: warning: passing argument 6 of 'registerrpc' from incompatible pointer type
2012-08-13 19:23:37 -06:00
706fccb50e
NULL is a pointer, not string terminator
...
Replace some instances of NULL to '\0', when
referring to string terminator.
2012-08-13 19:23:34 -06:00
0ecef859cf
Merge branch 'master' of https://git.code.sf.net/p/cdesktopenv/code
2012-08-13 10:31:07 +01:00
bf8c5e674f
Compile ToolTalk on FreeBSD
...
Fix const correctness problems with OPT_CONST_CORRECT:
tt_xdr_utils.C: In constructor '_Tt_xdr_size_stream::_Tt_xdr_size_stream()':
tt_xdr_utils.C:150: error: invalid conversion from 'bool_t (*)(__rpc_xdr*, long int*)' to 'bool_t (*)(__rpc_xdr*, const long int*)'
tt_xdr_utils.C:151: error: invalid conversion from 'bool_t (*)(__rpc_xdr*, char*, unsigned int)' to 'bool_t (*)(__rpc_xdr*, const char*, u_int)'
tt_xdr_utils.C:159: error: invalid conversion from 'bool_t (*)(__rpc_xdr*, char*, unsigned int)' to 'bool_t (*)(__rpc_xdr*, const char*, u_int)'
tt_entry_pt.C: In function '_Tt_string _tt_entrypt_to_string(_Tt_entry_pt)':
tt_entry_pt.C:455: error: conversion from 'long int' to '_Tt_string' is ambiguous
../../lib/util/tt_string.h:104: note: candidates are: _Tt_string::_Tt_string(int)
../../lib/util/tt_string.h:102: note: _Tt_string::_Tt_string(const char*)
2012-08-12 20:57:49 -06:00
fa3ad160e4
Fix broken linux builds caused by recent DtHelp/Imakefile jpeg change
...
A patch from Pascal Stumpf using external jpeg broke linux builds,
since libjpeg needs to be linked in when using a remote jpeg lib.
So, in lnxLib.tmpl, define SharedDtHelpReqs so -ljpeg is used. Also,
in DtHelp/Imakefile, use proper Arch defines so external jpeg libs are
only used on linux, fbsd, and obsd systems.
2012-08-12 17:31:28 -06:00
a1cbcd24db
Low-hanging fruit: Fix most warnings in lib/DtSearch.
...
Most of these are related to missing includes and prototypes as well as
parens/braces. A few are also potential 64bit issues.
2012-08-12 14:20:58 -06:00
0bbd4ff9aa
Get rid of malloc.h.
...
This is a non-POSIX/ISO-C header. It is ok to include this on Linux, but it
is obsolete on BSD; FreeBSD even throws an error if you include it with
__STDC__ defined. Every system should nowadays have malloc() defined in
stdlib.h.
Diff is largely mechanical, replacing malloc.h with stdlib.h where it is not
yet included anyway.
2012-08-12 14:20:58 -06:00
aa9ea72bfb
Do not use internal libjpeg.
...
Nowadays, OpenMotif is itself linked to libjpeg, so pulling in another
version of it causes symbol size mismatches, not to mention the maintenance
burden and security implications arising from keeping our own copy of libjpeg.
We still need some of the header files provided here because they are internal
to libjpeg and not installed on most distributions.
2012-08-12 14:20:57 -06:00
b33cf9fb60
tooltalk: Fix bad assumptions about sizeof(uid_t)
...
In part of the tooltalk rpc code (mp_message.c), it was assumed that on
the majority of platforms, sizeof(uid_t)=sizeof(gid_t)=sizeof(long). On
Linux-x64, uid_t is an unsigned int, which makes the code fail: all
tooltalk messages fail to send with an RPC_CANTENCODEARGS at the
rpc-level, and TT_INTERNAL_ERR for the actual program. We instead
change the code to explicitly examine sizeof(uid_t) to see whether it is
int or long sized. This allows tooltalk-dependent functinoality
like logout and multiple calls to dtfile to work.
2012-08-12 13:50:34 -06:00
19c7c80aa3
tt (tooltalk): Kill some warnings
...
Includes some potentially bad pointer/int conversions
2012-08-11 20:13:46 -06:00
5ad7a83985
tttrace: Fix bad usage of va_arg with enums
...
Enums may be represented with a smaller type than int; however, they are
automatically promoted to int when passed in va_arg lists, just as
short, char, etc. are. GCC thus "knows" that you never want to call
va_arg with an enum type, and instead inserts an abort.
2012-08-11 20:13:46 -06:00
131c7a9e04
Imakefile diffs for OpenBSD.
2012-08-11 19:23:43 -06:00
3718075b7c
OpenBSD fixes for DtWidget, dtaction, dtappbuilder.
2012-08-10 14:10:52 -06:00
8bbf5a7a1b
Allow dtterm to at least allocate a pty on OpenBSD. Display is still mangled, however, and it frequently crashes (64bit issue).
2012-08-10 14:08:48 -06:00
19647809e4
OpenBSD fixes for lib/DtTerm: values.h, #ifdef's and some constants that are not defined on BSD. Also, leave out utmp stuff that does not work on BSD. Note that this terminal allocation does not work properly yet, but this will be fixed later.
2012-08-10 14:07:36 -06:00
3b77d7c065
Tooltalk fixes for OpenBSD. This consists mainly of #ifdefs, casts and some small type nits.
2012-08-10 06:24:29 -06:00
3d5a492038
OpenBSD fixes for DtPrint and csa.
2012-08-10 06:18:28 -06:00
185ec24999
OpenBSD fixed for lib/DtSvc.
2012-08-10 05:51:37 -06:00
78053ff2a4
SIGPWR is not present everywhere.
2012-08-10 05:44:49 -06:00
d1848610a7
Remove ambiguity in string compare.
2012-08-09 13:55:54 -06:00
3f11777812
"ISO C++ forbids declaration of [X] with no type" warning fixes.
2012-08-09 13:55:54 -06:00
1f332de27b
Use socklen_t where available.
...
Patch from <Pascal.Stumpf@cubes.de>
This should use socklen_t where available, really ...
2012-08-09 12:27:58 -06:00
491ff2228f
Deal with the fact that modern compilers assume different scoping rules
...
Patch from Pascal Stumpf <Pascal.Stumpf@cubes.de>:
So here are all the patches that deal with the fact that modern
compilers assume different scoping rules for variables declared in for
loops. On Linux, -fpermissive has been added as a compiler flag to
compensate for this old C code, but I think it is the wrong approach.
Sorry, couldn't help sneaking in a || defined(CSRG_BASED) and some casts
needed for other reasons ...
2012-08-09 12:18:30 -06:00
1d935059fb
Fix more sprintf calls.
2012-08-09 11:57:34 -06:00
1dd2eaf854
Update the sub parts of the main dt/cde version number to 2.2.0, missed from previous version increment patch.
2012-08-09 15:20:53 +01:00
facb50dfde
DtSvc: Fixes a segfault on Debian squeeze 64 bit and most probably other systems, too.
...
Patch from Marc Balmer <marc@msys.ch>:
Use strlen, not sizeof, here. Fixes a segfault on Debian squeeze 64 bit
and most probably other systems, too.
2012-08-08 12:45:40 -06:00
0f313d1cb8
libtt: "%wc" is Microsoft extension, not supported in every Std C Library.
...
Patch from Douglas Mencken <dougmencken@gmail.com>:
"%wc" is Microsoft extension, not supported in every Std C Library. So
if we don't want to print "%wc%wc%wc%wc%..." instead of real chars, we
shall not use it.
Before:
%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wcession[28326]:
_Tt_s_session::s_init(): 1051 (TT_ERR_INTERNAL)!
%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wcession[28326]: waitpid():
No child processes
%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wc%wcession[28326]: child
ttsession exited with status 1
After:
/usr/dt/bin/ttsession[12397]: _Tt_s_session::s_init(): 1051 (TT_ERR_INTERNAL)!
/usr/dt/bin/ttsession[12397]: waitpid(): No child processes
/usr/dt/bin/ttsession[12397]: child ttsession exited with status 1
2012-08-08 12:35:49 -06:00
f9c2b3184e
DtSvc/dtwm: Fix some implicit declarations of functions by adding appropriate
...
Patch from Frederic Koehler <f.koehler427@gmail.com>:
These implicit definitions cause segfaults on x64 because
the implicit return type is a 32-bit signed int, rather than a pointer
type.
2012-08-08 11:47:18 -06:00
b49872206b
libtt: Avoid an infinite loop in ttsession (tooltalk daemon) when /etc/mtab is a symlink, using lstat instead of stat.
...
Patch from Frederic Koehler <f.koehler427@gmail.com>
2012-08-08 11:36:03 -06:00
91011085a4
dtdbcache: remove incorrect comment block and tmpnam_buf var (not used)
...
With Aaron's fixes to dtdbcache fixing a potential coredump, the
comment block in the write_db() function regarding tmpnam() no longer
applies, and the tmpnam_buf variable is no longer used.
So, remove them :)
2012-08-07 17:43:32 -06:00
80f456e3b5
dtdbcache: Remove old code in comments
...
Patch from Aaron W. Hsu <arcfide@sacrideo.us>
2012-08-07 16:56:11 -06:00
04b366b09c
dtdbcache: Use mkstemp() instead of tmpnam() to avoid bad interactions
...
Patch from Aaron W. Hsu <arcfide@sacrideo.us>
2012-08-07 16:52:26 -06:00
5e6b400c3c
libtt: client init(): use fcntl F_SETFD correctly.
2012-07-27 19:17:14 -06:00
6eebf7d42c
Increment CDE version number to 2.2.0
2012-07-16 15:23:40 +01:00
75f2f96793
libDtHelp: fix up some warnigs and potential overruns
2012-07-12 18:03:54 -06:00
aeaec445ee
DtSvc/DtUtil1/Saver.c - fix the screen savers.
...
I have no idea how their putenv code can work. Anyway, use code that
works on linux now. :)
2012-07-12 15:14:51 -06:00
84e3c43b90
agent.c: oops - include poll.h, not sys/poll.h
2012-06-19 17:31:28 -06:00
d5deec6e72
csa/agent.c: use select rather than poll
2012-06-19 16:51:25 -06:00
cdf8003f7c
Remove hardcoded CCLINK's in Imakefiles when linking with C++ built libs (DtSvc).
...
Added proper SharedDtSvcReqs in lnxLib.tmpl and CplusplusLibC in
linux.cf. This allows the libstdc++ dependancy to be properly
declared for libDtSvc so that it is not neccessary to hardcode 'CCLINK
= g++' in the Imakefiles of programs linking angainst libDtSvc.
2012-06-19 16:27:20 -06:00
fff18bf2b7
doc/help localization changes
...
- by default, do not build any other locale than C for now
- do not try to build the guides. These require functioning
dtinfo/docbook
- add a Linux.lcx locale translation db. Not used yet.
- fix some overflows in dtdocbook/instant
2012-06-18 22:01:02 -06:00
784c7dff56
Add -fpermissive to linux standard c++ option define in linux.cf
...
Remove from individual Imakefiles.
Also, remove '#if 0' block in linux.cf, and remove empty
LinuxMachineDefines. This should be working correctly. If not, let me
know.
2012-06-18 16:27:25 -06:00
91f7988cf3
dtterm: fixes so job control will work.
2012-06-18 16:01:17 -06:00
62b669a6af
dtterm: disable svr4 streams semantics on linux
2012-06-18 15:32:02 -06:00
837972cb69
Modify all Imakefile files to use LinuxArchitecture instead of LinuxDistribution
...
for Linux specific changes. (lib directory)
2012-05-31 12:41:33 +01:00
b4f3efb692
DtSvc/dtspcd: fixes for VU#172583
2012-05-26 19:09:33 -06:00
70128313e9
tt_isam_record.C/tt_isam_record.C: fix CERT VU#387387 part 3
2012-05-26 18:39:51 -06:00
95e6fd42cc
tt_isam_record.C: fix CERT VU#387387 part 2
2012-05-26 18:29:26 -06:00
e820f21540
tt_isam_record.C: fix CERT VU#387387
2012-05-26 18:28:02 -06:00
3231696f03
dm_server.C: fix CERT VU#975403/VU#299816
2012-05-26 18:24:31 -06:00
8e4e53f4b9
FileUtils.c: fix CERT VU#575804
2012-05-26 18:14:58 -06:00
43a91fa718
Don't include a couple of non-existant svr4 files on linux.
2012-03-20 20:50:16 +00:00
1476da61f7
Change over Linux to using the System V style pty code, it seems at some
...
point Linuxes pty code is no longer the BSD legacy one by default anymore.
2012-03-20 20:43:06 +00:00
348f3cd81c
Change detector for linux platform to match other Imakefile changes
2012-03-12 21:26:30 +00:00
e321b293c1
When linking against C++ libraries gcc insists on using the C++ linker
2012-03-12 00:44:14 +00:00
84139c3575
On Linux don't redefine the prototypes to malloc() and realloc() to the wrong
...
things.
2012-03-12 00:37:58 +00:00
86909a64f0
Linux is a unistdh platform not an osfcn.h
2012-03-12 00:35:06 +00:00
54e8940874
linux is a unistd.h platform not a osfcn.h
2012-03-12 00:33:44 +00:00
50465f5a87
-fpermissive to allow gcc to compile old C++
2012-03-12 00:32:10 +00:00
0ce783f018
Do not redefine prototype of exit() under linux
2012-03-12 00:31:10 +00:00
ee22401f76
Add <unistd.h> include for getopt()
2012-03-12 00:29:37 +00:00
e2f33fe1dd
-fpermissive to allow gcc to compile old C++
2012-03-12 00:27:41 +00:00
e68afb01e6
-fpermissive to allow gcc to compile old C++
2012-03-12 00:26:40 +00:00
a513d54964
-fpermissive to allow gcc to compile old C++
2012-03-12 00:25:41 +00:00
4a6f362ee7
Use socklen_t type for argument for getsockname()
2012-03-12 00:25:04 +00:00
a2706176db
Add int type to previously untyped variable
2012-03-12 00:23:06 +00:00
0ada4a2e39
On linux use a iso C (89) stdarg variable argument function.
...
Gcc no longer supports old style varargs.h
2012-03-12 00:18:13 +00:00
0a9e7d2db9
No easy access to min()/max() macro, rewrite code
2012-03-12 00:14:33 +00:00
fc4f30fa88
-fpermissive to allow GCC to compile old C++
2012-03-12 00:06:34 +00:00
13f6ea01d4
No easy access to min() or max() macros, rewrite code to not use them.
2012-03-12 00:04:39 +00:00
8b79b425f8
No need to create another version of basename(), there's one available
...
on Linux
2012-03-11 23:58:53 +00:00
5aea241fd1
Linux uses unistd.h not osfcn.h
2012-03-11 23:57:12 +00:00
e8fe4970eb
Linux also needs cast to char * of NULL
2012-03-11 23:51:05 +00:00
3d25ba1ea1
No osfcn.h available on linux
2012-03-11 23:48:57 +00:00
a4442878a1
Add in wctype.h for widechars
2012-03-11 23:47:21 +00:00
b672c0782a
Bodgy support around including X11/Xos_r.h
...
Undefine index and rindex first to prevent clashes with tt funcs.
Should be fixed by namespacing local funcs
2012-03-11 23:44:52 +00:00
c3dc5b47a1
-fpermissive to allos GCC to compile old C++
2012-03-11 23:40:39 +00:00
5948300301
On Linux initialise tt_strings as () rather than (NULL)
2012-03-11 23:38:55 +00:00
b195aa51c8
-fpermissive to allow GCC to compile old C++
2012-03-11 23:34:37 +00:00
7d5d17251d
-fpermissive to allow gcc to compile old C++
2012-03-11 23:33:09 +00:00
233ae141c1
-fpermissive to allow gcc to compile old C++
2012-03-11 23:32:08 +00:00
42b737ba2a
On linux it seems that _XTyname() only takes one argument, no buffer required.
2012-03-11 19:12:51 +00:00
b89d6294c6
Add in -fpermissive to handle old pre standard C++
2012-03-11 19:00:31 +00:00
d0dc9dbe86
On linux no generic.h available, and can use the C++ style delete array
2012-03-11 18:16:10 +00:00
67affa6f31
Add linux to list of platforms that are object to those definitions
2012-03-11 18:15:12 +00:00
c5e2bbdd1e
Bodgy fix to not being able to find RADIXCHAR define, use '.' instead.
...
Come back to this later.
2012-03-11 18:08:03 +00:00
b985680de6
Do not re-prototype strdup()
2012-03-11 18:04:30 +00:00
94eb7100d3
Do not re-prototype strdup()
2012-03-11 18:02:24 +00:00
1483f41a69
Due to glibc not have a 'constant' stderr reference, on linux set the error
...
reporting var at runtime.
2012-03-11 17:46:01 +00:00
2d1fd47470
On Linux do not re prototype strdup()
2012-03-11 17:33:41 +00:00
56683a700b
Add in extra args required for open() on Linux
2012-03-11 16:33:18 +00:00
f4a6262757
Also use internal __fds_bits instead of fds_bits
2012-03-11 16:17:39 +00:00
034813b328
On linux do not prototype strdup()
2012-03-11 16:16:00 +00:00
b2b6d0d386
Undefine SVR4 whilst including #include <X11/Xos_r.h> to prevent sys/byteorder.h
...
missing header error.
2012-03-11 16:14:04 +00:00
bcfc468cdc
Use internal __fds_bit variable on Linux, this doesn't seem great.
2012-03-11 16:05:20 +00:00
10b463d278
Add in exctra freetype include directory
2012-03-11 15:56:24 +00:00
546683e176
GCC no longer supports <varargs.h>, change to <stdarg.h>
2012-03-11 14:21:26 +00:00
c884521619
Add GNU LGPL headers to all .c .C and .h files
2012-03-10 18:58:32 +00:00
83b6996daa
Initial import of the CDE 2.1.30 sources from the Open Group.
2012-03-10 18:21:40 +00:00
Peter Howkins