Commit Graph

226 Commits

Author SHA1 Message Date
Lev Kujawski a6ea2a2d52 Centralize catgets() calls through MsgCat
CDE has relied upon catgets() implementations following a relaxed
interpretation of the XPG internationalization standard that ignored
-1, the standard error value returned by catopen, as the catalog
argument. However, this same behavior causes segmentation faults with
the musl C library.

This patch:

- Centralizes (with the exception of ToolTalk) all calls to catopen(),
  catgets(), and catclose() through MsgCat within the DtSvc library.
- Prevents calls to catgets() and catclose() that rely upon
  undefined behavior.
- Eliminates a number of bespoke catgets() wrappers, including multiple
  redundant caching implementations designed to work around a design
  peculiarity in HP/UX.
- Eases building CDE without XPG internationalization support by providing
  the appropriate macros.
2021-06-02 19:55:15 -06:00
Jon Trulson e8345c9241 autotools: specify tirpc lib to link the tooltalk binaries
Newer ubuntu's do not seem to honor the implied library dependency of
libtt->libtirpc, so we must explicitly specify libtirpc when linking
them.
2021-06-01 18:23:46 -06:00
Chase 2642674ed4 dtcm: make /var/spool/calendar for user 2021-03-14 15:09:03 -06:00
Jon Trulson ece5c0ea14 Merge branch 'master' into autotools-conversion
Lost the ksh93 submodule so will re-add in a later commit.
2021-01-30 19:04:10 -07:00
Lev Kujawski 13c173d22c On Linux, use SVR4's (now POSIX) mktime() instead of BSD's non-standard timelocal(). 2021-01-10 18:08:00 -07:00
Peter Howkins d98b2c4c34 dtcm: Always use ANSI function prototypes 2020-11-29 01:55:09 +00:00
Jon Trulson 90e61dda5f Merge branch 'master' into autotools-conversion 2020-11-24 16:53:24 -07:00
Peter Howkins 67f62e5a8a all: remove deprecated sys_errlist[] and replace with ANSI C strerror() 2020-11-02 05:30:08 +00:00
Jon Trulson 264871cefb Fix up a couple issues with multi-core builds and 2 race conditions 2019-11-22 13:42:02 -07:00
Jon Trulson c329d5cfd7 Remove $(TIRPCINC) from all Makefile.am files - it no longer exists
Also, restructure some of the dependencies in the lib/tt binaries.  We
will link with libtt (which will include libtirpc as a dependency),
and XTOOLLIB - all the right X11 stuff without needing to add it to
every OS.  Removed several uneeded OS specializations ("if LINUX",
etc) as a result.
2019-11-20 18:52:29 -07:00
Jon Trulson 444aa700c0 dtcm: make it build 2019-11-20 17:31:53 -07:00
Jon Trulson 730da7747c Change "if SUN" conditionals in remaining Makefile.am files to "if SOLARIS" 2019-10-28 18:54:17 -06:00
Chase ca20cfe55b programs/dtcm: add automake files 2019-10-23 15:34:20 -06:00
wmoxam ab741a1241 'notdef' means it's not used, so we remove it 2019-10-15 20:32:13 -06:00
Jon Trulson fd3cffcb37 dtcalc: increase highlight thickness to match Solaris CDE
This patch was manually added via a diff supplied from a user on the
CDE mailing list: Michele Ghisolfo <ghisolfo.m@gmail.com>
2019-10-14 14:30:58 -06:00
Jose Rubio db7370b62b Cleanup of -Wpointer-compare warnings. 2019-08-19 18:02:25 +02:00
Adam Sampson ae499c794e Explicitly initialise two more static pointers
"dtcm: Coverity 88006" fixed this for buf, but not for string in the
same function (and we may as well initialise string_head for consistency
too).
2019-01-26 00:07:36 +00:00
Adam Sampson 162c88b6ea Don't dereference an uninitialised pointer
This was an incorrect fix in "dtcm: Coverity 88382".
2019-01-26 00:05:54 +00:00
Adam Sampson a97ab71059 Avoid a NULL pointer dereference
"dtcm: Coverity 89051" fixed an instance of this on the previous line,
but not this one.
2019-01-26 00:03:34 +00:00
Chase 4d7f9df692 Use iconv on linux 2019-01-14 10:48:28 -07:00
Jon Trulson f6d83dd5e3 Merge branch 'master' into cde-next 2018-08-01 19:18:17 -06:00
chase 66db2259f7 Remove redundant motif widgets 2018-07-29 16:52:44 -06:00
Peter Howkins e2f1df0c8b dtcm: Coverity 89185 2018-07-13 19:26:38 +01:00
Peter Howkins 10a0f55b4a dtcm: Coverity 89051 2018-07-13 19:25:15 +01:00
Peter Howkins 6d7525e174 dtcm: Coverity 88955 2018-07-13 19:24:11 +01:00
Peter Howkins f4a5433f32 dtcm: Coverity 88884 2018-07-13 19:23:05 +01:00
Peter Howkins 3af957e308 dtcm: Coverity 88382 2018-07-13 19:19:58 +01:00
Peter Howkins a0edcdcc42 dtcm: Coverity 88069 2018-07-13 19:16:00 +01:00
Peter Howkins 67fb14c52b dtcm: Coverity 87942 2018-07-13 19:14:45 +01:00
Peter Howkins 8950afd36a dtcm: Coverity 87565 2018-07-13 19:13:13 +01:00
Peter Howkins c7a649afb9 dtcm: Coverity 88006 2018-07-13 19:11:29 +01:00
Peter Howkins 3a4527980d dtcm: Coverity 89313 2018-07-13 19:06:58 +01:00
Peter Howkins f6886761da dtcm: Coverity 176055 2018-07-13 19:05:33 +01:00
Peter Howkins 9e038c8b2b dtcm: Coverity 89685 2018-07-13 19:04:37 +01:00
Peter Howkins e718778ead dtcm: Coverity 89111 2018-07-13 19:02:57 +01:00
Peter Howkins 28170c2a62 dtcm: Coverity 88533 2018-07-13 19:01:47 +01:00
Peter Howkins 4908fbb49a dtcm: Coverity 88350 2018-07-13 19:00:54 +01:00
Peter Howkins 8f5048d54f dtcm: Coverity 88279 2018-07-13 18:59:43 +01:00
Peter Howkins 6826ecc3d3 dtcm: Coverity 88056 2018-07-13 18:55:47 +01:00
Peter Howkins 4be7b85e01 dtcm: Coverity 87745 and 88154 2018-07-13 18:54:01 +01:00
Peter Howkins dfa296e34e dtcm: Coverity 87364 2018-07-13 18:52:08 +01:00
Peter Howkins 8e11140662 dtcm: Coverity 88250 2018-07-13 18:49:37 +01:00
Peter Howkins cc79da451b dtcm: Coverity 88745 2018-07-13 18:48:31 +01:00
Peter Howkins c2c9c01051 dtcm: Coverity 89232 2018-07-13 18:47:22 +01:00
Peter Howkins ce9bc0603a dtcm: Coverity 89341 2018-07-13 18:44:12 +01:00
Peter Howkins c4940d8f78 dtcm: Coverity 89517 2018-07-13 18:42:56 +01:00
Peter Howkins cad7519b46 dtcm: Coverity 88200 2018-07-13 18:41:13 +01:00
Peter Howkins 261adc44d0 dtcm: Coverity 88494 2018-07-13 18:39:35 +01:00
Peter Howkins 2e0716d5cf dtcm: Coverity 88079 2018-07-13 18:38:06 +01:00
Peter Howkins 1563031cd8 dtcm: Coverity 89160 2018-07-13 18:36:50 +01:00