CDE has relied upon catgets() implementations following a relaxed
interpretation of the XPG internationalization standard that ignored
-1, the standard error value returned by catopen, as the catalog
argument. However, this same behavior causes segmentation faults with
the musl C library.
This patch:
- Centralizes (with the exception of ToolTalk) all calls to catopen(),
catgets(), and catclose() through MsgCat within the DtSvc library.
- Prevents calls to catgets() and catclose() that rely upon
undefined behavior.
- Eliminates a number of bespoke catgets() wrappers, including multiple
redundant caching implementations designed to work around a design
peculiarity in HP/UX.
- Eases building CDE without XPG internationalization support by providing
the appropriate macros.
The function print_progress uses the pointer infile.
If fclose is called before print_progress then the build process
can fail to build the files:
doc/C/cde.dti/CDEDOC/dtsearch/CDEDOC.d99
doc/C/cde.dti/CDEDOC/dtsearch/dtsearch.ocf
doc/C/cde.dti/cde.oli
To fix the issue move the call fclose(infile) after print_progress()
Lev Kujawski