falso
/
dethrace
mirror of https://github.com/dethrace-labs/dethrace.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Divide with RAND_MAX in [FI]RandomBetween 

On Linux, RAND_MAX == 2147483647 (0x7fffffff). So RAND_MAX + 1 = 0x80000000 == -2147483648.
Because of this, [FI]RandomBetween returned negative numbers for positive inputs
This commit is contained in:
Anonymous Maarten 2025-09-17 20:15:28 +02:00 committed by Dethrace Engineering Department
parent eff7bec0b0
commit 5bd38fe359
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/DETHRACE/common/utility.c
View File

@ -184,7 +184,7 @@ int IRandomBetween(int pA, int pB) {
return num;
#else
// If RAND_MAX != 0x7fff, then use floating numbers (alternative is using modulo)
return pA + (int)((pB + 1 - pA) * (rand() / ((float)RAND_MAX + 1)));
return pA + (int)((pB + 1 - pA) * (rand() / (float)RAND_MAX));
#endif
}
@ -205,7 +205,11 @@ int IRandomPosNeg(int pN) {
// IDA: float __cdecl FRandomBetween(float pA, float pB)
// FUNCTION: CARM95 0x004c16bf
float FRandomBetween(float pA, float pB) {
#ifdef DETHRACE_FIX_BUGS
return (float)rand() * (pB - pA) / (float)RAND_MAX + pA;
#else
return (float)rand() * (pB - pA) / (RAND_MAX + 1) + pA;
#endif
}
// IDA: float __cdecl FRandomPosNeg(float pN)