workflow: tag release 9

.github/scripts/build-linux.sh

@@ -21,3 +21,7 @@ cmake --build build -- -j 4
 # run tests
 cd build
 ctest --verbose
+cd ..
+
+# package artifact
+tar -czvf linux-amd64.tar.gz dethrace

.github/workflows/workflow.yml

@@ -6,8 +6,6 @@ on:
 jobs:
 
   build-linux:
-    if: always()
-    needs: create-release
     runs-on: ubuntu-18.04
     strategy:
       matrix:
@@ -18,42 +16,38 @@ jobs:
         with:
           fetch-depth: 0
           ref: ${{ github.event.pull_request.head.sha }}
-    - name: Obtain tag version
-      id: get_version
-      run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
       - name: Build and test
         env:
             CC: ${{ steps.vars.outputs.cc }}
             CXX: ${{ steps.vars.outputs.cxx }}
             MATRIX_PLATFORM: ${{ matrix.platform }}
         run: .github/scripts/build-linux.sh
-    - name: Create artifact
+      - name: Upload artifact
         if: startsWith(github.ref, 'refs/tags/')
-      run: |
-        tar -czvf ${{ github.workspace }}/dethrace-${{ steps.get_version.VERSION }}-linux-amd64.tar.gz ./build/dethrace
-    - name: upload linux artifact
-      if: startsWith(github.ref, 'refs/tags/')
-      uses: actions/upload-release-asset@v1
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
+        uses: actions/upload-artifact@v1
         with:
-        upload_url: ${{ needs.create-release.outputs.upload_url }}
-        asset_path: ${{ github.workspace }}/dethrace-${{ steps.get_version.VERSION }}-linux-amd64.tar.gz
-        asset_name: dethrace-${{ steps.get_version.VERSION }}-linux-amd64.tar.gz
-        asset_content_type: application/octet-stream
+          name: artifacts
+          path: linux-amd64.tar.gz
 
   create-release:
+    needs: [build-linux]
     if: startsWith(github.ref, 'refs/tags/')
     runs-on: ubuntu-latest
-    outputs:
-      upload_url: ${{ steps.create_release.outputs.upload_url }}
     steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+          ref: ${{ github.event.pull_request.head.sha }}
       - name: Obtain tag version
         id: get_version
         run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
-      - name: release
+      - name: download artifacts
+        uses: actions/download-artifact@v1
+        with:
+          name: artifacts
+      - name: Create release
+        id: create-release
         uses: actions/create-release@v1
-        id: create_release
         with:
           draft: false
           prerelease: true
@@ -62,3 +56,12 @@ jobs:
           body: "hello world"
         env:
           GITHUB_TOKEN: ${{ github.token }}
+      - name: Upload linux-amd64 artifact
+        uses: actions/upload-release-asset@v1.0.1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          upload_url: ${{ steps.create-release.outputs.upload_url }}
+          asset_path: ./artifacts/linux-amd64.tar.gz
+          asset_name: dethrace-${{ steps.get_version.VERSION }}-linux-amd64.tar.gz
+          asset_content_type: application/octet-stream

src/DETHRACE/common/graphics.c

@@ -1566,7 +1566,7 @@ void InitShadow() {
     gShadow_model->flags = 6;
     gShadow_actor = BrActorAllocate(BR_ACTOR_MODEL, 0);
     gShadow_actor->model = gShadow_model;
-    return BrActorAdd(gUniverse_actor, gShadow_actor);
+    BrActorAdd(gUniverse_actor, gShadow_actor);
 }
 
 // IDA: br_uint_32 __cdecl SaveShadeTable(br_pixelmap *pTable, void *pArg)

src/harness/stack_trace_handler.h

@@ -277,7 +277,7 @@ void resolve_full_path(char* path, const char* argv0) {
     } else { // run with relative path
         if (NULL == getcwd(path, PATH_MAX)) {
             perror("getcwd error");
-            return NULL;
+            return;
         }
         strcat(path, "/");
         strcat(path, argv0);
@@ -287,7 +287,6 @@ void resolve_full_path(char* path, const char* argv0) {
 void install_signal_handler(char* program_name) {
 
     resolve_full_path(_program_name, program_name);
-    printf("fill path %s\n", _program_name);
 
     /* setup alternate stack */
     {