falso
/
mm
mirror of https://github.com/zeldaret/mm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

document bug in talk wait animation (#1625)

This commit is contained in:
Archez 2024-05-08 16:37:40 -04:00 committed by GitHub
parent 77ea785cc1
commit 0e8b225279
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/overlays/actors/ovl_player_actor/z_player.c
View File

@ -20681,6 +20681,9 @@ s32 func_8085B930(PlayState* play, PlayerAnimationHeader* talkAnim, AnimationMod
return false;
}
//! @bug When func_8082ED20 is used to get a wait animation, NULL is still passed to Animation_GetLastFrame,
// causing it to read the frame count from address 0x80000000 casted to AnimationHeaderCommon via
// Lib_SegmentedToVirtual operating on NULL, which ends up returning 15385 as the last frame
PlayerAnimation_Change(play, &player->skelAnime, (talkAnim == NULL) ? func_8082ED20(player) : talkAnim,
PLAYER_ANIM_ADJUSTED_SPEED, 0.0f, Animation_GetLastFrame(talkAnim), animMode, -6.0f);
return true;