falso
/
mm
mirror of https://github.com/zeldaret/mm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Document OoB in z_message_nes (#1537)

This commit is contained in:
Garrett Cox 2024-02-02 02:03:55 -06:00 committed by GitHub
parent 5684c79312
commit 255c6b850a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/code/z_message_nes.c
View File

@ -1626,6 +1626,7 @@ void Message_DecodeNES(PlayState* play) {
Message_LoadPluralRupeesNES(play, &decodedBufPos, &charTexIndex, &spA4);
} else if (curChar == MESSAGE_BOMBER_CODE) {
for (i = 0; i < 5; i++) {
//! @bug OoB read & write for i == 4, digits array is only 4 elements
digits[i] = gSaveContext.save.saveInfo.bomberCode[i];
Font_LoadCharNES(play, digits[i] + '0', charTexIndex);
charTexIndex += FONT_CHAR_TEX_SIZE;