falso
/
mm
mirror of https://github.com/zeldaret/mm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Document inconsistent empty C-button disabling bug (#1810) 

* Document inconsistent empty C-button disabling bug

* Fixed formatting
This commit is contained in:
tomtee 2025-04-23 22:47:01 +01:00 committed by GitHub
parent dc81d2285c
commit 2ab028b465
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/code/z_parameter.c
View File

@ -2044,6 +2044,10 @@ void Interface_UpdateButtonsPart2(PlayState* play) {
if (GET_PLAYER_FORM == player->transformation) {
for (i = EQUIP_SLOT_C_LEFT; i <= EQUIP_SLOT_C_RIGHT; i++) {
// Individual C button
//! @bug When C-buttons are empty, their item code is 255. However, gPlayerFormItemRestrictions's second
//! dimension has only been allocated 114 elements. This leads to inconsistent behaviour when checking
//! the status of empty C-buttons - for most forms, the C-buttons are enabled when empty, however for
//! Deku Link only, empty C-buttons are disabled.
if (!gPlayerFormItemRestrictions[GET_PLAYER_FORM][GET_CUR_FORM_BTN_ITEM(i)]) {
// Item not usable in current playerForm
if (gSaveContext.buttonStatus[i] != BTN_DISABLED) {