From d209ff50090845aa4f5ccc0e474b974f98655419 Mon Sep 17 00:00:00 2001 From: inspectredc <78732756+inspectredc@users.noreply.github.com> Date: Sat, 20 Jul 2024 18:46:47 +0100 Subject: [PATCH] Cleaner AudioScript_SequenceChannelProcessScript Match (#1662) * Cleaner AudioScript_SequenceChannelProcessScript * cadmic suggestion --- src/audio/lib/seqplayer.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/audio/lib/seqplayer.c b/src/audio/lib/seqplayer.c index 3b0fc33b0d..d6ae5d5d68 100644 --- a/src/audio/lib/seqplayer.c +++ b/src/audio/lib/seqplayer.c @@ -1519,16 +1519,14 @@ void AudioScript_SequenceChannelProcessScript(SequenceChannel* channel) { case 0xE7: // channel: cmdArgU16 = (u16)cmdArgs[0]; data = &seqPlayer->seqData[cmdArgU16]; - channel->muteFlags = data[0]; - data += 3; - channel->noteAllocPolicy = data[-2]; - AudioScript_SetChannelPriorities(channel, data[-1]); - channel->transposition = (s8)data[0]; - data += 4; - channel->newPan = data[-3]; - channel->panChannelWeight = data[-2]; - channel->targetReverbVol = data[-1]; - channel->reverbIndex = data[0]; + channel->muteFlags = *data++; + channel->noteAllocPolicy = *data++; + AudioScript_SetChannelPriorities(channel, *data++); + channel->transposition = (s8)*data++; + channel->newPan = *data++; + channel->panChannelWeight = *data++; + channel->targetReverbVol = *data++; + channel->reverbIndex = *data++; //! @bug: Not marking reverb state as changed channel->changes.s.pan = true; break;