* Add Tharo's documentation comments
* Voice progress
* Match osVoiceControlGain
* Match osVoiceStartReadData
* Cleanup
* Add docs from n64devkit
* WIP on osVoiceGetReadData
* Add comment
* Match voiceinit.c
* Remove CONT_ERR, already present in controller.h
* Really close to matching osVoiceStopReadData
* Progress on voicecheckword
* Match osVoiceSetWord
* Add error codes
* Matched __osVoiceContRead2... Somehow...
* Add small amount of docs
* __osVoiceContRead36 was basically identical from __osVoiceContRead2
* docs, but maybe a little carried away
* Match __osVoiceContWrite4, Write is very similar to Read
* Match __osVoiceContWrite20 from __osVoiceContWrite4, ez
* Some docs
* Improve osVoiceGetReadData
* Match osVoiceCheckWord
* currentSyllable -> currSyllable
* Match osVoiceMaskDictionary
* Match __osVoiceSetADConverter
* Meme matched osVoiceStopReadData
* small cleanup
* Missed macros
* osVoiceGetReadData Meme Match
* Small clean-up
* format
* Properly split voice files from code
* Use proper flags for voice files
* Add basic docs for func_801A5AF0
* Import Voice Data
* Update matching functions in code_801A51F0 from audio WIP
* Update matching functions in code_801A4EB0 from audio WIP
* Match func_801A5A1C
* Match func_801A5228
* Match func_801A54D0
* Doc padmgr functions used
* Match func_801A5680, it's near identical to func_801A54D0
* code_801A51F0 OK
* Match func_801A4EB8
* Match func_801A4FD8 (mips2c got it matching directly)
* code_801A4EB0 & all of voice, OK
* Import bss
* Better match for func_801A5A1C
* format
* Cleanup
* Clean up dictionary
* Introduce OSVoiceDictionary
* More voice docs
* Fix bss
* Import code_801A4EB0 data
* Introduce Word Id enum
* Dictionary: u8 -> u16
* Introduce bgms
* Fill in bgm enums
* Rename bgm to clearer names
* Fix spacing
* Fix "No_Music" define
* remove comment
* import rodata
* Improve bgm names, found another seqId function
* Another seqId function
* Another name change
* Woods of Mystery -> Sarias Song
* Fix match in osVoiceControlGain
* Fix bss reordering
* Fix bss file split
* add saria's song bgm to pierre
* Another bgm function found!
* Add bgm's to `gSaveContext.seqIndex`
* Fix BSS
* fix bss
* Fix bss
* cleanup
* more cleanup
* cow voice weekeventflag
* small cleanup
* some docs
* cleanup var
* global
* more docs
* PR Review
---------
Co-authored-by: Elliptic Ellipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* bring over the objects from the other branch
* kafeis mask
* use symbols
* dman naming after assets
* stateFlags
* remaining stuff
* anim array bug
* Name everything in DmGm after DmAn
* WEEKEVENTREG_COUPLES_MASK_CUTSCENE_FINISHED
* undef
* format
* idk
* ing
* format
* name animations from an4, thanks emil!
* emptydl
* disbelief
* review
* format
* Update assets/xml/objects/object_mask_kerfay.xml
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* review
---------
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Change `EN_SYATEKI_*` enums/defines to `SG_*`
* Name shooting gallery weekeventregs
* Get rid of names on unions (this is what I wanted to begin with!)
* Use ARRAY_COUNT(sGuayFlagsPerWave) instead of 3
* Actually give a proper name for SG_DEKU_GET_PARAM_FF00
* Use anon's suggestion for path param name
* Remove comment that isn't true? What was I cooking back then
* Animation naming stuff + comments
* Tons of score and shooting game logic cleanup
* Fix build issues
* Some more Octorok docs
* Use ANIMMODE enum in EnShn
* Put a bug tag on the weird behavior in EnSyatekiWf
* Start
* Try every function
* Import data
* Docs from message branch
* Fix non-equivalency for func_8016AE1C
* Everything looks NON_MATCHING
* Some more clean up and docs
* Some cleanup
* Small format
* Small improvements here and there
* Match a couple
* Anotha one
* and than there was 1
* and than there were none :)
* Lots of docs
* Finish code docs
* schedule static
* Macros + cleanup
* text ids array cleanup
* Entries cleanup
* Use sBombersNotebookEntries in macros
* Some docs from message branch
* eventIndex -> event
* Remove outdated comments
* PR
* BOMBERS_NOTEBOOK_ENTRY_SIZE
* tables
* Token pasting to simplify
* Some more fixes
* PR pt 1
* Format
* Bring over BombersNotebook docs from z_message branch
Co-authored-by: ZoeyZolotova <zoey.zolotova@gmail.com>
* Full enum glory
* Format
* Name weekeventregs
* typo
* Some comments
* bss
* Review
* bss
* Update src/code/z_play_hireso.c
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Fix
* Namefixer
* bss
* Format
* 0 = 0x0000
---------
Co-authored-by: ZoeyZolotova <zoey.zolotova@gmail.com>
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Match remaining functions in z_en_go:
- Changed some already matching functions for uniformity with the tricky match (early continue from loop). In some cases, this eliminated some strange constructs, in others, it didn't leave much difference.
- Comments/Notes to start understanding/naming process.
* WIP renaming
* More WIP renaming.
* More renaming, Effects (See oot for continuation) and some flags)
* MessageScript documenting.
* Util for dumping message data by textId value.
* Identify some messages.
* Formatting, figuring out event flags.
* More WIP naming
* WIP renaming.
* WIP renaming
* WIP naming and organizing
* WIP more renaming.
* WIP renaming/organizing.
* Near-Final Cleanup before review.
* Rename Taisou and Hakugin animations and associated functions/variables.
* Misc Cleanup.
* Undo changes to variables.txt
* Removed msgtableparser.py (Split to another branch)
* Removal of uncompiled Message Script details.
* Fixup spec file
* First part of hensldm's suggested changes from review. Awaiting discussion.
* Second part of hensldm's suggested changes.
* Fixup missed 'Animation' suffix and functions.txt
* Update .xml files and related source per tom-overton's comments
* Align w/ engineer124's Quake Cleanup #1102
* fixup
* Run format.sh after merge.
* Add brackets around one-line conditional blocks
* Remainder of hensldm's comments from review.
* First pass at Elliptic's comments.
* Rename functions UpdateToX -> ChangeToX
* Header cleanup.
* Run Format, remove accidental commit of .orig file.
* Fixup ActorInit
* Review comments addressed, plus a few unsolicited changes.
- Location of function declarations moved above static data, below types: References in the codebase were mixed, but this just made more sense.
- Function name changes: It didn't fit into subsystems based on Goron Type, so I quit trying to name functions that way. Loss of a bit of "which function applies to which type", but it looks a bit cleaner, sooo...
- Took a stab at making effectTable usage a bit clearer. Just using a EnGoEffect* everywhere and not inherently knowing if it was for one element, or an array really bugged me.
- "GraveBro" names changed. They're all "brothers".
* Changes from engineer124's review.
- "Stretcher" replaced with "Athletic" as a descriptor of goron type.
- Misc formatting and naming changes
* Restructure switch-case statment for early break, and added missing default cases. Removed #define for 0 for actionFlags bitmask.
* Relocate WEEKEVENTREG comments, remove SCENE comments.
* Updated WEEKEVENTREG define names
* Update WEEKEVENTREG names in Goron Shrine Door.
* ELDER -> ELDERS, and revert formatting on z64save.h
* Fixed re-applying changes over wrong defines.
* Adjust Weekeventreg names and comments.
* Update comment as well.
* Document EnAob01 (doggy racetrack owner) and use macros for weekEventRegs in all dog racing files
* Respond to first review
* Respond to anon's review
* Forgot a _FLAG_ on one of my flags
* Respond to anon's review
* Respond to engineer's review
* Delete extra period
* Undo the EVENTINF stuff I goofed up
* Update comment
* Fix bss
* Respond to engineer's review
* time-tag docs
* simplify enums
* PR Reviews
* PR Suggestions
* small change
* small fix
* PR Suggestions
* add extra func ref
* rm raw text from first actor I decompiled
* Stock Pot Inn
* fix master merge
engineer124