mm/tools
TrulyNaN 09cf394d98
ovl_Bg_Kin2_Picture OK and documented, object_kin2_obj documented (#1070)
* test commit

* undoing test commit

* making sure this is the right repo

* removing test file

* init for OSH bombable wall started. put back Actor* in function declarations.

* BgKin2Bombwall_Init is matching.

* started z_bg_kin2_bombwall destroy function. One mismatch right now.

* BgKin2Bombwall_Destroy matches.

* BgKin2Bombwall_Draw matches.

* Fixed BgKin2Bombwall_Init

* BgKin2Bombwall_Init and BgKin2Bombwall_Destroy both match. Fixed s32 array in struct.

* BgKin2Bombwall_Draw and BgKin2Bombwall_Update match.

* Only func_80B6E020 and func_80B6E090 left to match in ovl_Bg_Kin2_Bombwall.

* func_80B6E020 from ovl_Bg_Kin2_Bombwall matches.

* Went from 8925 to about 5-6k diff score for func_80B6E090 in ovl_Bg_Kin2_Bombwall

* Took func_80B6E090 from about 5300 diff score to about 4300 diff score in ovl_Bg_Kin2_Bombwall.

* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 4k ish to 3277

* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 3277 to 2262.

* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 2262 to 1589.

* only slight progress on ovl_Bg_Kinw_Bombwall's func_80B6E090

* Got to 1473 diff score on ovl_Bg_Kinw_Bombwall's func_80B6E090

* Put in the changes made by EllipticEllipsis and hensldm for ovl_Bg_Kin2_Bombwall's func_8066E090.

* renamed some symbols. Fake symbol removal makes nonzero diff, but rom OK's after make.

* moving declarations around, ordering.

* One.word.away. from importing data in ovl_Bg_Kin2_Bombwall.

* ovl_Bg_Kin2_Bombwall data imported. Matching.

* Edited spec for reloc of ovl_Bg_Kin2_Bombwall.

* Removed extra comments for ovl_Bg_Kin2_Bombwall.

* unpushed stuff. dunno.

* forgot to save z_bg_kin2_bombwall.c

* need to commit before make-ing in master.

* Ported z_bg_kin2_bombwall's code. Data next.

* Imported data for merging z_bg_kin2_bombwall. Yes, I yelled when it OK'd.

* Added comments to remember what does what in z_bg_kin2_bombwall.

* Some comments in z_bg_kin2_bombwall.c and function names ideas.

* Added comments for function name ideas. Cleaned up temps in z_bg_kin2_bombwall except in func_80B6E090.

* Renamed most functions and some variables in z_bg_kin2_bombwall.

* Made a name suggestion for func_80B6E020 after testing in game.

* Ran format.sh.

* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c

1 and 0 replaced by true and false in func_80B6E020.

Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>

* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c

Bending to the x-- supremacy.

Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>

* PR fixes (not done yet) including more consistent use of THIS, removing arg0 and arg1 variable names, standardizing params for z_bg_kin2_bombwall, turning some if-return to if-else, removing unnecessary casts.

* Applied isghj5's and EllipticEllipsis' suggestions except for the object file in z_bg_kin2_bombwall. Object file next.

* Screwd up formatting.

* Thinking of playing with object_kin2_obj.

* Documented most of object_kin2_obj based on bombwall, fence and shelf actors.

* Had forgotten an arg1 in z_bg_kin2_bombwall.c

* First commit for ovl_Bg_Ikana_Mirror branch.

* Started decompiling ovl_Bg_Ikana_Mirror. Setup functions and _Update done matching.

* Replaced a float by its fractional representation. I need to learn float magic.

* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c

Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>

* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.h

Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>

* Applied more formatting and naming remarks from PR about the C file. Assets and object stuff next.

* Display lists and collision header in z_bg_kin2_bombwall.c renamed after their descriptive names in the object's XML file. Name for Ocean Spider House drawers chests left to change.

* Working on BgIkanaMirror_Destroy. Stack and registers left essentially.

* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>

* One extra line in an if, collision naming convention applied and renamed Ocean Spider House nightstands to drawers chests.

* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>

* Changed drawers chest to chest of drawers in object_kin2_obj and z_bg_kin2_shelf.

* Removed some unnecessary comment.

* almost done with BgIkanaMirror_Destroy function.

* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c

Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>

* BgIkanaMirror_Destroy OK.

* Almost done with BgIkanaMirror_Init. Mostly stack stuff left.

* Registers and stack left to fix for BgIkanaMirror_Init.

* BgIkanaMirror_Init matching.

* Ran permuter to improve BgIkanaMirror_Draw's score.

* Actually not mad at permuter for BgIkanaMirror_Draw headstart.

* Matched func_80B7F730 in ovl_Bg_Ikana_Mirror. Progress on its _Init done too.

* func_80B7FA9C in ovl_Bg_Ikana_Mirror is matching. _Init left then documentation.

* Mistake in last commit message: actually, _Draw is left for ovl_Bg_Ikana_Mirror.

* Going to do some groceries, so pushing. About 2/3 across func_80B7FBA4 in ovl_Bg_Ikana_Mirror.

* func_80B7FBA4 in ovl_Bg_Ikana_Mirror is matching. _Draw then data left.

* Need to switch branch.

* Fixed BgKin2Bombwall_SpawnEffects after the Rand_Next() type update.

* Switching branch.

* Learning to decomp draw functions with BgIkanaMirror_Draw. YEP

* Switching branch.

* Went through the first wave of graphics macros attempts for BgIkanaMirror_Draw.

* Removed some temps in BgIkanaMirror_Draw.

* Second pass of macro attempts for BgIkanaMirror_Draw.

* Diff score for BgIkanaMirror_Draw at 1873. Getting there.

* BgIkanaMirror_Draw diff score down to 854. 4 instructions off and registers to fix.

* Instructions are matching for BgIkanaMirror_Draw. Registers left.

* BgIkanaMirror_Draw matches. Data next. Adding some co-authors

* BgIkanaMirror_Draw matches. Data next. Adding some co-authors

Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Tom-Overton <hensley.derek58@gmail.com>
Co-authored-by: Isghj5 <isghj5@gmail.com>
Co-authored-by: mzxrules <mzxrules@gmail.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>

* Data imported and OK.

Co-authored-by: Maide <eeeedddccc@hotmail.co.uk>
Co-authored-by: mzxrules <mzxrules@gmail.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>

* Removed commented lines of unused code and useless externs. Documenting C file and object next.

* Renamed fields in actor and variables in 3 functions for ovl_bg_ikana_mirror. Some conventions applied.

* Renamed more variables in the struct and C file for ovl_bg_ikana_mirror.

* More cleanups and naming in ovl_Bg_Ikana_Mirror.

* Renamed some functions in ovl_Bg_Ikana_Mirror. More cleanups. Object documentation next once function names confirmed.

* Renamed collision header, animated textures and display lists for ovl_Bg_Ikana_Mirror in ovl_Bg_Ikana_Mirror and object_ikana_obj. Some textures left to rename.

* Renamed textures only used by ovl_Bg_Ikana_Mirror. Must go back through docs for conventions and styles plus an extra cleanup before PR.

* Went through merging and review docs for extra cleanups. Adding co-authors for documentation.

Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>

* Creating branch to merge ovl_Bg_Ikana_Mirror.

* Fixed the merge from zeldaret/mm. ovl_Bg_Ikana_Mirror OK and documented. PR-ready.

* Started ovl_Bg_Kin2_Picture. _Draw, _Destroy and _Update matching. Started _Init.

* Switching branch.

* Applied first batch of fixes from PR comments. Adding co-authors for documentation and a function rewrite.

Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
Co-authored-by: Kelebek1 <eeeedddccc@hotmail.co.uk>

* Renamed the colliders in ovl_Bg_Ikana_Mirror's struct and fixed naming in object file plus spacing cleanups.

* About 8 extra functions matching for ovl_Bg_Kin2_Picture. _Init and 3 other functions to match.

* Only two functions left to match in ovl_Bg_Kin2_Picture.

* func_80B6F098 in ovl_Bg_Kin2_Picture is matching. Adding co-authors.

Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>

* ovl_Bg_Kin2_Picture OK. Documentation for the overlay and the associated object next.

* Fixed reloc file in spec for ovl_Bg_Kin2_Picture.

* Fixed reloc file in spec for ovl_Bg_Kin2_Picture.

* Started ovl_Bg_Kin2_Picture clean up. Named extra assets in object_kin2_obj. Rewrote func_80B6EFEC. Adding documentation co-authors.

Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Isghj5 <isghj5@gmail.com>

* Removed some temps from functions, renamed some functions and some variables in ovl_Bg_Kin2_Picture.

* More cleanups. Starting to make sense of what is happening in ovl_Bg_Kin2_Picture.

* Renamed the spawn function for Gold Skulltulas and a timer variable in ovl_Bg_Kin2_Picture.

* Renamed fall and shiver functions plus their respective setup functions for ovl_Bg_Kin2_Picture. Renamed some variables in the same actor.

* Renamed all functions in ovl_Bg_Kin2_Picture. Need to confirm name for painting timer used for two distinct reasons.

* Renamed a struct variable and rewrote some comments for ovl_Bg_Kin2_Picture.

* Renamed all struct variables in ovl_Bg_Kin2_Picture except padding.

* Renamed static variable, dust spawn function and a variable in the dust spawn function for ovl_Bg_Kin2_Picture.

* Finished decompiling object_kin2_obj. Adding extra co-authors.

Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>

* Ready to make PR branch.

* Fixed merge conflicts. OK.

* Fixed object_kin2_obj.xml error.

* Applied first batch of fixes from PR review to z_bg_kin2_picture.c and its corresponding header.

* Fixed unused TLUT naming in object_kin2_obj.xml and added a description to the object.

* Removed extra parentheses in z_bg_kin2_picture.c and renamed a macro.

* First batch of fixes suggested by EllipticEllipsis for ovl_Bg_Kin2_Picture.

Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>

* Second batch of fixes suggested by EllipticEllipsis for ovl_Bg_Kin2_Picture.

Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>

* Update src/overlays/actors/ovl_Bg_Kin2_Picture/z_bg_kin2_picture.c

Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>

* Rewrote 0xCCC as 0x10000/20.

* Renamed angle and offset variables in BgKin2Picture_SpawnDust.

Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Isghj5 <isghj5@gmail.com>
Co-authored-by: mzxrules <mzxrules@gmail.com>
Co-authored-by: Maide <eeeedddccc@hotmail.co.uk>
2022-10-10 02:34:17 +01:00
..
ZAPD git subrepo pull --force tools/ZAPD (#785) 2022-04-21 23:56:34 +01:00
ZAPDConfigs/MM Give Deku Princess/King/Butler's objects the "correct" name (#1084) 2022-09-27 00:59:31 +01:00
asm-differ ABI FPR names (#767) 2022-03-31 18:22:19 +01:00
asm-processor ABI FPR names (#767) 2022-03-31 18:22:19 +01:00
buildtools New relocation-generating program (#393) 2022-08-04 04:49:25 +01:00
disasm ovl_Bg_Kin2_Picture OK and documented, object_kin2_obj documented (#1070) 2022-10-10 02:34:17 +01:00
fado New relocation-generating program (#393) 2022-08-04 04:49:25 +01:00
filelists/mm.us.rev1 Give Deku Princess/King/Butler's objects the "correct" name (#1084) 2022-09-27 00:59:31 +01:00
graphovl Subrepos updates (#360) 2021-10-24 13:04:36 -03:00
ido_recomp Update recomp (#543) 2022-01-04 03:20:21 +00:00
overlayhelpers code_801323D0 (z_schedule) (#509) 2022-05-21 12:08:19 -04:00
sizes z_kaleido_map.c OK and Documented (Pause Menu Map Page) + related icon_item statics (dungeon/field/jpn) (#1094) 2022-10-05 06:15:39 +01:00
warnings_count Makefile Changes (#727) 2022-05-25 22:15:28 -04:00
z64compress Update z64compress (#516) 2021-12-19 18:34:50 +00:00
.gitignore Added IDO recomp support (#45) 2021-02-24 00:50:57 -05:00
Makefile New relocation-generating program (#393) 2022-08-04 04:49:25 +01:00
assist.py Overhaul the build system (#234) 2021-08-03 23:21:31 -04:00
calc_bss.sh CRC files OK and documented (#409) 2021-11-11 15:03:05 -03:00
check_format.sh Format Script Update (#904) 2022-10-04 04:06:04 +01:00
entr.py Entrance Macro (#987) 2022-08-15 14:45:28 -04:00
extract_baserom.py Give Deku Princess/King/Butler's objects the "correct" name (#1084) 2022-09-27 00:59:31 +01:00
fixbaserom.py Overhaul the build system (#234) 2021-08-03 23:21:31 -04:00
get_actor_sizes.py Overhaul the build system (#234) 2021-08-03 23:21:31 -04:00
global_bss_check.py Script to check global bss ordering (#339) 2021-10-11 13:11:11 -04:00
m2ctx.py Update (#608) 2022-01-16 18:20:03 +00:00
namefixer.py z_kaleido_map.c OK and Documented (Pause Menu Map Page) + related icon_item statics (dungeon/field/jpn) (#1094) 2022-10-05 06:15:39 +01:00
permuter_settings.toml Update permuter_settings.toml (#1107) 2022-10-05 18:38:42 +01:00
progress.py Fix bug in progress.py (#518) 2021-12-19 11:52:06 -05:00
regconvert.py Overhaul the build system (#234) 2021-08-03 23:21:31 -04:00
reloc_spec_check.sh Script for checking relocs correctly updated on spec (#718) 2022-03-24 21:25:41 -03:00
rename_global_asm.py Script fixes, Type 1 cylinders fixed, rename `main` (#256) 2021-08-08 23:01:51 -04:00
rename_sym.sh SubS Actor Getters OK (#475) 2022-01-04 07:28:25 +00:00
set_o32abi_bit.py Overhaul the build system (#234) 2021-08-03 23:21:31 -04:00
sfxconvert.py `ovl_En_Test4` with 1 non-matching (#319) 2021-09-29 00:08:54 -03:00
sort_actor_funcs.py Sort actor functions and extern'd symbols (#259) 2021-08-15 14:04:28 -04:00
timeconv.py en_invadepoh OK (#200) 2021-07-17 00:04:37 -04:00
vt_fmt.py Overhaul the build system (#234) 2021-08-03 23:21:31 -04:00
vtxdis.c Building on Macs (#513) 2021-12-28 01:07:41 +00:00
z64compress_wrapper.py Update z64compress (#516) 2021-12-19 18:34:50 +00:00