diff --git a/assets/xml/objects/object_ahg.xml b/assets/xml/objects/object_ahg.xml index 2bf39576ad..f1c2c34a37 100644 --- a/assets/xml/objects/object_ahg.xml +++ b/assets/xml/objects/object_ahg.xml @@ -1,7 +1,6 @@ - - @@ -17,28 +16,24 @@ - --> - - - diff --git a/assets/xml/objects/object_bji.xml b/assets/xml/objects/object_bji.xml index 31f9873022..d2a82080fb 100644 --- a/assets/xml/objects/object_bji.xml +++ b/assets/xml/objects/object_bji.xml @@ -1,7 +1,6 @@ - - @@ -17,14 +16,10 @@ - --> - - - diff --git a/assets/xml/objects/object_boj.xml b/assets/xml/objects/object_boj.xml index faf0622f76..b7662c2566 100644 --- a/assets/xml/objects/object_boj.xml +++ b/assets/xml/objects/object_boj.xml @@ -1,7 +1,6 @@ - - @@ -17,20 +16,18 @@ - --> - - diff --git a/assets/xml/objects/object_cne.xml b/assets/xml/objects/object_cne.xml index 99daae4ccb..3860f2c3df 100644 --- a/assets/xml/objects/object_cne.xml +++ b/assets/xml/objects/object_cne.xml @@ -1,7 +1,6 @@ - - @@ -17,14 +16,10 @@ - --> - - - diff --git a/assets/xml/objects/object_oF1s.xml b/assets/xml/objects/object_oF1s.xml index 11359eff53..22d4169a2b 100644 --- a/assets/xml/objects/object_oF1s.xml +++ b/assets/xml/objects/object_oF1s.xml @@ -1,10 +1,6 @@ - - - - - @@ -22,16 +18,11 @@ - --> - - - diff --git a/spec b/spec index 25cedb22f8..0e21e1c440 100644 --- a/spec +++ b/spec @@ -4983,16 +4983,14 @@ endseg beginseg name "object_km1" romalign 0x1000 - include "build/baserom/object_km1.o" - //include "build/assets/objects/object_km1/object_km1.o" + include "build/assets/objects/object_km1/object_km1.o" number 6 endseg beginseg name "object_kw1" romalign 0x1000 - include "build/baserom/object_kw1.o" - //include "build/assets/objects/object_kw1/object_kw1.o" + include "build/assets/objects/object_kw1/object_kw1.o" number 6 endseg diff --git a/src/overlays/actors/ovl_Bg_Ydan_Sp/z_bg_ydan_sp.c b/src/overlays/actors/ovl_Bg_Ydan_Sp/z_bg_ydan_sp.c index 9f7d581c95..063b0b4437 100644 --- a/src/overlays/actors/ovl_Bg_Ydan_Sp/z_bg_ydan_sp.c +++ b/src/overlays/actors/ovl_Bg_Ydan_Sp/z_bg_ydan_sp.c @@ -19,8 +19,6 @@ void BgYdanSp_FloorWebIdle(BgYdanSp* this, GlobalContext* globalCtx); void BgYdanSp_BurnWallWeb(BgYdanSp* this, GlobalContext* globalCtx); void BgYdanSp_WallWebIdle(BgYdanSp* this, GlobalContext* globalCtx); -extern CollisionHeader gDTWebWallCol; - typedef enum { /* 0 */ WEB_FLOOR, /* 1 */ WEB_WALL diff --git a/src/overlays/actors/ovl_Demo_Ec/z_demo_ec.c b/src/overlays/actors/ovl_Demo_Ec/z_demo_ec.c index 96b3f1aedb..5a3a3a2b55 100644 --- a/src/overlays/actors/ovl_Demo_Ec/z_demo_ec.c +++ b/src/overlays/actors/ovl_Demo_Ec/z_demo_ec.c @@ -148,9 +148,6 @@ static s16 sAnimationObjects[] = { OBJECT_EC, OBJECT_EC, OBJECT_EC, OBJECT_EC, OBJECT_EC, OBJECT_EC, OBJECT_GM, OBJECT_MA2, }; -extern FlexSkeletonHeader object_bji_Skel_0000F0; -extern FlexSkeletonHeader object_ahg_Skel_0000F0; - void DemoEc_Destroy(Actor* thisx, GlobalContext* globalCtx) { DemoEc* this = (DemoEc*)thisx; @@ -490,7 +487,11 @@ void DemoEc_UpdateDancingKokiriGirl(DemoEc* this, GlobalContext* globalCtx) { } void DemoEc_DrawKokiriGirl(DemoEc* this, GlobalContext* globalCtx) { - static void* eyeTextures[] = { 0x06000F4C, 0x06001A0C, 0x06001E0C }; + static void* eyeTextures[] = { + gKw1EyeOpenTex, + gKw1EyeHalfTex, + gKw1EyeClosedTex, + }; static u8 color1[] = { 70, 190, 60, 255 }; static u8 color2[] = { 100, 30, 0, 255 }; s32 eyeTexIndex = this->eyeTexIndex; @@ -517,7 +518,11 @@ void DemoEc_UpdateOldMan(DemoEc* this, GlobalContext* globalCtx) { } void DemoEc_DrawOldMan(DemoEc* this, GlobalContext* globalCtx) { - static void* eyeTextures[] = { 0x060005FC, 0x060009FC, 0x06000DFC }; + static void* eyeTextures[] = { + object_bji_Tex_0005FC, + object_bji_Tex_0009FC, + object_bji_Tex_000DFC, + }; static u8 color1[] = { 0, 50, 100, 255 }; static u8 color2[] = { 0, 50, 160, 255 }; s32 eyeTexIndex = this->eyeTexIndex; @@ -545,7 +550,11 @@ void DemoEc_UpdateBeardedMan(DemoEc* this, GlobalContext* globalCtx) { } void DemoEc_DrawBeardedMan(DemoEc* this, GlobalContext* globalCtx) { - static void* eyeTextures[] = { 0x0600057C, 0x0600067C, 0x0600077C }; + static void* eyeTextures[] = { + object_ahg_Tex_00057C, + object_ahg_Tex_00067C, + object_ahg_Tex_00077C, + }; static u8 color1[] = { 255, 255, 255, 255 }; static u8 color2[] = { 255, 255, 255, 255 }; s32 eyeTexIndex = this->eyeTexIndex; @@ -573,7 +582,11 @@ void DemoEc_UpdateWoman(DemoEc* this, GlobalContext* globalCtx) { } void DemoEc_DrawWoman(DemoEc* this, GlobalContext* globalCtx) { - static Gfx* eyeTextures[] = { 0x060007C8, 0x06000FC8, 0x060017C8 }; + static void* eyeTextures[] = { + object_bob_Tex_0007C8, + object_bob_Tex_000FC8, + object_bob_Tex_0017C8, + }; s32 eyeTexIndex = this->eyeTexIndex; void* eyeTexture = eyeTextures[eyeTexIndex]; @@ -739,7 +752,11 @@ void DemoEc_GerudoPostLimbDraw(GlobalContext* globalCtx, s32 limbIndex, Gfx** dL } void DemoEc_DrawGerudo(DemoEc* this, GlobalContext* globalCtx) { - static void* eyeTextures[] = { 0x06000708, 0x06000F08, 0x06001708 }; + static void* eyeTextures[] = { + gGerudoWhiteEyeOpenTex, + gGerudoWhiteEyeHalfTex, + gGerudoWhiteEyeClosedTex, + }; s32 eyeTexIndex = this->eyeTexIndex; void* eyeTexture = eyeTextures[eyeTexIndex]; @@ -916,7 +933,12 @@ void func_8096F640(DemoEc* this, GlobalContext* globalCtx) { } void DemoEc_DrawMido(DemoEc* this, GlobalContext* globalCtx) { - static void* eyeTextures[] = { 0x06004FF0, 0x06005930, 0x06005D30, 0x06006130 }; + static void* eyeTextures[] = { + gMidoEyeOpenTex, + gMidoEyeHalfTex, + gMidoEyeClosedTex, + gMidoEyeAngryTex, + }; s32 eyeTexIndex = this->eyeTexIndex; void* eyeTexture = eyeTextures[eyeTexIndex]; @@ -974,7 +996,11 @@ void DemoEc_UpdateCuccoLady(DemoEc* this, GlobalContext* globalCtx) { } void DemoEc_DrawCuccoLady(DemoEc* this, GlobalContext* globalCtx) { - static void* eyeTextures[] = { 0x060008C8, 0x060010C8, 0x060018C8 }; + static void* eyeTextures[] = { + gCuccoLadyEyeOpenTex, + gCuccoLadyEyeHalfTex, + gCuccoLadyEyeClosedTex, + }; s32 eyeTexIndex = this->eyeTexIndex; void* eyeTexture = eyeTextures[eyeTexIndex]; @@ -1000,7 +1026,11 @@ void DemoEc_UpdatePotionShopOwner(DemoEc* this, GlobalContext* globalCtx) { } void DemoEc_DrawPotionShopOwner(DemoEc* this, GlobalContext* globalCtx) { - static void* eyeTextures[] = { 0x060030D8, 0x060034D8, 0x060038D8 }; + static void* eyeTextures[] = { + gPotionShopkeeperEyeOpenTex, + gPotionShopkeeperEyeHalfTex, + gPotionShopkeeperEyeClosedTex, + }; s32 eyeTexIndex = this->eyeTexIndex; void* eyeTexture = eyeTextures[eyeTexIndex]; diff --git a/src/overlays/actors/ovl_En_Ex_Item/z_en_ex_item.c b/src/overlays/actors/ovl_En_Ex_Item/z_en_ex_item.c index 14a884b2ab..e17327c6e7 100644 --- a/src/overlays/actors/ovl_En_Ex_Item/z_en_ex_item.c +++ b/src/overlays/actors/ovl_En_Ex_Item/z_en_ex_item.c @@ -495,7 +495,7 @@ void EnExItem_DrawMagic(EnExItem* this, GlobalContext* globalCtx, s16 magicIndex } void EnExItem_DrawKey(EnExItem* this, GlobalContext* globalCtx, s32 index) { - static s32 keySegments[] = { 0x0403F140 }; + static void* keySegments[] = { gDropKeySmallTex }; OPEN_DISPS(globalCtx->state.gfxCtx, "../z_en_ex_item.c", 880); diff --git a/src/overlays/actors/ovl_En_Guest/z_en_guest.c b/src/overlays/actors/ovl_En_Guest/z_en_guest.c index 857adbd2ab..9d2115b2a4 100644 --- a/src/overlays/actors/ovl_En_Guest/z_en_guest.c +++ b/src/overlays/actors/ovl_En_Guest/z_en_guest.c @@ -49,8 +49,6 @@ static InitChainEntry sInitChain[] = { ICHAIN_F32(targetArrowOffset, 500, ICHAIN_STOP), }; -extern FlexSkeletonHeader object_boj_Skel_0000F0; - void EnGuest_Init(Actor* thisx, GlobalContext* globalCtx) { EnGuest* this = (EnGuest*)thisx; @@ -215,9 +213,9 @@ s32 EnGuest_OverrideLimbDraw(GlobalContext* globalCtx, s32 limbIndex, Gfx** dLis void EnGuest_Draw(Actor* thisx, GlobalContext* globalCtx) { static void* D_80A50BA4[] = { - 0x060005FC, - 0x060006FC, - 0x060007FC, + object_boj_Tex_0005FC, + object_boj_Tex_0006FC, + object_boj_Tex_0007FC, }; EnGuest* this = (EnGuest*)thisx; s32 pad; diff --git a/src/overlays/actors/ovl_En_Hy/z_en_hy.c b/src/overlays/actors/ovl_En_Hy/z_en_hy.c index 389f538efa..0cfa3a9d75 100644 --- a/src/overlays/actors/ovl_En_Hy/z_en_hy.c +++ b/src/overlays/actors/ovl_En_Hy/z_en_hy.c @@ -68,10 +68,10 @@ static CollisionCheckInfoInit2 sColChkInfoInit = { 0, 0, 0, 0, MASS_IMMOVABLE }; // NULL-terminated arrays of eye textures static void* sEyeTexturesAOB[] = { gDogLadyEyeOpenTex, gDogLadyEyeHalfTex, gDogLadyEyeClosedTex, NULL }; -static void* sEyeTexturesAHG7[] = { 0x0600057C, 0x0600067C, 0x0600077C, NULL }; +static void* sEyeTexturesAHG7[] = { object_ahg_Tex_00057C, object_ahg_Tex_00067C, object_ahg_Tex_00077C, NULL }; static void* sEyeTexturesBBA[] = { object_bba_Tex_0004C8, NULL }; -static void* sEyeTexturesBJI13[] = { 0x060005FC, 0x060009FC, 0x06000DFC, NULL }; -static void* sEyeTexturesBOJ2[] = { 0x060005FC, 0x060006FC, 0x060007FC, NULL }; +static void* sEyeTexturesBJI13[] = { object_bji_Tex_0005FC, object_bji_Tex_0009FC, object_bji_Tex_000DFC, NULL }; +static void* sEyeTexturesBOJ2[] = { object_boj_Tex_0005FC, object_boj_Tex_0006FC, object_boj_Tex_0007FC, NULL }; static void* sEyeTexturesBOB[] = { object_bob_Tex_0007C8, object_bob_Tex_000FC8, object_bob_Tex_0017C8, NULL }; typedef struct { @@ -102,18 +102,18 @@ typedef enum { static EnHyHeadInfo sHeadInfo[] = { /* ENHY_HEAD_AOB */ { OBJECT_AOB, gDogLadyHeadDL, sEyeTexturesAOB }, /* ENHY_HEAD_BOB */ { OBJECT_BOB, object_bob_DL_003B78, sEyeTexturesBOB }, - /* ENHY_HEAD_BOJ_2 */ { OBJECT_BOJ, 0x060026F0, sEyeTexturesBOJ2 }, + /* ENHY_HEAD_BOJ_2 */ { OBJECT_BOJ, object_boj_DL_0026F0, sEyeTexturesBOJ2 }, /* ENHY_HEAD_BOJ_3 */ { OBJECT_BOJ, object_boj_DL_0052E0, NULL }, /* ENHY_HEAD_BOJ_4 */ { OBJECT_BOJ, object_boj_DL_005528, NULL }, /* ENHY_HEAD_BOJ_5 */ { OBJECT_BOJ, object_boj_DL_005738, NULL }, /* ENHY_HEAD_BOJ_6 */ { OBJECT_BOJ, object_boj_DL_0059B0, NULL }, - /* ENHY_HEAD_AHG_7 */ { OBJECT_AHG, 0x060030F0, sEyeTexturesAHG7 }, + /* ENHY_HEAD_AHG_7 */ { OBJECT_AHG, object_ahg_DL_0030F0, sEyeTexturesAHG7 }, /* ENHY_HEAD_AHG_8 */ { OBJECT_AHG, object_ahg_DL_005508, NULL }, /* ENHY_HEAD_AHG_9 */ { OBJECT_AHG, object_ahg_DL_005728, NULL }, /* ENHY_HEAD_BBA */ { OBJECT_BBA, object_bba_DL_002948, sEyeTexturesBBA }, - /* ENHY_HEAD_CNE_11 */ { OBJECT_CNE, 0x06001300, NULL }, + /* ENHY_HEAD_CNE_11 */ { OBJECT_CNE, object_cne_DL_001300, NULL }, /* ENHY_HEAD_CNE_12 */ { OBJECT_CNE, object_cne_DL_002860, NULL }, - /* ENHY_HEAD_BJI_13 */ { OBJECT_BJI, 0x06002560, sEyeTexturesBJI13 }, + /* ENHY_HEAD_BJI_13 */ { OBJECT_BJI, object_bji_DL_002560, sEyeTexturesBJI13 }, /* ENHY_HEAD_BJI_14 */ { OBJECT_BJI, object_bji_DL_003F68, NULL }, /* ENHY_HEAD_COB */ { OBJECT_COB, object_cob_DL_001300, NULL }, }; @@ -137,11 +137,11 @@ typedef enum { static EnHySkeletonInfo sSkeletonInfo[] = { /* ENHY_SKEL_AOB */ { OBJECT_AOB, &gDogLadySkel }, /* ENHY_SKEL_BOB */ { OBJECT_BOB, &object_bob_Skel_0000F0 }, - /* ENHY_SKEL_BOJ */ { OBJECT_BOJ, 0x060000F0 }, - /* ENHY_SKEL_AHG */ { OBJECT_AHG, 0x060000F0 }, + /* ENHY_SKEL_BOJ */ { OBJECT_BOJ, &object_boj_Skel_0000F0 }, + /* ENHY_SKEL_AHG */ { OBJECT_AHG, &object_ahg_Skel_0000F0 }, /* ENHY_SKEL_BBA */ { OBJECT_BBA, &object_bba_Skel_0000F0 }, - /* ENHY_SKEL_CNE */ { OBJECT_CNE, 0x060000F0 }, - /* ENHY_SKEL_BJI */ { OBJECT_BJI, 0x060000F0 }, + /* ENHY_SKEL_CNE */ { OBJECT_CNE, &object_cne_Skel_0000F0 }, + /* ENHY_SKEL_BJI */ { OBJECT_BJI, &object_bji_Skel_0000F0 }, /* ENHY_SKEL_COB */ { OBJECT_COB, &object_cob_Skel_0021F8 }, }; diff --git a/src/overlays/actors/ovl_En_Ko/z_en_ko.c b/src/overlays/actors/ovl_En_Ko/z_en_ko.c index b97362ea03..175e2fb88b 100644 --- a/src/overlays/actors/ovl_En_Ko/z_en_ko.c +++ b/src/overlays/actors/ovl_En_Ko/z_en_ko.c @@ -7,6 +7,8 @@ #include "z_en_ko.h" #include "objects/object_fa/object_fa.h" #include "objects/object_os_anime/object_os_anime.h" +#include "objects/object_km1/object_km1.h" +#include "objects/object_kw1/object_kw1.h" #include "vt.h" #define FLAGS (ACTOR_FLAG_0 | ACTOR_FLAG_3 | ACTOR_FLAG_4) @@ -63,8 +65,7 @@ static ColliderCylinderInit sCylinderInit = { static CollisionCheckInfoInit2 sColChkInfoInit = { 0, 0, 0, 0, MASS_IMMOVABLE }; static void* sFaEyes[] = { gFaEyeOpenTex, gFaEyeHalfTex, gFaEyeClosedTex, NULL }; -static void* sKw1Eyes[] = { /* gKw1EyeOpenTex */ 0x06000F4C, /* gKw1EyeHalfTex */ 0x06001A0C, - /* gKw1EyeClosedTex */ 0x06001E0C, NULL }; +static void* sKw1Eyes[] = { gKw1EyeOpenTex, gKw1EyeHalfTex, gKw1EyeClosedTex, NULL }; typedef struct { /* 0x0 */ s16 objectId; @@ -73,8 +74,8 @@ typedef struct { } EnKoHead; // size = 0xC static EnKoHead sHead[] = { - { OBJECT_KM1, /* gKm1DL */ 0x06001890, NULL }, - { OBJECT_KW1, /* object_kw1_DL_002C10 */ 0x06002C10, sKw1Eyes }, + { OBJECT_KM1, gKm1DL, NULL }, + { OBJECT_KW1, object_kw1_DL_002C10, sKw1Eyes }, { OBJECT_FA, gFaDL, sFaEyes }, }; @@ -84,8 +85,8 @@ typedef struct { } EnKoSkeleton; // size = 0x8 static EnKoSkeleton sSkeleton[2] = { - { OBJECT_KM1, /* gKm1Skel */ 0x060000F0 }, - { OBJECT_KW1, /* gKw1Skel */ 0x060000F0 }, + { OBJECT_KM1, &gKm1Skel }, + { OBJECT_KW1, &gKw1Skel }, }; typedef enum { diff --git a/src/overlays/actors/ovl_En_Sth/z_en_sth.c b/src/overlays/actors/ovl_En_Sth/z_en_sth.c index 6c94388425..7f0242f229 100644 --- a/src/overlays/actors/ovl_En_Sth/z_en_sth.c +++ b/src/overlays/actors/ovl_En_Sth/z_en_sth.c @@ -61,12 +61,12 @@ static s16 sObjectIds[6] = { }; static FlexSkeletonHeader* sSkeletons[6] = { - /* object_ahg_Skel_0000F0 */ 0x060000F0, - /* object_boj_Skel_0000F0 */ 0x060000F0, - /* object_boj_Skel_0000F0 */ 0x060000F0, - /* object_boj_Skel_0000F0 */ 0x060000F0, - /* object_boj_Skel_0000F0 */ 0x060000F0, - /* object_boj_Skel_0000F0 */ 0x060000F0, + &object_ahg_Skel_0000F0, + &object_boj_Skel_0000F0, + &object_boj_Skel_0000F0, + &object_boj_Skel_0000F0, + &object_boj_Skel_0000F0, + &object_boj_Skel_0000F0, }; static AnimationHeader* sAnimations[6] = { diff --git a/undefined_syms.txt b/undefined_syms.txt index 432ecc381b..8f48e9e1bc 100644 --- a/undefined_syms.txt +++ b/undefined_syms.txt @@ -50,14 +50,6 @@ D_A4800004 = 0xA4800004; // SI_PIF_ADDR_RD64B_REG D_A4800010 = 0xA4800010; // SI_PIF_ADDR_WR64B_REG D_A4800018 = 0xA4800018; // SI_STATUS_REG -// until ZAPD can handle non-aligned textures, -// we can't use the built assets tied to some symbols -gKm1Skel = 0x060000F0; -gKw1Skel = 0x060000F0; -object_ahg_Skel_0000F0 = 0x060000F0; -object_bji_Skel_0000F0 = 0x060000F0; -object_boj_Skel_0000F0 = 0x060000F0; - // z_kankyo, z_demo_kankyo, z_en_viewer, z_object_kankyo, z_eff_ss_dead_dd D_01000000 = 0x01000000;