falso
/
oot
mirror of https://github.com/zeldaret/oot.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge 74a415a643 into 4c2a451b9c

This commit is contained in:
mzxrules 2025-07-15 01:53:41 -04:00 committed by GitHub
parent 4c2a451b9c 74a415a643
commit a0af52f4c3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/code/graph.c
View File

@ -141,6 +141,13 @@ void Graph_InitTHGA(GraphicsContext* gfxCtx) {
gfxCtx->overlayBuffer = pool->overlayBuffer; gfxCtx->overlayBuffer = pool->overlayBuffer;
gfxCtx->workBuffer = pool->workBuffer; gfxCtx->workBuffer = pool->workBuffer;
//! @bug fbIdx is a signed integer that can overflow into the negatives. When compiled with a C99+ compiler or IDO,
//! the remainder operator will yield -1 for odd negative values of fbIdx.
//! This results in an out of bounds array access in SysCfb_GetFbPtr due to the negative index value,
//! which will crash the game.
//!
//! In practice, this isn't an issue. In the worst case scenario with the game operating at a consistent 60 FPS,
//! it would take approximately 414.25 days of continuous operation for fbIdx to overflow.
gfxCtx->curFrameBuffer = SysCfb_GetFbPtr(gfxCtx->fbIdx % 2); gfxCtx->curFrameBuffer = SysCfb_GetFbPtr(gfxCtx->fbIdx % 2);
gfxCtx->unk_014 = 0; gfxCtx->unk_014 = 0;
} }