doc bug in `KaleidoScope_DrawWorldMap`

This commit is contained in:
Dragorn421 2025-06-14 23:20:23 +02:00
parent b6580eff2b
commit ab57b3067e
No known key found for this signature in database
GPG Key ID: 381AEBAF3D429335
1 changed files with 6 additions and 0 deletions

View File

@ -592,7 +592,13 @@ void KaleidoScope_DrawWorldMap(PlayState* play, GraphicsContext* gfxCtx) {
PAGE_BG_QUADS + WORLD_MAP_QUAD_POINT_FIRST + pauseCtx->cursorPoint[PAUSE_WORLD_MAP]; PAGE_BG_QUADS + WORLD_MAP_QUAD_POINT_FIRST + pauseCtx->cursorPoint[PAUSE_WORLD_MAP];
KaleidoScope_SetCursorPos(pauseCtx, pauseCtx->cursorSlot[PAUSE_MAP] * 4, pauseCtx->mapPageVtx); KaleidoScope_SetCursorPos(pauseCtx, pauseCtx->cursorSlot[PAUSE_MAP] * 4, pauseCtx->mapPageVtx);
} else { } else {
//! @bug This causes a weird DMA request in `KaleidoScope_UpdateNamePanel`,
//! either for unintended data or outside the intended segment.
// This isn't a visual issue in practice because drawing the texture loaded in
// `KaleidoScope_UpdateNamePanel` is only done under `cursorSpecialPos == 0`.
pauseCtx->cursorItem[PAUSE_MAP] = gSaveContext.worldMapArea + 0x18; pauseCtx->cursorItem[PAUSE_MAP] = gSaveContext.worldMapArea + 0x18;
if (pauseCtx->cursorSpecialPos == PAUSE_CURSOR_PAGE_LEFT) { if (pauseCtx->cursorSpecialPos == PAUSE_CURSOR_PAGE_LEFT) {
if (pauseCtx->stickAdjX > 30) { if (pauseCtx->stickAdjX > 30) {
pauseCtx->cursorSpecialPos = 0; pauseCtx->cursorSpecialPos = 0;