ahci: remove duplicate PORT_IRQ_* constants
These are defined twice, just use one set consistently. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: John Snow <jsnow@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
		
							parent
							
								
									fd648f10af
								
							
						
					
					
						commit
						1f88f77348
					
				| 
						 | 
				
			
			@ -584,7 +584,7 @@ static void ahci_write_fis_sdb(AHCIState *s, int port, uint32_t finished)
 | 
			
		|||
    s->dev[port].finished |= finished;
 | 
			
		||||
    *(uint32_t*)(sdb_fis + 4) = cpu_to_le32(s->dev[port].finished);
 | 
			
		||||
 | 
			
		||||
    ahci_trigger_irq(s, &s->dev[port], PORT_IRQ_STAT_SDBS);
 | 
			
		||||
    ahci_trigger_irq(s, &s->dev[port], PORT_IRQ_SDB_FIS);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
static void ahci_write_fis_d2h(AHCIDevice *ad, uint8_t *cmd_fis)
 | 
			
		||||
| 
						 | 
				
			
			@ -629,7 +629,7 @@ static void ahci_write_fis_d2h(AHCIDevice *ad, uint8_t *cmd_fis)
 | 
			
		|||
    }
 | 
			
		||||
 | 
			
		||||
    if (d2h_fis[2] & ERR_STAT) {
 | 
			
		||||
        ahci_trigger_irq(ad->hba, ad, PORT_IRQ_STAT_TFES);
 | 
			
		||||
        ahci_trigger_irq(ad->hba, ad, PORT_IRQ_TF_ERR);
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    ahci_trigger_irq(ad->hba, ad, PORT_IRQ_D2H_REG_FIS);
 | 
			
		||||
| 
						 | 
				
			
			@ -1039,7 +1039,7 @@ out:
 | 
			
		|||
 | 
			
		||||
    if (!(s->status & DRQ_STAT)) {
 | 
			
		||||
        /* done with DMA */
 | 
			
		||||
        ahci_trigger_irq(ad->hba, ad, PORT_IRQ_STAT_DSS);
 | 
			
		||||
        ahci_trigger_irq(ad->hba, ad, PORT_IRQ_D2H_REG_FIS);
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -132,27 +132,6 @@
 | 
			
		|||
#define PORT_CMD_ICC_PARTIAL      (0x2 << 28) /* Put i/f in partial state */
 | 
			
		||||
#define PORT_CMD_ICC_SLUMBER      (0x6 << 28) /* Put i/f in slumber state */
 | 
			
		||||
 | 
			
		||||
#define PORT_IRQ_STAT_DHRS        (1 << 0) /* Device to Host Register FIS */
 | 
			
		||||
#define PORT_IRQ_STAT_PSS         (1 << 1) /* PIO Setup FIS */
 | 
			
		||||
#define PORT_IRQ_STAT_DSS         (1 << 2) /* DMA Setup FIS */
 | 
			
		||||
#define PORT_IRQ_STAT_SDBS        (1 << 3) /* Set Device Bits */
 | 
			
		||||
#define PORT_IRQ_STAT_UFS         (1 << 4) /* Unknown FIS */
 | 
			
		||||
#define PORT_IRQ_STAT_DPS         (1 << 5) /* Descriptor Processed */
 | 
			
		||||
#define PORT_IRQ_STAT_PCS         (1 << 6) /* Port Connect Change Status */
 | 
			
		||||
#define PORT_IRQ_STAT_DMPS        (1 << 7) /* Device Mechanical Presence
 | 
			
		||||
                                              Status */
 | 
			
		||||
#define PORT_IRQ_STAT_PRCS        (1 << 22) /* File Ready Status */
 | 
			
		||||
#define PORT_IRQ_STAT_IPMS        (1 << 23) /* Incorrect Port Multiplier
 | 
			
		||||
                                               Status */
 | 
			
		||||
#define PORT_IRQ_STAT_OFS         (1 << 24) /* Overflow Status */
 | 
			
		||||
#define PORT_IRQ_STAT_INFS        (1 << 26) /* Interface Non-Fatal Error
 | 
			
		||||
                                               Status */
 | 
			
		||||
#define PORT_IRQ_STAT_IFS         (1 << 27) /* Interface Fatal Error */
 | 
			
		||||
#define PORT_IRQ_STAT_HBDS        (1 << 28) /* Host Bus Data Error Status */
 | 
			
		||||
#define PORT_IRQ_STAT_HBFS        (1 << 29) /* Host Bus Fatal Error Status */
 | 
			
		||||
#define PORT_IRQ_STAT_TFES        (1 << 30) /* Task File Error Status */
 | 
			
		||||
#define PORT_IRQ_STAT_CPDS        (1U << 31) /* Code Port Detect Status */
 | 
			
		||||
 | 
			
		||||
/* ap->flags bits */
 | 
			
		||||
#define AHCI_FLAG_NO_NCQ                  (1 << 24)
 | 
			
		||||
#define AHCI_FLAG_IGN_IRQ_IF_ERR          (1 << 25) /* ignore IRQ_IF_ERR */
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue