mac_nvram: Clean up public API
The state data field is accessed in uint8_t quantities, so switch from uint32_t argument and return value to uint8_t. Fix debug format specifiers while at it. Signed-off-by: Andreas Färber <afaerber@suse.de> Signed-off-by: Alexander Graf <agraf@suse.de>
This commit is contained in:
		
							parent
							
								
									d037834a9d
								
							
						
					
					
						commit
						3743cca7d5
					
				| 
						 | 
				
			
			@ -47,27 +47,26 @@ struct MacIONVRAMState {
 | 
			
		|||
#define DEF_SYSTEM_SIZE 0xc10
 | 
			
		||||
 | 
			
		||||
/* Direct access to NVRAM */
 | 
			
		||||
uint32_t macio_nvram_read (void *opaque, uint32_t addr)
 | 
			
		||||
uint8_t macio_nvram_read(MacIONVRAMState *s, uint32_t addr)
 | 
			
		||||
{
 | 
			
		||||
    MacIONVRAMState *s = opaque;
 | 
			
		||||
    uint32_t ret;
 | 
			
		||||
 | 
			
		||||
    if (addr < s->size)
 | 
			
		||||
    if (addr < s->size) {
 | 
			
		||||
        ret = s->data[addr];
 | 
			
		||||
    else
 | 
			
		||||
    } else {
 | 
			
		||||
        ret = -1;
 | 
			
		||||
    NVR_DPRINTF("read addr %04x val %x\n", addr, ret);
 | 
			
		||||
    }
 | 
			
		||||
    NVR_DPRINTF("read addr %04" PRIx32 " val %" PRIx8 "\n", addr, ret);
 | 
			
		||||
 | 
			
		||||
    return ret;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void macio_nvram_write (void *opaque, uint32_t addr, uint32_t val)
 | 
			
		||||
void macio_nvram_write(MacIONVRAMState *s, uint32_t addr, uint8_t val)
 | 
			
		||||
{
 | 
			
		||||
    MacIONVRAMState *s = opaque;
 | 
			
		||||
 | 
			
		||||
    NVR_DPRINTF("write addr %04x val %x\n", addr, val);
 | 
			
		||||
    if (addr < s->size)
 | 
			
		||||
    NVR_DPRINTF("write addr %04" PRIx32 " val %" PRIx8 "\n", addr, val);
 | 
			
		||||
    if (addr < s->size) {
 | 
			
		||||
        s->data[addr] = val;
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
/* macio style NVRAM device */
 | 
			
		||||
| 
						 | 
				
			
			@ -78,7 +77,7 @@ static void macio_nvram_writeb(void *opaque, hwaddr addr,
 | 
			
		|||
 | 
			
		||||
    addr = (addr >> s->it_shift) & (s->size - 1);
 | 
			
		||||
    s->data[addr] = value;
 | 
			
		||||
    NVR_DPRINTF("writeb addr %04x val %x\n", (int)addr, value);
 | 
			
		||||
    NVR_DPRINTF("writeb addr %04" PHYS_PRIx " val %" PRIx64 "\n", addr, value);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
static uint64_t macio_nvram_readb(void *opaque, hwaddr addr,
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -78,6 +78,6 @@ MacIONVRAMState *macio_nvram_init (hwaddr size,
 | 
			
		|||
void macio_nvram_setup_bar(MacIONVRAMState *s, MemoryRegion *bar,
 | 
			
		||||
                           hwaddr mem_base);
 | 
			
		||||
void pmac_format_nvram_partition (MacIONVRAMState *nvr, int len);
 | 
			
		||||
uint32_t macio_nvram_read (void *opaque, uint32_t addr);
 | 
			
		||||
void macio_nvram_write (void *opaque, uint32_t addr, uint32_t val);
 | 
			
		||||
uint8_t macio_nvram_read(MacIONVRAMState *s, uint32_t addr);
 | 
			
		||||
void macio_nvram_write(MacIONVRAMState *s, uint32_t addr, uint8_t val);
 | 
			
		||||
#endif /* !defined(__PPC_MAC_H__) */
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue