Strip brackets from vnc host
Commit v2.2.0-1530-ge556032 vnc: switch to inet_listen_opts
bypassed the use of inet_parse in inet_listen, making literal
IPv6 addresses enclosed in brackets fail:
qemu-kvm: -vnc [::1]:0: Failed to start VNC server on `(null)': address
resolution failed for [::1]:5900: Name or service not known
Strip the brackets to make it work again.
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 274c3b52e1
)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
parent
b575af0730
commit
4c59860506
9
ui/vnc.c
9
ui/vnc.c
|
@ -3482,7 +3482,14 @@ void vnc_display_open(const char *id, Error **errp)
|
||||||
|
|
||||||
h = strrchr(vnc, ':');
|
h = strrchr(vnc, ':');
|
||||||
if (h) {
|
if (h) {
|
||||||
char *host = g_strndup(vnc, h - vnc);
|
char *host;
|
||||||
|
size_t hlen = h - vnc;
|
||||||
|
|
||||||
|
if (vnc[0] == '[' && vnc[hlen - 1] == ']') {
|
||||||
|
host = g_strndup(vnc + 1, hlen - 2);
|
||||||
|
} else {
|
||||||
|
host = g_strndup(vnc, hlen);
|
||||||
|
}
|
||||||
qemu_opt_set(sopts, "host", host, &error_abort);
|
qemu_opt_set(sopts, "host", host, &error_abort);
|
||||||
qemu_opt_set(wsopts, "host", host, &error_abort);
|
qemu_opt_set(wsopts, "host", host, &error_abort);
|
||||||
qemu_opt_set(sopts, "port", h+1, &error_abort);
|
qemu_opt_set(sopts, "port", h+1, &error_abort);
|
||||||
|
|
Loading…
Reference in New Issue