vfio-pci: Fix missing unparent of dynamically allocated MemoryRegion
Commitd8d9581460
added explicit object_unparent() calls for dynamically allocated MemoryRegions. The VFIOMSIXInfo structure also contains such a MemoryRegion, covering the mmap'd region of a PCI BAR above the MSI-X table. This structure is freed as part of the class exit function and therefore also needs an explicit object_unparent(). Failing to do this results in random segfaults due to fields within the structure, often the class pointer, being reclaimed and corrupted by the time object_finalize_child_property() is called for the object. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Cc: qemu-stable@nongnu.org # 2.2 (cherry picked from commit3a4dbe6aa9
) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
parent
3750d2588e
commit
4d49de6b6f
|
@ -4049,6 +4049,7 @@ static void vfio_put_device(VFIODevice *vdev)
|
|||
DPRINTF("vfio_put_device: close vdev->fd\n");
|
||||
close(vdev->fd);
|
||||
if (vdev->msix) {
|
||||
object_unparent(OBJECT(&vdev->msix->mmap_mem));
|
||||
g_free(vdev->msix);
|
||||
vdev->msix = NULL;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue