falso
/
qemu-irix
mirror of https://github.com/n64decomp/qemu-irix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hostmem: use host_memory_backend_mr_inited() where proper 

Use the new interface to boost readability.

Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <1489151370-15453-3-git-send-email-peterx@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Peter Xu 2017-03-10 21:09:30 +08:00 committed by Eduardo Habkost
parent 4728b57410
commit 6f4c60e47f
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
backends/hostmem-file.c
View File

@ -51,7 +51,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
#ifndef CONFIG_LINUX #ifndef CONFIG_LINUX
error_setg(errp, "-mem-path not supported on this host"); error_setg(errp, "-mem-path not supported on this host");
#else #else
if (!memory_region_size(&backend->mr)) { if (!host_memory_backend_mr_inited(backend)) {
gchar *path; gchar *path;
backend->force_prealloc = mem_prealloc; backend->force_prealloc = mem_prealloc;
path = object_get_canonical_path(OBJECT(backend)); path = object_get_canonical_path(OBJECT(backend));
@ -76,7 +76,7 @@ static void set_mem_path(Object *o, const char *str, Error **errp)
HostMemoryBackend *backend = MEMORY_BACKEND(o); HostMemoryBackend *backend = MEMORY_BACKEND(o);
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o); HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
if (memory_region_size(&backend->mr)) { if (host_memory_backend_mr_inited(backend)) {
error_setg(errp, "cannot change property value"); error_setg(errp, "cannot change property value");
return; return;
} }
@ -96,7 +96,7 @@ static void file_memory_backend_set_share(Object *o, bool value, Error **errp)
HostMemoryBackend *backend = MEMORY_BACKEND(o); HostMemoryBackend *backend = MEMORY_BACKEND(o);
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o); HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
if (memory_region_size(&backend->mr)) { if (host_memory_backend_mr_inited(backend)) {
error_setg(errp, "cannot change property value"); error_setg(errp, "cannot change property value");
return; return;
} }

10
backends/hostmem.c
View File

@ -45,7 +45,7 @@ host_memory_backend_set_size(Object *obj, Visitor *v, const char *name,
Error *local_err = NULL; Error *local_err = NULL;
uint64_t value; uint64_t value;
if (memory_region_size(&backend->mr)) { if (host_memory_backend_mr_inited(backend)) {
error_setg(&local_err, "cannot change property value"); error_setg(&local_err, "cannot change property value");
goto out; goto out;
} }
@ -146,7 +146,7 @@ static void host_memory_backend_set_merge(Object *obj, bool value, Error **errp)
{ {
HostMemoryBackend *backend = MEMORY_BACKEND(obj); HostMemoryBackend *backend = MEMORY_BACKEND(obj);
if (!memory_region_size(&backend->mr)) { if (!host_memory_backend_mr_inited(backend)) {
backend->merge = value; backend->merge = value;
return; return;
} }
@ -172,7 +172,7 @@ static void host_memory_backend_set_dump(Object *obj, bool value, Error **errp)
{ {
HostMemoryBackend *backend = MEMORY_BACKEND(obj); HostMemoryBackend *backend = MEMORY_BACKEND(obj);
if (!memory_region_size(&backend->mr)) { if (!host_memory_backend_mr_inited(backend)) {
backend->dump = value; backend->dump = value;
return; return;
} }
@ -208,7 +208,7 @@ static void host_memory_backend_set_prealloc(Object *obj, bool value,
} }
} }
if (!memory_region_size(&backend->mr)) { if (!host_memory_backend_mr_inited(backend)) {
backend->prealloc = value; backend->prealloc = value;
return; return;
} }
@ -249,7 +249,7 @@ bool host_memory_backend_mr_inited(HostMemoryBackend *backend)
MemoryRegion * MemoryRegion *
host_memory_backend_get_memory(HostMemoryBackend *backend, Error **errp) host_memory_backend_get_memory(HostMemoryBackend *backend, Error **errp)
{ {
return memory_region_size(&backend->mr) ? &backend->mr : NULL; return host_memory_backend_mr_inited(backend) ? &backend->mr : NULL;
} }
void host_memory_backend_set_mapped(HostMemoryBackend *backend, bool mapped) void host_memory_backend_set_mapped(HostMemoryBackend *backend, bool mapped)