virtio-rng: switch exit callback to VirtioDeviceClass

This ensures hot-unplug is handled properly by the proxy, and avoids
leaking bus_name which is freed by virtio_device_exit.

Cc: qemu-stable@nongnu.org
Acked-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2013-09-20 14:06:08 +02:00
parent baa61b9870
commit 7bb6edb0e3
1 changed files with 4 additions and 6 deletions

View File

@ -190,16 +190,14 @@ static int virtio_rng_device_init(VirtIODevice *vdev)
return 0; return 0;
} }
static int virtio_rng_device_exit(DeviceState *qdev) static void virtio_rng_device_exit(VirtIODevice *vdev)
{ {
VirtIORNG *vrng = VIRTIO_RNG(qdev); VirtIORNG *vrng = VIRTIO_RNG(vdev);
VirtIODevice *vdev = VIRTIO_DEVICE(qdev);
timer_del(vrng->rate_limit_timer); timer_del(vrng->rate_limit_timer);
timer_free(vrng->rate_limit_timer); timer_free(vrng->rate_limit_timer);
unregister_savevm(qdev, "virtio-rng", vrng); unregister_savevm(DEVICE(vdev), "virtio-rng", vrng);
virtio_cleanup(vdev); virtio_cleanup(vdev);
return 0;
} }
static Property virtio_rng_properties[] = { static Property virtio_rng_properties[] = {
@ -211,10 +209,10 @@ static void virtio_rng_class_init(ObjectClass *klass, void *data)
{ {
DeviceClass *dc = DEVICE_CLASS(klass); DeviceClass *dc = DEVICE_CLASS(klass);
VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass); VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
dc->exit = virtio_rng_device_exit;
dc->props = virtio_rng_properties; dc->props = virtio_rng_properties;
set_bit(DEVICE_CATEGORY_MISC, dc->categories); set_bit(DEVICE_CATEGORY_MISC, dc->categories);
vdc->init = virtio_rng_device_init; vdc->init = virtio_rng_device_init;
vdc->exit = virtio_rng_device_exit;
vdc->get_features = get_features; vdc->get_features = get_features;
} }