falso
/
qemu-irix
mirror of https://github.com/n64decomp/qemu-irix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

console: Fix warning from clang (and potential crash) 

ccc-analyzer reports this warning:

console.c:1090:29: warning: Dereference of null pointer
        if (active_console->cursor_timer) {
                            ^

Function console_select allows active_console to be NULL,
but would crash when accessing cursor_timer. Fix this.

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Stefan Weil 2012-08-17 15:50:44 +02:00 committed by Anthony Liguori
parent 23aec6005a
commit 8bd6b06d7b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
console.c
View File

@ -1087,7 +1087,7 @@ void console_select(unsigned int index)
if (s) { if (s) {
DisplayState *ds = s->ds; DisplayState *ds = s->ds;
if (active_console->cursor_timer) { if (active_console && active_console->cursor_timer) {
qemu_del_timer(active_console->cursor_timer); qemu_del_timer(active_console->cursor_timer);
} }
active_console = s; active_console = s;