checkpatch: check for CVS keywords on all sources
These should apply to all files, not just C/C++. Tweak the regular expression to check for whole words, to avoid false positives on Perl variables starting with "Id". Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
		
							parent
							
								
									906fb135e4
								
							
						
					
					
						commit
						93eb8e31f3
					
				| 
						 | 
					@ -1354,6 +1354,11 @@ sub process {
 | 
				
			||||||
			WARN("adding a line without newline at end of file\n" . $herecurr);
 | 
								WARN("adding a line without newline at end of file\n" . $herecurr);
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					# check for RCS/CVS revision markers
 | 
				
			||||||
 | 
							if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|\b)/) {
 | 
				
			||||||
 | 
								WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
 | 
				
			||||||
 | 
							}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# tabs are only allowed in assembly source code, and in
 | 
					# tabs are only allowed in assembly source code, and in
 | 
				
			||||||
# some scripts we imported from other projects.
 | 
					# some scripts we imported from other projects.
 | 
				
			||||||
		next if ($realfile =~ /\.(s|S)$/);
 | 
							next if ($realfile =~ /\.(s|S)$/);
 | 
				
			||||||
| 
						 | 
					@ -1368,11 +1373,6 @@ sub process {
 | 
				
			||||||
# check we are in a valid C source file if not then ignore this hunk
 | 
					# check we are in a valid C source file if not then ignore this hunk
 | 
				
			||||||
		next if ($realfile !~ /\.(h|c|cpp)$/);
 | 
							next if ($realfile !~ /\.(h|c|cpp)$/);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# check for RCS/CVS revision markers
 | 
					 | 
				
			||||||
		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
 | 
					 | 
				
			||||||
			WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
 | 
					 | 
				
			||||||
		}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
# Check for potential 'bare' types
 | 
					# Check for potential 'bare' types
 | 
				
			||||||
		my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
 | 
							my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
 | 
				
			||||||
		    $realline_next);
 | 
							    $realline_next);
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in New Issue