hw/9pfs: use O_NOFOLLOW for mapped readlink operation
With mapped security models like mapped-xattr and mapped-file, we save the symlink target as file contents. Now if we ever expose a normal directory with mapped security model and find real symlinks in export path, never follow them and return proper error. Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
This commit is contained in:
		
							parent
							
								
									c7e587b73e
								
							
						
					
					
						commit
						aed858ce10
					
				| 
						 | 
				
			
			@ -284,7 +284,7 @@ static ssize_t local_readlink(FsContext *fs_ctx, V9fsPath *fs_path,
 | 
			
		|||
    if ((fs_ctx->export_flags & V9FS_SM_MAPPED) ||
 | 
			
		||||
        (fs_ctx->export_flags & V9FS_SM_MAPPED_FILE)) {
 | 
			
		||||
        int fd;
 | 
			
		||||
        fd = open(rpath(fs_ctx, path, buffer), O_RDONLY);
 | 
			
		||||
        fd = open(rpath(fs_ctx, path, buffer), O_RDONLY | O_NOFOLLOW);
 | 
			
		||||
        if (fd == -1) {
 | 
			
		||||
            return -1;
 | 
			
		||||
        }
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue