intel_iommu: fixing source id during IOTLB hash key calculation
Using uint8_t for source id will lose bus num and get the wrong/invalid IOTLB entry. Fixing by using uint16_t instead and enlarge level shift. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Eduardo Habkost <ehabkost@redhat.com> Cc: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
		
							parent
							
								
									6bbcb76301
								
							
						
					
					
						commit
						bacabb0afa
					
				| 
						 | 
				
			
			@ -218,7 +218,7 @@ static void vtd_reset_iotlb(IntelIOMMUState *s)
 | 
			
		|||
    g_hash_table_remove_all(s->iotlb);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
static uint64_t vtd_get_iotlb_key(uint64_t gfn, uint8_t source_id,
 | 
			
		||||
static uint64_t vtd_get_iotlb_key(uint64_t gfn, uint16_t source_id,
 | 
			
		||||
                                  uint32_t level)
 | 
			
		||||
{
 | 
			
		||||
    return gfn | ((uint64_t)(source_id) << VTD_IOTLB_SID_SHIFT) |
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -115,7 +115,7 @@
 | 
			
		|||
 | 
			
		||||
/* The shift of source_id in the key of IOTLB hash table */
 | 
			
		||||
#define VTD_IOTLB_SID_SHIFT         36
 | 
			
		||||
#define VTD_IOTLB_LVL_SHIFT         44
 | 
			
		||||
#define VTD_IOTLB_LVL_SHIFT         52
 | 
			
		||||
#define VTD_IOTLB_MAX_SIZE          1024    /* Max size of the hash table */
 | 
			
		||||
 | 
			
		||||
/* IOTLB_REG */
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue