spice: drop incorrect vm_change_state_handler() opaque
The spice_server pointer is a global variable and vm_change_state_handler() therefore does not use its opaque parameter. The vm change state handler is added with a pointer to the spice_server pointer. This is useless and we probably would not want 2 levels of pointers. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Uri Lublin <uril@redhat.com>
This commit is contained in:
		
							parent
							
								
									586b0bef84
								
							
						
					
					
						commit
						bfb82a2875
					
				| 
						 | 
				
			
			@ -709,7 +709,7 @@ void qemu_spice_init(void)
 | 
			
		|||
    qemu_spice_input_init();
 | 
			
		||||
    qemu_spice_audio_init();
 | 
			
		||||
 | 
			
		||||
    qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
 | 
			
		||||
    qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
 | 
			
		||||
 | 
			
		||||
    g_free(x509_key_file);
 | 
			
		||||
    g_free(x509_cert_file);
 | 
			
		||||
| 
						 | 
				
			
			@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
 | 
			
		|||
         */
 | 
			
		||||
        spice_server = spice_server_new();
 | 
			
		||||
        spice_server_init(spice_server, &core_interface);
 | 
			
		||||
        qemu_add_vm_change_state_handler(vm_change_state_handler,
 | 
			
		||||
                                         &spice_server);
 | 
			
		||||
        qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    return spice_server_add_interface(spice_server, sin);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue