falso
/
qemu-irix
mirror of https://github.com/n64decomp/qemu-irix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "qapi: Clean up superfluous null check in qapi_dealloc_type_str()" 

This reverts commit 25a7017555.

Turns out the argument *can* be null: QEMU now segfaults if it
receives an invalid parameter via a qmp command instead of throwing an
error.

For example:
{ "execute": "blockdev-add",
     "arguments": { "options" : { "driver": "invalid-driver" } } }

CC: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
(cherry picked from commit b690d679c1)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Peter Lieven 2014-05-08 18:03:15 +02:00 committed by Michael Roth
parent 274c96e4e1
commit c230ab2ba2
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qapi/qapi-dealloc-visitor.c
View File

@ -131,7 +131,9 @@ static void qapi_dealloc_end_list(Visitor *v, Error **errp)
static void qapi_dealloc_type_str(Visitor *v, char **obj, const char *name, static void qapi_dealloc_type_str(Visitor *v, char **obj, const char *name,
Error **errp) Error **errp)
{ {
g_free(*obj); if (obj) {
g_free(*obj);
}
} }
static void qapi_dealloc_type_int(Visitor *v, int64_t *obj, const char *name, static void qapi_dealloc_type_int(Visitor *v, int64_t *obj, const char *name,