falso
/
qemu-irix
mirror of https://github.com/n64decomp/qemu-irix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

powerpc pci: fixed packing of ranges[] 

By default mingw-gcc is trying to pack structures the way to
preserve binary compatibility with MS Visual C what leads to
incorrect and unexpected padding in the PCI bus ranges property of
the sPAPR PHB.

The patch replaces __attribute__((packed)) with more strict QEMU_PACKED
which actually is __attribute__((gcc_struct, packed)) on Windows.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Tested-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Acked-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
This commit is contained in:
Alexey Kardashevskiy 2012-07-18 18:22:51 +10:00 committed by Stefan Hajnoczi
parent 61dc008f35
commit c4889f5423
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/spapr_pci.c
View File

@ -418,7 +418,7 @@ int spapr_populate_pci_devices(sPAPRPHBState *phb,
uint64_t child; uint64_t child;
uint64_t parent; uint64_t parent;
uint64_t size; uint64_t size;
} __attribute__((packed)) ranges[] = { } QEMU_PACKED ranges[] = {
{ {
cpu_to_be32(b_ss(1)), cpu_to_be64(0), cpu_to_be32(b_ss(1)), cpu_to_be64(0),
cpu_to_be64(phb->io_win_addr), cpu_to_be64(phb->io_win_addr),