target-xtensa: fix big-endian BBS/BBC implementation
Quote from ISA, 2.1:
For most Xtensa instructions, bit numbering is irrelevant; only the BBC
and BBS instructions assign bit numbers to values on which the processor
operates. The BBC/BBS instructions use big-endian bit ordering (0 is the
most-significant bit) on a big-endian processor configuration.
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
(cherry picked from commit 7ff7563fc1
)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
parent
a8cd6f7ddf
commit
c7580c1034
|
@ -2362,10 +2362,18 @@ static void disas_xtensa_insn(DisasContext *dc)
|
|||
case 5: /*BBC*/ /*BBS*/
|
||||
gen_window_check2(dc, RRI8_S, RRI8_T);
|
||||
{
|
||||
TCGv_i32 bit = tcg_const_i32(1);
|
||||
#ifdef TARGET_WORDS_BIGENDIAN
|
||||
TCGv_i32 bit = tcg_const_i32(0x80000000);
|
||||
#else
|
||||
TCGv_i32 bit = tcg_const_i32(0x00000001);
|
||||
#endif
|
||||
TCGv_i32 tmp = tcg_temp_new_i32();
|
||||
tcg_gen_andi_i32(tmp, cpu_R[RRI8_T], 0x1f);
|
||||
#ifdef TARGET_WORDS_BIGENDIAN
|
||||
tcg_gen_shr_i32(bit, bit, tmp);
|
||||
#else
|
||||
tcg_gen_shl_i32(bit, bit, tmp);
|
||||
#endif
|
||||
tcg_gen_and_i32(tmp, cpu_R[RRI8_S], bit);
|
||||
gen_brcondi(dc, eq_ne, tmp, 0, 4 + RRI8_IMM8_SE);
|
||||
tcg_temp_free(tmp);
|
||||
|
@ -2379,7 +2387,11 @@ static void disas_xtensa_insn(DisasContext *dc)
|
|||
{
|
||||
TCGv_i32 tmp = tcg_temp_new_i32();
|
||||
tcg_gen_andi_i32(tmp, cpu_R[RRI8_S],
|
||||
1 << (((RRI8_R & 1) << 4) | RRI8_T));
|
||||
#ifdef TARGET_WORDS_BIGENDIAN
|
||||
0x80000000 >> (((RRI8_R & 1) << 4) | RRI8_T));
|
||||
#else
|
||||
0x00000001 << (((RRI8_R & 1) << 4) | RRI8_T));
|
||||
#endif
|
||||
gen_brcondi(dc, eq_ne, tmp, 0, 4 + RRI8_IMM8_SE);
|
||||
tcg_temp_free(tmp);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue