tests: Don't check qobject_type() before qobject_to_qlist()
qobject_to_qlist(obj) returns NULL when obj isn't a QList. Check that instead of qobject_type(obj) == QTYPE_QLIST. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <1487363905-9480-9-git-send-email-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
		
							parent
							
								
									ca6b6e1e68
								
							
						
					
					
						commit
						cd17ba51f5
					
				| 
						 | 
				
			
			@ -261,7 +261,6 @@ static void test_visitor_out_list(TestOutputVisitorData *data,
 | 
			
		|||
    bool value_bool = true;
 | 
			
		||||
    int value_int = 10;
 | 
			
		||||
    QListEntry *entry;
 | 
			
		||||
    QObject *obj;
 | 
			
		||||
    QList *qlist;
 | 
			
		||||
    int i;
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -279,10 +278,8 @@ static void test_visitor_out_list(TestOutputVisitorData *data,
 | 
			
		|||
 | 
			
		||||
    visit_type_TestStructList(data->ov, NULL, &head, &error_abort);
 | 
			
		||||
 | 
			
		||||
    obj = visitor_get(data);
 | 
			
		||||
    g_assert(qobject_type(obj) == QTYPE_QLIST);
 | 
			
		||||
 | 
			
		||||
    qlist = qobject_to_qlist(obj);
 | 
			
		||||
    qlist = qobject_to_qlist(visitor_get(data));
 | 
			
		||||
    g_assert(qlist);
 | 
			
		||||
    g_assert(!qlist_empty(qlist));
 | 
			
		||||
 | 
			
		||||
    /* ...and ensure that the visitor sees it in order */
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue