trace: add make dependencies on tracetool source
Patches that change tracetool can break the build if old build output files are lying around. This happens because the Makefile does not specify dependencies on tracetool. The build will use old object files that do not match the current source code. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
		
							parent
							
								
									9967e4fec0
								
							
						
					
					
						commit
						cef517ca4b
					
				| 
						 | 
				
			
			@ -1,12 +1,20 @@
 | 
			
		|||
# -*- mode: makefile -*-
 | 
			
		||||
 | 
			
		||||
######################################################################
 | 
			
		||||
# tracetool source files
 | 
			
		||||
# Every rule that invokes tracetool must depend on this so code is regenerated
 | 
			
		||||
# if tracetool itself changes.
 | 
			
		||||
 | 
			
		||||
tracetool-y = $(SRC_PATH)/scripts/tracetool.py
 | 
			
		||||
tracetool-y += $(shell find $(SRC_PATH)/scripts/tracetool -name "*.py")
 | 
			
		||||
 | 
			
		||||
######################################################################
 | 
			
		||||
# Auto-generated event descriptions for LTTng ust code
 | 
			
		||||
 | 
			
		||||
ifeq ($(findstring ust,$(TRACE_BACKENDS)),ust)
 | 
			
		||||
$(obj)/generated-ust-provider.h: $(obj)/generated-ust-provider.h-timestamp
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-ust-provider.h-timestamp: $(SRC_PATH)/trace-events
 | 
			
		||||
$(obj)/generated-ust-provider.h-timestamp: $(SRC_PATH)/trace-events $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=ust-events-h \
 | 
			
		||||
		--backends=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -14,7 +22,7 @@ $(obj)/generated-ust-provider.h-timestamp: $(SRC_PATH)/trace-events
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-ust.c: $(obj)/generated-ust.c-timestamp $(BUILD_DIR)/config-host.mak
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-ust.c-timestamp: $(SRC_PATH)/trace-events
 | 
			
		||||
$(obj)/generated-ust.c-timestamp: $(SRC_PATH)/trace-events $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=ust-events-c \
 | 
			
		||||
		--backends=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -29,7 +37,7 @@ endif
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-events.h: $(obj)/generated-events.h-timestamp
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-events.h-timestamp: $(SRC_PATH)/trace-events
 | 
			
		||||
$(obj)/generated-events.h-timestamp: $(SRC_PATH)/trace-events $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=events-h \
 | 
			
		||||
		--backends=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -37,7 +45,7 @@ $(obj)/generated-events.h-timestamp: $(SRC_PATH)/trace-events
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-events.c: $(obj)/generated-events.c-timestamp $(BUILD_DIR)/config-host.mak
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-events.c-timestamp: $(SRC_PATH)/trace-events
 | 
			
		||||
$(obj)/generated-events.c-timestamp: $(SRC_PATH)/trace-events $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=events-c \
 | 
			
		||||
		--backends=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -54,7 +62,7 @@ util-obj-y += generated-events.o
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-tracers.h: $(obj)/generated-tracers.h-timestamp
 | 
			
		||||
	@cmp -s $< $@ || cp $< $@
 | 
			
		||||
$(obj)/generated-tracers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
 | 
			
		||||
$(obj)/generated-tracers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=h \
 | 
			
		||||
		--backends=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -65,7 +73,7 @@ $(obj)/generated-tracers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/conf
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-tracers.c: $(obj)/generated-tracers.c-timestamp
 | 
			
		||||
	@cmp -s $< $@ || cp $< $@
 | 
			
		||||
$(obj)/generated-tracers.c-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
 | 
			
		||||
$(obj)/generated-tracers.c-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=c \
 | 
			
		||||
		--backends=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -82,7 +90,7 @@ $(obj)/generated-tracers.o: $(obj)/generated-tracers.c $(obj)/generated-tracers.
 | 
			
		|||
ifeq ($(findstring dtrace,$(TRACE_BACKENDS)),dtrace)
 | 
			
		||||
$(obj)/generated-tracers-dtrace.dtrace: $(obj)/generated-tracers-dtrace.dtrace-timestamp
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-tracers-dtrace.dtrace-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
 | 
			
		||||
$(obj)/generated-tracers-dtrace.dtrace-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=d \
 | 
			
		||||
		--backends=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -101,7 +109,7 @@ endif
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-helpers-wrappers.h: $(obj)/generated-helpers-wrappers.h-timestamp
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-helpers-wrappers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
 | 
			
		||||
$(obj)/generated-helpers-wrappers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=tcg-helper-wrapper-h \
 | 
			
		||||
		--backend=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -109,7 +117,7 @@ $(obj)/generated-helpers-wrappers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-helpers.h: $(obj)/generated-helpers.h-timestamp
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-helpers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
 | 
			
		||||
$(obj)/generated-helpers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=tcg-helper-h \
 | 
			
		||||
		--backend=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -117,7 +125,7 @@ $(obj)/generated-helpers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/conf
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-helpers.c: $(obj)/generated-helpers.c-timestamp
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-helpers.c-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
 | 
			
		||||
$(obj)/generated-helpers.c-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=tcg-helper-c \
 | 
			
		||||
		--backend=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			@ -130,7 +138,7 @@ target-obj-y += generated-helpers.o
 | 
			
		|||
 | 
			
		||||
$(obj)/generated-tcg-tracers.h: $(obj)/generated-tcg-tracers.h-timestamp
 | 
			
		||||
	@cmp $< $@ >/dev/null 2>&1 || cp $< $@
 | 
			
		||||
$(obj)/generated-tcg-tracers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
 | 
			
		||||
$(obj)/generated-tcg-tracers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak $(tracetool-y)
 | 
			
		||||
	$(call quiet-command,$(TRACETOOL) \
 | 
			
		||||
		--format=tcg-h \
 | 
			
		||||
		--backend=$(TRACE_BACKENDS) \
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue