migration: fix use-after-free of to_dst_file
hmp_savevm calls qemu_savevm_state(f), which sets to_dst_file=f in global migration state. Then hmp_savevm closes f (g_free called). Next access to to_dst_file in migration state (for example, qmp_migrate_set_speed) will use it after it was freed. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Message-Id: <20170225193155.447462-5-vsementsov@virtuozzo.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
This commit is contained in:
		
							parent
							
								
									5f9412bbac
								
							
						
					
					
						commit
						f9c8caa04f
					
				| 
						 | 
				
			
			@ -1277,6 +1277,11 @@ done:
 | 
			
		|||
        status = MIGRATION_STATUS_COMPLETED;
 | 
			
		||||
    }
 | 
			
		||||
    migrate_set_state(&ms->state, MIGRATION_STATUS_SETUP, status);
 | 
			
		||||
 | 
			
		||||
    /* f is outer parameter, it should not stay in global migration state after
 | 
			
		||||
     * this function finished */
 | 
			
		||||
    ms->to_dst_file = NULL;
 | 
			
		||||
 | 
			
		||||
    return ret;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue