The code wrongly passes the mode to open() only if O_WRONLY is set. Instead, the mode should be passed when O_CREAT is set (or O_TMPFILE on Linux). Fix this by always passing the mode since open() will correctly ignore the mode if it is not needed. Add a testcase which exercises this bug and also change the existing testcase to check that the mode of the created file is correct. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Signed-off-by: Daniel P. Berrange <berrange@redhat.com> |
||
|---|---|---|
| .. | ||
| channel-buffer.h | ||
| channel-command.h | ||
| channel-file.h | ||
| channel-socket.h | ||
| channel-tls.h | ||
| channel-util.h | ||
| channel-watch.h | ||
| channel-websock.h | ||
| channel.h | ||
| dns-resolver.h | ||
| net-listener.h | ||
| task.h | ||