An upcoming patch will alter how simple unions, like InputEvent, are laid out, which will impact all lines of the form 'evt->u.XXX' (expanding it to the longer 'evt->u.XXX.data'). For better legibility in that patch, and less need for line wrapping, it's better to use a temporary variable to reduce the effect of a layout change to just the variable initializations, rather than every reference within an InputEvent. There was one instance in hid.c:hid_pointer_event() where the code was referring to evt->u.rel inside the case label where evt->u.abs is the correct name; thankfully, both members of the union have the same type, so it happened to work, but it is now cleaner. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <1457021813-10704-8-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> |
||
|---|---|---|
| .. | ||
| Makefile.objs | ||
| adb.c | ||
| hid.c | ||
| lm832x.c | ||
| milkymist-softusb.c | ||
| pckbd.c | ||
| pl050.c | ||
| ps2.c | ||
| pxa2xx_keypad.c | ||
| stellaris_input.c | ||
| tsc210x.c | ||
| tsc2005.c | ||
| virtio-input-hid.c | ||
| virtio-input-host.c | ||
| virtio-input.c | ||
| vmmouse.c | ||