Eric Blake a38a283fc7 qmp: Fix reference-counting of qnull on empty output visit ... Commit 6c2f9a15 ensured that we would not return NULL when the caller used an output visitor but had nothing to visit. But in doing so, it added a FIXME about a reference count leak that could abort qemu in the (unlikely) case of SIZE_MAX such visits (more plausible on 32-bit). (Although that commit suggested we might fix it in time for 2.5, we ran out of time; fortunately, it is unlikely enough to bite that it was not worth worrying about during the 2.5 release.) This fixes things by documenting the internal contracts, and explaining why the internal function can return NULL and only the public facing interface needs to worry about qnull(), thus avoiding over-referencing the qnull_ global object. It does not, however, fix the stupidity of the stack mixing up two separate pieces of information; add a FIXME to explain that issue, which will be fixed shortly in a future patch. Signed-off-by: Eric Blake <eblake@redhat.com> Cc: qemu-stable@nongnu.org Message-Id: <1454075341-13658-25-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> (cherry picked from commit a861564015) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>		2016-03-17 16:50:34 -05:00
..
Makefile.objs	…
block-core.json	blockdev: Fix 'change' for slot devices	2016-03-17 16:23:54 -05:00
block.json	qapi: add missing @	2015-10-08 19:46:47 +03:00
common.json	…
crypto.json	…
event.json	…
introspect.json	qapi: Document introspection stability considerations	2015-11-17 08:42:07 +01:00
opts-visitor.c	…
qapi-dealloc-visitor.c	…
qapi-util.c	…
qapi-visit-core.c	…
qmp-dispatch.c	…
qmp-event.c	…
qmp-input-visitor.c	qstring: Make conversion from QObject * accept null	2015-10-29 14:34:45 +01:00
qmp-output-visitor.c	qmp: Fix reference-counting of qnull on empty output visit	2016-03-17 16:50:34 -05:00
qmp-registry.c	…
rocker.json	…
string-input-visitor.c	…
string-output-visitor.c	…
trace.json	…