qemu-irix/hw/virtio
Jason Wang 5e83dae44e vhost_net: start/stop guest notifiers properly
commit a9f98bb5eb "vhost: multiqueue
support" changed the order of stopping the device. Previously
vhost_dev_stop would disable backend and only afterwards, unset guest
notifiers. We now unset guest notifiers while vhost is still
active. This can lose interrupts causing guest networking to fail. In
particular, this has been observed during migration.

To fix this, several other changes are needed:
- remove the hdev->started assertion in vhost.c since we may want to
start the guest notifiers before vhost starts and stop the guest
notifiers after vhost is stopped.
- introduce the vhost_net_set_vq_index() and call it before setting
guest notifiers. This is to guarantee vhost_net has the correct
virtqueue index when setting guest notifiers.

MST: fix up error handling.

Cc: qemu-stable@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Andrey Korolyov <andrey@xdel.ru>
Reported-by: "Zhangjie (HZ)" <zhangjie14@huawei.com>
Tested-by: William Dauchy <william@gandi.net>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit cd7d1d26b0)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
2014-09-10 09:30:57 -05:00
..
dataplane virtio-blk: embed VirtQueueElement in VirtIOBlockReq 2014-07-14 12:03:20 +02:00
Makefile.objs Add vhost-user as a vhost backend. 2014-06-19 16:41:56 +03:00
vhost-backend.c Add vhost-user as a vhost backend. 2014-06-19 16:41:56 +03:00
vhost-user.c vhost-user: minor cleanups 2014-07-18 02:22:24 +03:00
vhost.c vhost_net: start/stop guest notifiers properly 2014-09-10 09:30:57 -05:00
virtio-balloon.c virtio-balloon: use virtio wrappers to access page frame numbers 2014-06-29 19:39:42 +03:00
virtio-bus.c virtio-bus: cleanup plug/unplug interface 2013-12-09 21:46:48 +01:00
virtio-mmio.c hw/virtio: enable common virtio feature for mmio device 2014-07-06 09:13:54 +03:00
virtio-pci.c virtio-pci: fix MSI memory region use after free 2014-07-06 09:13:54 +03:00
virtio-pci.h virtio-blk: use aliases instead of duplicate qdev properties 2014-07-01 09:15:02 +02:00
virtio-rng.c virtio-rng: Add human-readable error message for negative max-bytes parameter 2014-07-22 17:18:55 +05:30
virtio.c virtio: allow byte swapping for vring 2014-06-29 19:39:42 +03:00