Use enums for GivePlayerItem and SoundReq in scripts

This commit is contained in:
Tal Hayon 2022-05-15 08:45:38 +03:00
parent 4543cd8297
commit 33e8152e60
23 changed files with 30 additions and 30 deletions

View File

@ -21,7 +21,7 @@ script_0800F09A:
_0807E8E4_0
MessageFromTargetPos TEXT_MINISH2, 0x02, 0x000c
WaitUntilTextboxCloses
GivePlayerItem 0x0067
GivePlayerItem ITEM_KINSTONE_BAG
WaitPlayerGetItem
_0807E8E4_0
SetSyncFlag 0x00000002

View File

@ -42,7 +42,7 @@ script_0800E3C8:
MessageNoOverlap TEXT_BREAK_VAATI_CURSE, 0x0c
WaitUntilTextboxCloses
Wait 0x000f
GivePlayerItem 0x0053
GivePlayerItem ITEM_SMALL_KEY
WaitPlayerGetItem
SetLocalFlag 0x0071
EnablePlayerControl

View File

@ -32,7 +32,7 @@ script_0800B684:
script_0800B68E:
WaitUntilTextboxCloses
SetLocalFlag 0x009e
GivePlayerItem 0x0066
GivePlayerItem ITEM_LARGE_QUIVER
script_0800B698:
WaitPlayerGetItem
FaceAwayFromPlayer

View File

@ -44,7 +44,7 @@ script_080144C0:
.endif
.endif
script_080144C8:
ModRupees 0xfff6
ModRupees -10
MessageFromTarget TEXT_BURLOV, 0x0c
PlaySound SFX_BUTTON_PRESS
Wait 0x0018

View File

@ -33,7 +33,7 @@ script_08012070:
JumpIfNot script_0801209A
MessageNoOverlap TEXT_GORMAN_ORACLES, 0x25
WaitUntilTextboxCloses
GivePlayerItem 0x0031
GivePlayerItem BOTTLE_CHARM_DIN
WaitPlayerGetItem
.ifdef USA
Call sub_0807FC24

View File

@ -9,7 +9,7 @@ script_0800EF50:
Call sub_080869A4
JumpIfNot script_0800EF50
SetPlayerIdle
CheckLocalFlagByBank 0x0200, 0x006d
CheckLocalFlagByBank FLAG_BANK_2, 0x006d
JumpIf script_0800EF82
MessageFromTarget TEXT_DR_LEFT, 0x01
WaitUntilTextboxCloses

View File

@ -27,7 +27,7 @@ script_0800E872: @ Rent large room
WaitUntilTextboxCloses
HasRupees 0x0190
JumpIfNot script_EmmaNotEnoughRupees
ModRupees 0xfe70
ModRupees -400
SetLocalFlag 0x0091
MessageFromTarget TEXT_HAPPY_HEARTH, 0x08
WaitUntilTextboxCloses

View File

@ -33,7 +33,7 @@ script_08012188:
JumpIfNot script_080121B2
MessageNoOverlap TEXT_GORMAN_ORACLES, 0x1f
WaitUntilTextboxCloses
GivePlayerItem 0x0030
GivePlayerItem BOTTLE_CHARM_FARORE
WaitPlayerGetItem
.ifdef USA
Call sub_0807FC24

View File

@ -17,7 +17,7 @@ script_08012440:
CheckLocalFlag 0x00b3
JumpIf script_08012474
SetLocalFlag 0x00b3
GivePlayerItem 0x0062
GivePlayerItem ITEM_HEART_CONTAINER
WaitPlayerGetItem
.ifdef USA
SetLocalFlag 0x00d0

View File

@ -25,8 +25,8 @@ script_08014F4A:
JumpIfNot script_08014F9A
CheckBottleContaining 0x0020
JumpIfNot script_08014FA2
ModRupees 0xff9c
GivePlayerItem 0x0022
ModRupees -100
GivePlayerItem ITEM_BOTTLE_MILK
WaitPlayerGetItem
MessageNoOverlap TEXT_MILK, 0x11
Jump script_08014FA6

View File

@ -23,7 +23,7 @@ script_08010746:
MessageNoOverlap TEXT_POST, 0x08
Jump script_08010786
script_08010778:
ModRupees 0xff38
ModRupees -200
Call sub_08062E14
MessageNoOverlap TEXT_POST, 0x07
script_08010786:

View File

@ -33,7 +33,7 @@ script_080120FC:
JumpIfNot script_08012126
MessageNoOverlap TEXT_GORMAN_ORACLES, 0x19
WaitUntilTextboxCloses
GivePlayerItem 0x002f
GivePlayerItem BOTTLE_CHARM_NAYRU
WaitPlayerGetItem
.ifdef USA
Call sub_0807FC24

View File

@ -62,7 +62,7 @@ script_08013006:
MessageNoOverlap TEXT_REM, 0x05
WaitUntilTextboxCloses
SetSyncFlag 0x00000200
GivePlayerItem 0x0015
GivePlayerItem ITEM_PEGASUS_BOOTS
WaitPlayerGetItem
FaceAwayFromPlayer
MessageNoOverlap TEXT_REM, 0x06

View File

@ -7,7 +7,7 @@ SCRIPT_START script_RentRegularRoom
WaitUntilTextboxCloses
HasRupees 0x00c8
JumpIfNot script_EmmaNotEnoughRupees
ModRupees 0xff38
ModRupees -200
SetLocalFlag 0x0091
MessageFromTarget TEXT_HAPPY_HEARTH, 0x08
WaitUntilTextboxCloses

View File

@ -7,7 +7,7 @@ SCRIPT_START script_RentSmallRoom
WaitUntilTextboxCloses
HasRupees 0x0032
JumpIfNot script_EmmaNotEnoughRupees
ModRupees 0xffce
ModRupees -50
SetLocalFlag 0x0091
MessageFromTarget TEXT_HAPPY_HEARTH, 0x08
WaitUntilTextboxCloses

View File

@ -40,7 +40,7 @@ script_08011BA4:
MessageNoOverlap TEXT_SIMON, 0x05
Jump script_08011B9A
script_08011BBC:
ModRupees 0xfff6
ModRupees -10
Wait 0x001e
MessageNoOverlap TEXT_SIMON, 0x06
WaitUntilTextboxCloses

View File

@ -22,7 +22,7 @@ script_080143FA:
Wait 0x000a
SetIntVariable 0x00000000
Call sub_08065528
GivePlayerItem 0x0036
GivePlayerItem ITEM_QST_DOGFOOD
WaitPlayerGetItem
MessageNoOverlap TEXT_STOCKWELL, 0x19
WaitUntilTextboxCloses

View File

@ -22,7 +22,7 @@ script_0800E708:
Jump script_0800E6F4
script_0800E722:
WaitUntilTextboxCloses
GivePlayerItem 0x0057
GivePlayerItem ITEM_RUPEE50
WaitPlayerGetItem
WaitUntilTextboxCloses
EnablePlayerControl

View File

@ -25,7 +25,7 @@ script_0800B734:
script_0800B794:
WaitUntilTextboxCloses
SetLocalFlag 0x00a0
GivePlayerItem 0x0065
GivePlayerItem ITEM_BOMBBAG
Jump script_0800B698
script_0800B7A2:
MessageNoOverlap TEXT_ITEM_GET, 0x90

View File

@ -14,7 +14,7 @@ script_0801690A:
Call sub_08064F28
WaitUntilTextboxCloses
JumpIfNot script_08016926
GivePlayerItem 0x003d
GivePlayerItem ITEM_QST_TINGLE_TROPHY
WaitPlayerGetItem
script_08016926:
EnablePlayerControl

View File

@ -63,16 +63,16 @@ SCRIPT_START script_08016482
DoPostScriptAction2 0x0001
PlaySound SFX_METAL_CLINK
PlayBgm BGM_MINISH_WOODS
SoundReq 0x00000074
SoundReq SFX_METAL_CLINK
StopBgm
ModRupees 0xff38
ModRupees -200
ModHealth 0x0010
IncreaseMaxHealth
GiveKinstone 0x0001
GivePlayerItem 0x0001
GetInventoryValue 0x0001
SetInventoryValue 0x0001, 0x0002
InitItemGetSequence 0x0001
GivePlayerItem ITEM_SMITH_SWORD
GetInventoryValue ITEM_SMITH_SWORD
SetInventoryValue ITEM_SMITH_SWORD, 0x0002
InitItemGetSequence ITEM_SMITH_SWORD
CameraTargetEntity
CameraTargetPlayer
_0807F0B4 0x0007

View File

@ -15,7 +15,7 @@ script_08012338:
CheckLocalFlag 0x0042
JumpIf script_0801235A
SetLocalFlag 0x0042
GivePlayerItem 0x0057
GivePlayerItem ITEM_RUPEE50
WaitPlayerGetItem
script_0801235A:
EnablePlayerControl

View File

@ -33,7 +33,7 @@ u32 CheckFlags(u32 flags) {
}
u32 CheckGlobalFlag(u32 flag) {
return CheckLocalFlagByBank(0, flag);
return CheckLocalFlagByBank(FLAG_BANK_0, flag);
}
u32 CheckRoomFlag(u32 flag) {
@ -49,7 +49,7 @@ u32 CheckLocalFlags(u32 flag, u32 length) {
}
u32 CheckGlobalFlags(u32 flag, u32 length) {
return CheckLocalFlagsByBank(0, flag, length);
return CheckLocalFlagsByBank(FLAG_BANK_0, flag, length);
}
u32 CheckRoomFlags(u32 flag, u32 length) {