more cleanup

include/entity.h

@@ -175,6 +175,7 @@ extern LinkedList gUnk_03003DA0;
 #define COORD_TO_TILE_OFFSET(entity, xOff, yOff) \
     TILE((entity)->x.HALF.HI - (xOff), (entity)->y.HALF.HI - (yOff))
 
+Entity* GetEmptyEntity(void);
 extern Entity* CreateEnemy(u32 subtype, u32 form);
 extern Entity* CreateObject(u32 subtype, u32 form, u32 parameter);
 extern Entity* CreateNPC(u32 subtype, u32 form, u32 parameter);
@@ -193,8 +194,11 @@ extern void SetSpriteSubEntryOffsetData2(Entity*, u32, u32);
 
 extern u32 GetFacingDirection(Entity*, Entity*);
 
-extern void DeleteThisEntity(void);
-extern void DeleteEntity(Entity*);
+void DeleteThisEntity(void);
+void DeleteEntity(Entity*);
+
+void AppendEntityToList(Entity* entity, u32 listIndex);
+void PrependEntityToList(Entity* entity, int listIndex);
 
 Entity* FindEntityInListBySubtype(u32 type, u32 subtype, u32 listIndex);
 Entity* FindEntityInListByForm(u32 type, u32 subtype, u32 listIndex, u32 form, u32 parameter);

include/fileScreen.h

@@ -2,12 +2,6 @@
 #define FILESELECT_H
 
 #include "global.h"
-#include "functions.h"
-#include "main.h"
-#include "player.h"
-#include "readKeyInput.h"
-#include "screen.h"
-#include "menu.h"
 #include "save.h"
 
 typedef struct {

include/functions.h

@@ -11,20 +11,16 @@
 #include "room.h"
 
 // Identified - to be sorted into header files
-extern u32 Random(void);
 extern void SoundReq(u32);
 extern void ShowNPCDialogue(Entity*, Dialog*);
-extern u32 UpdateFuseInteraction();
 extern u32 __modsi3(u32, u32);
 extern void DoFade(u32, u32);
 extern u32 CheckKinstoneFused(u32);
 extern void ForceEquipItem(u32, u8);
 extern void LoadRoomEntityList();
-extern void EnemyFunctionHandler(Entity*, void (*const funcs[])(Entity*));
 extern u32 GetAnimationState(Entity*);
 extern void SetChildOffset(Entity*, s32, s32, s32);
 extern Entity* CreatePlayerItem(u32, u32, u32, u32);
-extern Entity* GetEmptyEntity(void);
 extern u32 GetTileTypeByPos(s32 x, s32 y, u32 layer);
 extern u32 GetTileType(u32 pos, u32 layer);
 extern void EraseAllEntities(void);
@@ -43,7 +39,6 @@ extern void LoadResourceAsync(const void*, u32, u32);
 extern void LoadPaletteGroup(u32);
 extern void TryLoadPrologueHyruleTown(void);
 extern Manager* GetEmptyManager(void);
-extern void AppendEntityToList(void*, u32);
 extern void LoadGfxGroup(u32);
 extern void EnqueueSFX(u32);
 extern void ResetPlayer(void);

include/gba/macro.h

@@ -1,9 +1,9 @@
 #ifndef GUARD_GBA_MACRO_H
 #define GUARD_GBA_MACRO_H
 
-#define CPU_FILL(value, dest, size, bit)                                                                     \
-    {                                                                                                        \
-        vu##bit tmp = (vu##bit)(value);                                                                      \
+#define CPU_FILL(value, dest, size, bit)                                                                       \
+    {                                                                                                          \
+        vu##bit tmp = (vu##bit)(value);                                                                        \
         CpuSet((void*)&tmp, dest, CPU_SET_##bit##BIT | CPU_SET_SRC_FIXED | ((size) / ((bit) / 8) & 0x1FFFFF)); \
     }
 
@@ -42,7 +42,7 @@
         vu##bit tmp = (vu##bit)(value);                                                             \
         DmaSet(dmaNum, &tmp, dest,                                                                  \
                (DMA_ENABLE | DMA_START_NOW | DMA_##bit##BIT | DMA_SRC_FIXED | DMA_DEST_INC) << 16 | \
-                   ((size) / ((bit) / 8)));                                                           \
+                   ((size) / ((bit) / 8)));                                                         \
     }
 
 #define DmaFill16(dmaNum, value, dest, size) DMA_FILL(dmaNum, value, dest, size, 16)
@@ -112,7 +112,7 @@
 
 #define DmaFillLarge(dmaNum, value, dest, size, block, bit) \
     {                                                       \
-        void* _dest = (void*)(dest);                          \
+        void* _dest = (void*)(dest);                        \
         u32 _size = size;                                   \
         while (1) {                                         \
             DmaFill##bit(dmaNum, value, _dest, (block));    \
@@ -149,7 +149,7 @@
 
 #define DmaFillDefvars(dmaNum, value, dest, size, bit) \
     {                                                  \
-        void* _dest = (void*)(dest);                     \
+        void* _dest = (void*)(dest);                   \
         u32 _size = size;                              \
         DmaFill##bit(dmaNum, value, _dest, _size);     \
     }
@@ -180,7 +180,7 @@
                            \
         imeTemp = REG_IME; \
         REG_IME = 0;       \
-        REG_IE |= (flags);   \
+        REG_IE |= (flags); \
         REG_IME = imeTemp; \
     }
 

include/global.h

@@ -31,9 +31,9 @@
 
 #define SWAP(a, b, temp) \
     {                    \
-        (temp) = a;        \
-        (a) = b;           \
-        (b) = temp;        \
+        (temp) = a;      \
+        (a) = b;         \
+        (b) = temp;      \
     }
 
 // useful math macros

include/structures.h

@@ -39,7 +39,7 @@ typedef struct {
     u8 field_0x4[0x4];
     bool8 transitioningOut;
     u8 transitionType; // transition when changing areas
-    u16 field_0xa;      // seems to be a tile type
+    u16 field_0xa;     // seems to be a tile type
     u8 areaID;
     u8 roomID;
     u8 playerState;

src/enemy/acroBandits.c

@@ -1,5 +1,6 @@
 #include "global.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern u32 sub_080002D4(s32, s32, u32);

src/enemy/beetle.c

@@ -1,6 +1,8 @@
 #include "entity.h"
-#include "functions.h"
+#include "enemy.h"
 #include "player.h"
+#include "random.h"
+#include "functions.h"
 
 extern u32 PlayerInRange(Entity*, u32, u32);
 

src/enemy/bobomb.c

@@ -1,4 +1,5 @@
 #include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern void CreateDustSmall(Entity*);

src/enemy/bombPeahat.c

@@ -1,7 +1,8 @@
 #include "global.h"
 #include "entity.h"
-#include "functions.h"
 #include "player.h"
+#include "random.h"
+#include "functions.h"
 
 extern void sub_08078954(Entity*);
 extern void sub_08078930(Entity*);

src/enemy/businessScrub.c

@@ -1,9 +1,11 @@
 #include "enemy.h"
 #include "entity.h"
 #include "flags.h"
-#include "functions.h"
 #include "textbox.h"
 #include "save.h"
+#include "random.h"
+#include "npc.h"
+#include "functions.h"
 
 extern void sub_0801D040(Entity*, u32);
 extern Entity* sub_08049DF4(u32);
@@ -326,7 +328,7 @@ void sub_08028E40(Entity* this) {
 }
 
 void sub_08028E84(Entity* this) {
-    if (UpdateFuseInteraction()) {
+    if (UpdateFuseInteraction(this)) {
         this->action = 4;
         this->actionDelay = 1;
     }

src/enemy/chuchu.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern s32 sub_080012DC(Entity*);

src/enemy/cuccoChickAggr.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern Entity* sub_08049DF4(u32);

src/enemy/darkNut.c

@@ -1,4 +1,6 @@
 #include "entity.h"
+#include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 typedef struct {

src/enemy/fallingBoulder.c

@@ -1,4 +1,5 @@
 #include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 void sub_0802C4B0(Entity*);

src/enemy/fireballGuy.c

@@ -1,5 +1,7 @@
 #include "global.h"
 #include "entity.h"
+#include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 typedef struct {

src/enemy/gibdo.c

@@ -1,8 +1,9 @@
 #include "global.h"
 #include "entity.h"
 #include "sprite.h"
-#include "functions.h"
 #include "enemy.h"
+#include "random.h"
+#include "functions.h"
 // Gibudo
 void sub_08037794();
 void sub_08037B10();

src/enemy/gyorgMale.c

@@ -4,8 +4,9 @@
 #include "room.h"
 #include "trig.h"
 #include "structures.h"
-#include "functions.h"
 #include "fileScreen.h"
+#include "random.h"
+#include "functions.h"
 
 void (*const gUnk_080D1AFC[8])(Entity*);
 void (*const gUnk_080D1B1C[7])(Entity*);

src/enemy/hangingSeed.c

@@ -1,4 +1,5 @@
 #include "entity.h"
+#include "enemy.h"
 #include "functions.h"
 
 extern void (*const gHangingSeedFunctions[])(Entity*);

src/enemy/helmasaur.c

@@ -1,4 +1,5 @@
 #include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern void sub_08008796(Entity*, u32, u32, u32);

src/enemy/keaton.c

@@ -1,5 +1,7 @@
 #include "global.h"
 #include "entity.h"
+#include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern Entity* gUnk_020000B0;

src/enemy/keese.c

@@ -2,6 +2,7 @@
 #include "entity.h"
 #include "enemy.h"
 #include "player.h"
+#include "random.h"
 #include "functions.h"
 
 extern void sub_08001328(Entity*);

src/enemy/lakitu.c

@@ -1,5 +1,6 @@
 #include "global.h"
 #include "entity.h"
+#include "enemy.h"
 #include "functions.h"
 #include "trig.h"
 #include "random.h"
@@ -33,7 +34,6 @@ typedef struct {
     s8 y;
 } PACKED OffsetCoords;
 
-
 // Variables
 extern void (*const gUnk_080D0110[])(Entity*);
 extern void (*const gUnk_080D0128[])(Entity*);

src/enemy/leever.c

@@ -1,6 +1,7 @@
 #include "global.h"
 #include "entity.h"
 #include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern u32 sub_080002D4(s32, s32, u32);

src/enemy/likeLike.c

@@ -1,8 +1,9 @@
 #include "enemy.h"
 #include "entity.h"
-#include "functions.h"
 #include "textbox.h"
 #include "save.h"
+#include "random.h"
+#include "functions.h"
 
 extern bool32 sub_080544B4(u32);
 

src/enemy/madderpillar.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern u8 gEntCount;

src/enemy/miniFireballGuy.c

@@ -1,5 +1,7 @@
 #include "global.h"
 #include "entity.h"
+#include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern void sub_08045678(Entity*);

src/enemy/miniSlime.c

@@ -1,6 +1,8 @@
 #include "global.h"
 #include "entity.h"
+#include "enemy.h"
 #include "room.h"
+#include "random.h"
 #include "functions.h"
 
 void sub_08045374(Entity*);

src/enemy/moldorm.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 void sub_08022EAC(Entity*);

src/enemy/moldworm.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern void sub_0800449C(Entity*, u32);

src/enemy/octorok.c

@@ -1,5 +1,7 @@
 #include "global.h"
 #include "entity.h"
+#include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern Entity* sub_08049DF4(u32);

src/enemy/peahat.c

@@ -1,4 +1,6 @@
 #include "entity.h"
+#include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern void (*const gPeahatFunctions[])(Entity*);

src/enemy/pesto.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern u32 sub_080002E0(u16, u32);

src/enemy/puffstool.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern u32 sub_080002E0(u32, u32);

src/enemy/rockChuchu.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern void sub_0804A4E4(Entity*, Entity*);

src/enemy/rollobite.c

@@ -1,4 +1,6 @@
 #include "entity.h"
+#include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern void (*const gRollobiteFunctions[])(Entity*);

src/enemy/rope.c

@@ -1,8 +1,9 @@
 #include "global.h"
 #include "entity.h"
 #include "sprite.h"
-#include "functions.h"
 #include "enemy.h"
+#include "random.h"
+#include "functions.h"
 
 extern void (*const gRope[6])(Entity*);
 extern void (*const gUnk_080CE460[4])(Entity*);

src/enemy/slime.c

@@ -1,6 +1,8 @@
 #include "global.h"
 #include "entity.h"
+#include "enemy.h"
 #include "room.h"
+#include "random.h"
 #include "functions.h"
 
 typedef struct {

src/enemy/sluggula.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern s32 sub_080012DC(Entity*);

src/enemy/smallPesto.c

@@ -1,6 +1,7 @@
 #include "global.h"
 #include "entity.h"
 #include "position.h"
+#include "random.h"
 #include "functions.h"
 
 extern u32 GetNextFunction(Entity*);

src/enemy/spearMoblin.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern bool32 sub_0806FC80(Entity*, Entity*, u32);

src/enemy/spikedBeetle.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern u32 sub_0804A024(Entity*, u32, u32);

src/enemy/spinyChuchu.c

@@ -1,5 +1,6 @@
 #include "enemy.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern void sub_08001318(Entity*);

src/enemy/tektite.c

@@ -1,6 +1,7 @@
 #include "global.h"
 #include "entity.h"
 #include "enemy.h"
+#include "random.h"
 #include "functions.h"
 
 extern void (*const gUnk_080CDED0[])(Entity*);

src/enemy/tektiteGolden.c

@@ -1,8 +1,9 @@
 #include "global.h"
 #include "entity.h"
 #include "enemy.h"
-#include "functions.h"
 #include "flags.h"
+#include "random.h"
+#include "functions.h"
 
 extern void sub_08038168(Entity*);
 

src/enemy/wallMaster.c

@@ -1,7 +1,8 @@
 #include "enemy.h"
 #include "entity.h"
-#include "functions.h"
 #include "area.h"
+#include "random.h"
+#include "functions.h"
 
 extern void sub_08001328(Entity*);
 extern Entity* sub_08049DF4(u32);

src/enemy/wallMaster2.c

@@ -1,6 +1,7 @@
 #include "enemy.h"
-#include "functions.h"
 #include "area.h"
+#include "random.h"
+#include "functions.h"
 
 extern void sub_08001328(Entity*);
 extern void DoExitTransition(u32*);

src/enemy/waterDrop.c

@@ -1,7 +1,8 @@
 #include "enemy.h"
 #include "entity.h"
-#include "functions.h"
 #include "screen.h"
+#include "random.h"
+#include "functions.h"
 
 void sub_0802A39C(Entity*);
 void sub_0802A334(Entity*);

src/enemy/wisp.c

@@ -3,8 +3,9 @@
 #include "enemy.h"
 #include "structures.h"
 #include "player.h"
-#include "functions.h"
 #include "save.h"
+#include "random.h"
+#include "functions.h"
 
 extern void (*const gUnk_080CEB74[])(Entity*);
 extern void (*const gUnk_080CEB8C[])(Entity*);

src/entity.c

@@ -1,5 +1,6 @@
 #include "global.h"
 #include "entity.h"
+#include "dma.h"
 
 typedef struct OtherEntity {
     struct OtherEntity* prev;
@@ -22,8 +23,7 @@ Entity* sub_0805E744(void) {
     return NULL;
 }
 
-extern Entity* GetEmptyEntity();
-OtherEntity* GetEmptyManager();
+OtherEntity* GetEmptyManager(void);
 
 typedef void* (*Getter)(void);
 
@@ -47,7 +47,7 @@ typedef struct {
 extern struct_03003DD0 gUnk_03003DD0;
 extern u32 _call_via_r0(u32*);
 extern u32 _EntUpdate;
-extern void DeleteEntityAny(Entity*);
+void DeleteEntityAny(Entity*);
 
 void DeleteThisEntity(void) {
     DeleteEntityAny(gUnk_03003DD0.field_0x8);
@@ -80,7 +80,7 @@ extern void UnloadCutsceneData();
 extern void UnloadHitbox();
 extern void sub_0801DA0C();
 extern void sub_0804AA1C();
-extern void UnlinkEntity(); // Unlink
+void UnlinkEntity();
 
 void DeleteEntity(Entity* ent) {
     if (ent->next) {
@@ -159,7 +159,6 @@ OtherEntity* GetEmptyManager(void) {
     return NULL;
 }
 
-extern void MemClear(void*, u32);
 extern u8 gManagerCount;
 
 void DeleteManager(OtherEntity* ent) {
@@ -183,8 +182,7 @@ void sub_0805E92C(u32 param_1) {
 }
 
 extern Entity gUnk_020369F0;
-extern void MemCopy(const void* src, void* dest, size_t size); // dma copy
-extern void sub_0805E98C(void);
+void sub_0805E98C(void);
 
 void sub_0805E958(void) {
     MemCopy(&gEntityLists, &gUnk_020369F0, 0x48);
@@ -236,32 +234,32 @@ void sub_0805E9F4(void) {
 
 extern void sub_0805E374(Entity*);
 
-void AppendEntityToList(Entity* ent, int listIndex) {
+void AppendEntityToList(Entity* entity, u32 listIndex) {
     LinkedList* list;
 
     list = &gEntityLists[listIndex];
-    ent->next = (Entity*)list;
-    ent->prev = list->last;
-    list->last->next = ent;
-    list->last = ent;
-    if (ent->kind != 9) {
-        ent->spritePriority.b0 = 4;
+    entity->next = (Entity*)list;
+    entity->prev = list->last;
+    list->last->next = entity;
+    list->last = entity;
+    if (entity->kind != 9) {
+        entity->spritePriority.b0 = 4;
         gEntCount++;
     } else {
         gManagerCount++;
     }
-    sub_0805E374(ent);
+    sub_0805E374(entity);
 }
 
-void PrependEntityToList(Entity* ent, int listIndex) {
+void PrependEntityToList(Entity* entity, int listIndex) {
     LinkedList* list;
 
-    UnlinkEntity(ent);
+    UnlinkEntity(entity);
     list = &gEntityLists[listIndex];
-    ent->prev = (Entity*)list;
-    ent->next = list->first;
-    list->first->prev = ent;
-    list->first = ent;
+    entity->prev = (Entity*)list;
+    entity->next = list->first;
+    list->first->prev = entity;
+    list->first = entity;
 }
 
 void UnlinkEntity(Entity* ent) {

src/fileScreen.c

@@ -1,5 +1,11 @@
 #include "fileScreen.h"
+#include "main.h"
+#include "player.h"
+#include "readKeyInput.h"
+#include "screen.h"
+#include "menu.h"
 #include "dma.h"
+#include "random.h"
 
 // copy, erase, start
 #define NUM_FILE_OPERATIONS 3

src/game.c

@@ -2,7 +2,6 @@
 #include "screen.h"
 #include "structures.h"
 #include "dma.h"
-#include "functions.h"
 #include "screen.h"
 #include "entity.h"
 #include "player.h"
@@ -10,7 +9,9 @@
 #include "main.h"
 #include "flags.h"
 #include "save.h"
+#include "readKeyInput.h"
 #include "fileScreen.h"
+#include "functions.h"
 
 extern u8 gArea;
 extern u32 gUnk_03000B80;

src/manager/manager1A.c

@@ -223,5 +223,5 @@ void sub_0805B390(u32 unk1) {
     tmp->type = 0x9;
     tmp->subtype = 0x1A;
     tmp->unk_0a = unk1;
-    AppendEntityToList(tmp, 6);
+    AppendEntityToList((Entity*)tmp, 6);
 }

src/manager/manager28.c

@@ -46,7 +46,7 @@ void Manager28_Init(Manager28* this) {
                 /*     tmp3->enemies[tmp4] = this->enemies[tmp4]; */
                 /* } */
                 tmp3->d = this->d;
-                AppendEntityToList(tmp3, 6);
+                AppendEntityToList((Entity*)tmp3, 6);
             }
         }
         DeleteManager(&this->manager);

src/manager/manager3.c

@@ -4,6 +4,7 @@
 #include "area.h"
 #include "room.h"
 #include "player.h"
+#include "random.h"
 #include "functions.h"
 
 typedef struct {

src/manager/managerB.c

@@ -130,7 +130,7 @@ ManagerBHelper* CreateHelper(Manager* this) {
         extra->manager.parent = this;
         this->unk_0e++;
         MemClear(&extra->enemies, 0x20);
-        AppendEntityToList(extra, 8);
+        AppendEntityToList((Entity*)extra, 8);
     }
     return extra;
 }

src/npc/bigGoron.c

@@ -2,8 +2,9 @@
 #include "entity.h"
 #include "player.h"
 #include "structures.h"
-#include "functions.h"
 #include "script.h"
+#include "random.h"
+#include "functions.h"
 
 extern void (*gUnk_081140D4[])(Entity*);
 

src/npc/bladeBrothers.c

@@ -1,12 +1,13 @@
 #include "global.h"
 #include "entity.h"
-#include "functions.h"
 #include "flags.h"
 #include "player.h"
 #include "room.h"
 #include "textbox.h"
 #include "save.h"
 #include "script.h"
+#include "npc.h"
+#include "functions.h"
 
 extern void (*gUnk_081115C0[])(Entity*);
 extern void (*gUnk_081115D0[])(Entity*);
@@ -132,7 +133,7 @@ void FUN_08068b2c(Entity* this) {
 }
 
 void sub_08068B70(Entity* this) {
-    if (UpdateFuseInteraction()) {
+    if (UpdateFuseInteraction(this)) {
         this->action = 1;
     }
 }

src/npc/carpenter.c

@@ -2,6 +2,7 @@
 #include "entity.h"
 #include "sprite.h"
 #include "player.h"
+#include "npc.h"
 #include "functions.h"
 
 extern SpriteLoadData gUnk_08110CA8[];

src/npc/cow.c

@@ -1,6 +1,8 @@
 #include "global.h"
 #include "entity.h"
 #include "player.h"
+#include "random.h"
+#include "npc.h"
 #include "functions.h"
 
 extern void (*gUnk_08111914[])(Entity*);

src/npc/epona.c

@@ -2,6 +2,7 @@
 #include "entity.h"
 #include "textbox.h"
 #include "player.h"
+#include "npc.h"
 #include "functions.h"
 
 void sub_08065A64(Entity* this);
@@ -43,7 +44,7 @@ void sub_08065A10(Entity* this) {
 }
 
 void sub_08065A34(Entity* this) {
-    if (UpdateFuseInteraction() != 0) {
+    if (UpdateFuseInteraction(this) != 0) {
         this->action = 1;
         InitAnimationForceUpdate(this, this->animationState / 2);
     }

src/npc/forestMinish.c

@@ -4,10 +4,11 @@
 #include "flags.h"
 #include "textbox.h"
 #include "player.h"
-#include "structures.h"
-#include "functions.h"
 #include "save.h"
 #include "script.h"
+#include "random.h"
+#include "structures.h"
+#include "functions.h"
 
 extern void sub_080600F0(Entity*);
 extern s32 sub_0806EDD8(Entity*, u32, u32);

src/npc/goronMerchant.c

@@ -89,7 +89,7 @@ void sub_08069684(void) {
         if (mgr != NULL) {
             mgr->type = 9;
             mgr->subtype = 0x31;
-            AppendEntityToList(mgr, 8);
+            AppendEntityToList((Entity*)mgr, 8);
         }
     }
 }

src/npc/malon.c

@@ -1,7 +1,8 @@
 #include "global.h"
-#include "functions.h"
 #include "entity.h"
 #include "script.h"
+#include "npc.h"
+#include "functions.h"
 
 extern void (*gUnk_0810FF5C[])(Entity* this);
 extern void (*gUnk_0810FF64[])(Entity* this);

src/npc/melari.c

@@ -2,8 +2,9 @@
 #include "entity.h"
 #include "npc.h"
 #include "textbox.h"
-#include "functions.h"
 #include "script.h"
+#include "random.h"
+#include "functions.h"
 
 extern void sub_08068780(Entity*);
 extern s32 sub_0806EDD8(Entity*, u32, u32);

src/npc/smith.c

@@ -1,9 +1,11 @@
 #include "global.h"
 #include "entity.h"
 #include "textbox.h"
-#include "functions.h"
 #include "save.h"
 #include "script.h"
+#include "random.h"
+#include "npc.h"
+#include "functions.h"
 
 extern void sub_08078850(u32, u32, u32, u32*);
 

src/npc/talon.c

@@ -1,9 +1,11 @@
 #include "global.h"
 #include "entity.h"
 #include "textbox.h"
-#include "functions.h"
 #include "player.h"
 #include "script.h"
+#include "npc.h"
+#include "random.h"
+#include "functions.h"
 
 extern void (*gUnk_0810FEC4[])(Entity* this);
 extern void (*gUnk_0810FEBC[])(Entity* this);
@@ -83,7 +85,7 @@ void sub_08065648(Entity* this) {
 }
 
 void sub_08065680(Entity* this) {
-    if (UpdateFuseInteraction() != 0) {
+    if (UpdateFuseInteraction(this) != 0) {
         this->action = this->field_0x68.HALF.HI;
         InitAnimationForceUpdate(this, this->field_0x6a.HALF.LO);
     }

src/npc/teachers.c

@@ -1,9 +1,10 @@
 #include "global.h"
 #include "entity.h"
 #include "player.h"
-#include "functions.h"
 #include "save.h"
 #include "script.h"
+#include "npc.h"
+#include "functions.h"
 
 extern SpriteLoadData gUnk_08113910[];
 

src/npc/townsperson.c

@@ -4,10 +4,11 @@
 #include "player.h"
 #include "textbox.h"
 #include "flags.h"
-#include "structures.h"
-#include "functions.h"
 #include "save.h"
 #include "script.h"
+#include "random.h"
+#include "structures.h"
+#include "functions.h"
 
 typedef struct {
     u8 frame1;

src/npc/zelda.c

@@ -5,7 +5,6 @@
 #include "flags.h"
 #include "script.h"
 
-extern void PrependEntityToList(Entity*, u32);
 extern Entity* FindEntityBySubtype(u32, u32);
 void sub_08068680(Entity*, Entity*);
 void sub_08068694(Entity*, Entity*);

src/object/backgroundCloud.c

@@ -1,5 +1,6 @@
 #include "global.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern void (*const gUnk_08121EA4[])(Entity*);

src/object/bird.c

@@ -1,8 +1,9 @@
 #include "global.h"
 #include "entity.h"
 #include "flags.h"
-#include "functions.h"
 #include "save.h"
+#include "random.h"
+#include "functions.h"
 
 extern void (*const gUnk_08123EC0[])(Entity*);
 extern void (*const gUnk_08123EEC[])(Entity*);

src/object/cloud.c

@@ -3,6 +3,7 @@
 #include "room.h"
 #include "player.h"
 #include "flags.h"
+#include "random.h"
 #include "functions.h"
 #include "structures.h"
 

src/object/fileScreenObjects.c

@@ -1,13 +1,14 @@
 #include "global.h"
 #include "entity.h"
 #include "flags.h"
-#include "functions.h"
 #include "main.h"
 #include "menu.h"
 #include "npc.h"
 #include "position.h"
-#include "structures.h"
 #include "fileScreen.h"
+#include "readKeyInput.h"
+#include "structures.h"
+#include "functions.h"
 
 extern int sub_0807A094(int);
 extern u32 sub_080041EC(int, int);

src/object/greatFairy.c

@@ -2,10 +2,11 @@
 #include "entity.h"
 #include "room.h"
 #include "screen.h"
-#include "structures.h"
 #include "greatFairy.h"
 #include "flags.h"
 #include "save.h"
+#include "random.h"
+#include "structures.h"
 #include "functions.h"
 
 enum {

src/object/lilypadSmall.c

@@ -1,7 +1,8 @@
 #include "global.h"
 #include "entity.h"
-#include "functions.h"
 #include "player.h"
+#include "random.h"
+#include "functions.h"
 
 extern void sub_080A2CC0(Entity*, Entity**, u16*);
 

src/object/mask.c

@@ -7,7 +7,6 @@
 #include "flags.h"
 #include "functions.h"
 
-
 extern void (*MaskActionFuncs[])(Entity*);
 
 extern void sub_08000148(u16, u16, u32);

src/object/object1A.c

@@ -1,5 +1,6 @@
 #include "global.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern void sub_08086A6C();

src/object/objectA2.c

@@ -1,6 +1,7 @@
 #include "global.h"
 #include "object.h"
 #include "menu.h"
+#include "random.h"
 #include "structures.h"
 #include "functions.h"
 

src/object/smoke.c

@@ -1,5 +1,6 @@
 #include "global.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 extern void (*const gUnk_08121060[])(Entity*);

src/object/windTribeFlag.c

@@ -1,5 +1,6 @@
 #include "global.h"
 #include "entity.h"
+#include "random.h"
 #include "functions.h"
 
 void WindTribeFlag(Entity* this) {

src/room.c

@@ -2,7 +2,6 @@
 #include "entity.h"
 #include "area.h"
 #include "room.h"
-#include "functions.h"
 #include "flags.h"
 #include "npc.h"
 #include "player.h"
@@ -10,6 +9,8 @@
 #include "main.h"
 #include "structures.h"
 #include "save.h"
+#include "random.h"
+#include "functions.h"
 
 void sub_0804B3C4(void* arg0) {
     sub_0804B29C(arg0);

src/script.c

@@ -6,8 +6,9 @@
 #include "structures.h"
 #include "textbox.h"
 #include "dma.h"
-#include "functions.h"
 #include "save.h"
+#include "random.h"
+#include "functions.h"
 
 void sub_0807DAF0(Entity*, ScriptExecutionContext*, u16*);
 void sub_0807DB88(ScriptExecutionContext*, u16*);

src/sub_0804AFF4.c

@@ -5,14 +5,14 @@ extern u32* GetCurrentRoomProperty(u8);
 extern void sub_0804B16C();
 
 void sub_0804AFF4(void) {
-    void(*func)();
+    void (*func)();
 
     sub_080186EC();
-    func = (void(*)())GetCurrentRoomProperty(5);
+    func = (void (*)())GetCurrentRoomProperty(5);
     if (func) {
         func();
     }
-    func = (void(*)())GetCurrentRoomProperty(7);
+    func = (void (*)())GetCurrentRoomProperty(7);
     if (func) {
         func();
     }