From cb1f00c8df5c831dba1f9231ba01d8cef2321e72 Mon Sep 17 00:00:00 2001 From: Henny022p Date: Mon, 3 Mar 2025 10:49:24 +0000 Subject: [PATCH] "fix" false positive null pointer dereference warning --- tools/src/asset_processor/assets/frameobjlists.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/src/asset_processor/assets/frameobjlists.cpp b/tools/src/asset_processor/assets/frameobjlists.cpp index d2ac6b22..69c8000f 100644 --- a/tools/src/asset_processor/assets/frameobjlists.cpp +++ b/tools/src/asset_processor/assets/frameobjlists.cpp @@ -36,7 +36,12 @@ void FrameObjListsAsset::convertToHumanReadable(const std::vector& baserom fmt::print(file.get(), "\t.4byte {:#x}\n", pointer); } - u32 max_second_level = *std::max_element(second_level.begin(), second_level.end()); + auto max_second_level_it = std::max_element(second_level.begin(), second_level.end()); + if (max_second_level_it == second_level.end()) { + fmt::print(stderr, "no second level (unreachable)"); + exit(1); + } + u32 max_second_level = *max_second_level_it; while (reader.cursor < size) { if (static_cast(reader.cursor) > max_second_level) {