Enable -Wdeprecated warnings and fix them

This commit is contained in:
Léo Lam 2020-12-06 02:13:19 +01:00
parent 49097ad9e6
commit f99debc7ef
No known key found for this signature in database
GPG Key ID: 0DF30F9081000741
4 changed files with 22 additions and 2 deletions

View File

@ -15,7 +15,7 @@ set(CMAKE_CXX_EXTENSIONS OFF)
add_executable(uking)
target_include_directories(uking PRIVATE src)
target_compile_options(uking PRIVATE -fno-rtti -fno-exceptions)
target_compile_options(uking PRIVATE -Wall -Wextra)
target_compile_options(uking PRIVATE -Wall -Wextra -Wdeprecated)
target_compile_options(uking PRIVATE -fno-strict-aliasing)
target_compile_options(uking PRIVATE -Wno-invalid-offsetof)

@ -1 +1 @@
Subproject commit d7bf1a5232dd68886126ae9ca68698a5e07a0193
Subproject commit 7bc4c0907158f9be382017c03b339e7d33feac55

View File

@ -17,6 +17,17 @@ public:
/// Destructor that automatically releases any acquired BaseProc.
~ActorLinkConstDataAccess();
ActorLinkConstDataAccess(const ActorLinkConstDataAccess&) = delete;
ActorLinkConstDataAccess& operator=(const ActorLinkConstDataAccess&) = delete;
ActorLinkConstDataAccess(ActorLinkConstDataAccess&& other) noexcept {
*this = std::move(other);
}
ActorLinkConstDataAccess& operator=(ActorLinkConstDataAccess&& other) noexcept {
std::swap(mAcquired, other.mAcquired);
std::swap(mProc, other.mProc);
return *this;
}
/// Acquire a BaseProc. This increments its reference count.
/// If an actor was already acquired, it is released.
bool acquire(BaseProc* proc);

View File

@ -21,6 +21,9 @@ class Handle;
class ILoadRequest {
SEAD_RTTI_BASE(ILoadRequest)
public:
ILoadRequest() = default;
ILoadRequest(const ILoadRequest&) = default;
ILoadRequest& operator=(const ILoadRequest&) = default;
virtual ~ILoadRequest();
bool _8 = false;
@ -34,6 +37,8 @@ class LoadRequest : public ILoadRequest {
public:
LoadRequest();
LoadRequest(s32 load_data_alignment, u32 arg_c, bool arg_20);
LoadRequest(const LoadRequest&) = default;
LoadRequest& operator=(const LoadRequest&) = default;
~LoadRequest() override = default;
bool _20 = false;
@ -64,6 +69,8 @@ class SimpleLoadRequest : public ILoadRequest {
public:
SimpleLoadRequest();
~SimpleLoadRequest() override = default;
SimpleLoadRequest(const SimpleLoadRequest&) = default;
SimpleLoadRequest& operator=(const SimpleLoadRequest&) = default;
sead::SafeString mPath;
void* _30 = nullptr;
@ -75,6 +82,8 @@ class SimplePackedLoadRequest : public ILoadRequest {
public:
SimplePackedLoadRequest();
~SimplePackedLoadRequest() override = default;
SimplePackedLoadRequest(const SimplePackedLoadRequest&) = default;
SimplePackedLoadRequest& operator=(const SimplePackedLoadRequest&) = default;
Handle* mPack = nullptr;
void* _30 = nullptr;