* Document everything except the unknown blob and the weird collision
* Add the last unused texture, thanks Tharo!
* Finish up documentation
* Respond to Elliptic's review
* stuff
* Renaming in-process
- Changed action names and setup names based on examples.
- Undid some ill-advised changes that broke matching.
- Misc variable naming. Need verification and not all complete.
* wip renaming
* A bit more progress on determining names for everything.
* Done with naming.
* Touchup before review
* Updates from review:
- Leave displacementY/unk_AC0 naming to z_actor work.
- Remove unnecessary include of z64math.h, indirect inclusion preferred
- Add trailing comma for better formatting of sDisplayLists
- Rename of static vectors sNullVec3f->sZeroVec, sUnitVectorX->sUnitVecX
- Restore pad instead of using local const. Change const to #define
- Prefer index over idx
- Remove 'b' prefix from bHasNewRootCornerPos
- Const -> Enum and formatting in ObjKendoKanban_IsPlayerOnTop
- Rename 'Aerial' to 'Tumble'
* Missed items in review:
- Missed an instance of displacementY->unk_AC0 renaming (Cause of build failure)
- Whitespace formatting
- UNK_TYPE2 undo
* More adjustments from review:
- Undo accidental formatting changes to z64player.h, restoring to master.
- Naming and Formatting changes.
- Removing some comments.
* From review, qualify enum and #define with obj name, whitespace cleanup.
* Make names related to animations more consistent
* Standardize on sAnimationInfo
* Respond to hensldm's review
* Standardize on ChangeAnim
* Respond to hensldm's review
* Small formatting thing
* Consistency after merging master
* A few more things I missed
* Respond to Elliptic's review
* Some more stuff that was requested
* progress
* progress
* 1 function left
* all functions matching
* data imported
* ovl_Dm_Char09 decompiled
* format
* sfx
* constants
* ovl_Dm_Char09 PR
* pr review
* pr review
* format
* csIndex back to temp until we know proper behav.
* EnRat_Init and EnRat_Destroy OK
* Tons of actionFuncs and other stuff
* EnRat_Update OK
* func_80A566E0 OK and better match for func_80A56EB8
* All draw functions OK
* EnRat OK
* Document object_rat
* Port documentation from Bom_Chu
* Document/name a few more things
* Name all funcs and struct vars
* Un-name unk_18D
* Name some more stuff
* Final round of docs before I ask for help
* Let's just PR this I suppose
* Respond to isghj5's review
* Name a variable I forgot to name
* hookedState stuff
* Clean up forward declares
* Fix after merge
* Respond to reviews
* Limbs -> Limb
* Names for these rascally Vec3f temps
* Name all the vec3fs for real this time
* world -> surface
* surfaceTangent -> forwardPos; there are many tangents, but only one is forward
* Use Elliptic's names + documentation
* worldForwardInHome -> worldPlusForwardInHome
* EnSGoro OK and documented
* Format fix attempt for EnSGoro
* Requested format changes
* EnSGoro additional cleanup
* Fixed updated names
* fork merge (wip - don't review)
* Misc. formatting updates
Also had to un-eat some changes made upstream in functions.txt and variables.txt.
* A couple minor tweaks
* current progress
* all functions matching
* data imported correctly (thanks @Maide)
* ovl_Dm_Ah Decompiled
* warnings
* moved the (Player *) casting for cb consistency
* renamings
* thank you @hensldm
* Jenkins being Jenkins
* correction
* first matches
* pst OK
* fix to be OK
* cleaning stuff up
* feedback
* updating names, PR feedback
* PR 3
* whoopsie on the object
* 4got 2 update the name
* fixing anim name
* PR comment
* Move PictoActor typedefs to z64actor.h
* OK, data imported
* Minor snap stuff
* Name most functions and variables
* Name most of object, apart from animations
* Document snap
* Fix actors to use the PictoActor struct
* Format
* Finish documenting EnGe1
* Finish documenting z_snap and related actors
* Format
* Review, format
* Name last couple of things
* bss
* Review
* Review
* bss
* Introduce z64snap.h, add SCREEN_TO_DEVICE macros
* Back to PROJECTED_TO_SCREEN
* Import data for z_draw
* Match z_draw
* cleanup
* rupees
* Some object gi docs
* More documents
* Add explanation on function names
* more cleanup
* Fixed some things
* More docs
* Object docs WIP, still not done. I'll continue tomorrow
* More WIP, should just be mask gi objects left now
* Some masks done, many more to go
* cleanup
* Last masks finish
* Shield Stolen
* cleanup
* Apply various dicussions
* remove casts
* PR Suggestions
* Sync PowderKeg
* Document object_ma1 (Romani)
* Sync up one of the mouth name textures with how I did it for Cremia
* Specify what the box is for
* Respond to hensldm's review
* Sync texture names with what Anghelo is doing in his Obj_Um PR
* Document a ton of syateki_man
* Document swamp actor lists
* Document animations
* Document player positions
* Document talk flags
* Name wave and spawn index
* Name everything involved in the swamp game
* A hex score I missed
* Some slight town game doc
* Document octorok flags
* Better way of doing octorok flags
* Macros for getting/setting high scores
* Update a variable I missed
* Name remaining struct vars
* Create enum for shootingGameState
* Remove anonymous unions
* hitState -> hitType
* Comment for values next to enums
* Name some more stuff
* Name stuff in Town-RunGame
* Name sGameStartTimer
* Name some more stuff
* Name all static variables
* One more round of comments and such
* Respond to hensldm's review
* GET_INDEX -> GET_ID
* Respond to Elliptic's review (or at least the parts I can respond to right now)
* More review responses
* Add some stuff to z64saves.h I missed
* Message_GetState
* Rename msgCtx->msgLength
* Replace some enums
* TEXT_STATE_CLOSING
* use enum on switches
* use enum when assigning to a variable
* some minor cleanups
* minor cleanup
* TEXT_STATE_CHOICE
* remove unused temp
* z64message.h and z64view.h
* steal some stuff from OoT
* add some stuff to namefixer
* fix shift
* minor doc comment
* Update MessageContext struct from andzura's branch
Co-authored-by: Andzura <11079691+Andzura@users.noreply.github.com>
* some other TextState uses I missed
* format
* statetimer in dec
* review
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* review
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* review
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* format
* Batch () commit
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* review
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* format
* bss
* use text state defines on new actors
* fix matching
* bss
Co-authored-by: Andzura <11079691+Andzura@users.noreply.github.com>
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Document some low-hanging fruit in EnDg
* Animation and type documentation
* Document a bunch of stuff
* Name more functions
* Params macro
* Defines for dog flags
* Name all struct variables
* Give all animations better names
* Better name for Swim2
* Document/name a bunch of stuff
* Make index enum
* Respond to engineer's review
* Respond to mzx's review
* Fix up comment (again)
* Respond to hensldm's review
* OK, data imported
* Fix some typos
* Start docs
* Struct almost finished
* Start object, add state enum
* undefined_syms
* Finish object, name some more stuff
* Name a few states and another function
* PlayState
* Minor tweaks in z_room and z_sub_s
* Complete documentation
* spec
* Review 1
* functions.txt
* Schedule result enum
* Rename schedule results
* Review
* Remove update comments
* Inventory_DeleteItem
* PLAYER_STATE
* Format
* Review
* Update struct name
* Merge in sub_s_models
* Update subs DL names
* Unused Weight pathing
* Function headers for weightpathing
* TimePathing WIP
* Timepathing, still unsure about unk184
* Move subs functions from functions.h to z64subs.h
* Add fake comment
* Some cleanup and renames
* Renames/cleanup of actors that use timepath
* Cleanup
* More cleanup
* Rename unk stuff
* Merge in upstream/master
* TimeElapsed -> elapsedTime
* Fix
* Final cleanup
* SubS Time Paths
* Still needs dialog action functions
* Fix waypoint comments
* Review pt. 1
* Baba review
* ScheduleResult -> ScheduleOutput
* Forgot to update functions.txt oops
* Add clarifying comment to SubS_TimePathing_FillWeightArray
* format.sh
* Finish up docs
* Fix order comments
* Fix
* Change bombShopkeeper struct member to
* Fix a few merge mistakes
* Add ScheduleOutput to namefixer
* format
* Format and fix merge
* Review
* PR
* z64schedule.h
* text summary
Co-authored-by: Maide <34639600+Kelebek1@users.noreply.github.com>
Co-authored-by: Tom Overton <tom-overton@users.noreply.github.com>
* ovl_Obj_Purify decompiled and partially documented
* document member names
* variable names and format
* oops missed some booleans
* review fixes
* more review fixes
* even more review fixes
* rename ObjPurifyInfoList to sObjPurifyInfo
* OK, start documentation
* Name some more stuff
* Name rest of functions and bss var, tidy up floats
* Document object and paramflags
* Cleanup bat
* Cleanup crow
* Cleanup firefly
* Couple of minor things in arrow
* Review 1
* PLAYER_STATE
* Remove unnecessary f32 casts
* Review
* Review
* all functions matching, data isn't?
* cleanup in progress
* ovl_Dm_Al Decompiled
* pr review
* Documentation Fixes and new entries
* forgot one
* pr review
* almost there
* ovl_Eff_Kamejima_Wave Decompiled
* Us removal
* minor clean up
* pr review
* review
* sikihi rollback and function name fix
* params rename
* SetVtxAlpha
* params prefix
* Jenkins re-run
* starting en_ik
* updating and more matching funcs
* matched more functions and ran format.sh
* matched another, started on init
* updating things with master, and more matches
* another function down
* some more progress
* some documenting
* master merge
* maybe some progress?
* one more func left
* IK OK
* inital cleanup passthrough
* fixing warnings and formatting
* some cleanup
* touch up
* more docs
* doin dat dere docs
* actorfixer
* finishing function names
* initial round of fixes
* format
* Naming things
* namefixer
* review comments pt2
* comment updates
* PR Feedback
* forgot a format
* naming enum
* more fixes
* minor fix
* minor fix
* format
* fixes for daaays
* for some reason these keep showing up?
* fixing blob
* names
* fixes
* naming things...can't discern the last ones...
* updating TLUT and names
* formating and fisxes
* fixing func name
* naming effect variable
* name fixer, and renaming variable
* Fixing xml
* forgot to fix name
* z_map_exp OK
* some names
* Some more docs
* Update prototypes in functions.h
* Use reg name
* namefixer
* Respond to review
* Respond to review
* Respond to review
* Add some blank lines after breaks, whoops
* Respond to review
* Respond to Engineer's review, pt 2
* Respond to Engineer's review, Pt 3
* Add newline char to end of z64map.h
* Respond to engineer's review, Pt 4
* Respond to multiple reviews
* Document object_uch (Aliens)
* Remove dummy label match that has been annoying me for a year!!!!!!!!!!!!!
* Respond to reviews
* Fix a small thing brought up in review
* Swap to gAlienJerkingAnim
* ovl_Dm_Char02 decompiled
* remove m2c comments
* remove ovl_Dm_Char02 data in spec
* ran format.sh
* fix format version
* use our reloc
* fix reviews
* rename context/playstate structs
* format
* more review fixing
* even more review fixing
* test commit
* undoing test commit
* making sure this is the right repo
* removing test file
* init for OSH bombable wall started. put back Actor* in function declarations.
* BgKin2Bombwall_Init is matching.
* started z_bg_kin2_bombwall destroy function. One mismatch right now.
* BgKin2Bombwall_Destroy matches.
* BgKin2Bombwall_Draw matches.
* Fixed BgKin2Bombwall_Init
* BgKin2Bombwall_Init and BgKin2Bombwall_Destroy both match. Fixed s32 array in struct.
* BgKin2Bombwall_Draw and BgKin2Bombwall_Update match.
* Only func_80B6E020 and func_80B6E090 left to match in ovl_Bg_Kin2_Bombwall.
* func_80B6E020 from ovl_Bg_Kin2_Bombwall matches.
* Went from 8925 to about 5-6k diff score for func_80B6E090 in ovl_Bg_Kin2_Bombwall
* Took func_80B6E090 from about 5300 diff score to about 4300 diff score in ovl_Bg_Kin2_Bombwall.
* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 4k ish to 3277
* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 3277 to 2262.
* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 2262 to 1589.
* only slight progress on ovl_Bg_Kinw_Bombwall's func_80B6E090
* Got to 1473 diff score on ovl_Bg_Kinw_Bombwall's func_80B6E090
* Put in the changes made by EllipticEllipsis and hensldm for ovl_Bg_Kin2_Bombwall's func_8066E090.
* renamed some symbols. Fake symbol removal makes nonzero diff, but rom OK's after make.
* moving declarations around, ordering.
* One.word.away. from importing data in ovl_Bg_Kin2_Bombwall.
* ovl_Bg_Kin2_Bombwall data imported. Matching.
* Edited spec for reloc of ovl_Bg_Kin2_Bombwall.
* Removed extra comments for ovl_Bg_Kin2_Bombwall.
* unpushed stuff. dunno.
* forgot to save z_bg_kin2_bombwall.c
* need to commit before make-ing in master.
* Ported z_bg_kin2_bombwall's code. Data next.
* Imported data for merging z_bg_kin2_bombwall. Yes, I yelled when it OK'd.
* Added comments to remember what does what in z_bg_kin2_bombwall.
* Some comments in z_bg_kin2_bombwall.c and function names ideas.
* Added comments for function name ideas. Cleaned up temps in z_bg_kin2_bombwall except in func_80B6E090.
* Renamed most functions and some variables in z_bg_kin2_bombwall.
* Made a name suggestion for func_80B6E020 after testing in game.
* Ran format.sh.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
1 and 0 replaced by true and false in func_80B6E020.
Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Bending to the x-- supremacy.
Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>
* PR fixes (not done yet) including more consistent use of THIS, removing arg0 and arg1 variable names, standardizing params for z_bg_kin2_bombwall, turning some if-return to if-else, removing unnecessary casts.
* Applied isghj5's and EllipticEllipsis' suggestions except for the object file in z_bg_kin2_bombwall. Object file next.
* Screwd up formatting.
* Thinking of playing with object_kin2_obj.
* Documented most of object_kin2_obj based on bombwall, fence and shelf actors.
* Had forgotten an arg1 in z_bg_kin2_bombwall.c
* First commit for ovl_Bg_Ikana_Mirror branch.
* Started decompiling ovl_Bg_Ikana_Mirror. Setup functions and _Update done matching.
* Replaced a float by its fractional representation. I need to learn float magic.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.h
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Applied more formatting and naming remarks from PR about the C file. Assets and object stuff next.
* Display lists and collision header in z_bg_kin2_bombwall.c renamed after their descriptive names in the object's XML file. Name for Ocean Spider House drawers chests left to change.
* Working on BgIkanaMirror_Destroy. Stack and registers left essentially.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* One extra line in an if, collision naming convention applied and renamed Ocean Spider House nightstands to drawers chests.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Changed drawers chest to chest of drawers in object_kin2_obj and z_bg_kin2_shelf.
* Removed some unnecessary comment.
* almost done with BgIkanaMirror_Destroy function.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* BgIkanaMirror_Destroy OK.
* Almost done with BgIkanaMirror_Init. Mostly stack stuff left.
* Registers and stack left to fix for BgIkanaMirror_Init.
* BgIkanaMirror_Init matching.
* Ran permuter to improve BgIkanaMirror_Draw's score.
* Actually not mad at permuter for BgIkanaMirror_Draw headstart.
* Matched func_80B7F730 in ovl_Bg_Ikana_Mirror. Progress on its _Init done too.
* func_80B7FA9C in ovl_Bg_Ikana_Mirror is matching. _Init left then documentation.
* Mistake in last commit message: actually, _Draw is left for ovl_Bg_Ikana_Mirror.
* Going to do some groceries, so pushing. About 2/3 across func_80B7FBA4 in ovl_Bg_Ikana_Mirror.
* func_80B7FBA4 in ovl_Bg_Ikana_Mirror is matching. _Draw then data left.
* Need to switch branch.
* Fixed BgKin2Bombwall_SpawnEffects after the Rand_Next() type update.
* Switching branch.
* Learning to decomp draw functions with BgIkanaMirror_Draw. YEP
* Switching branch.
* Went through the first wave of graphics macros attempts for BgIkanaMirror_Draw.
* Removed some temps in BgIkanaMirror_Draw.
* Second pass of macro attempts for BgIkanaMirror_Draw.
* Diff score for BgIkanaMirror_Draw at 1873. Getting there.
* BgIkanaMirror_Draw diff score down to 854. 4 instructions off and registers to fix.
* Instructions are matching for BgIkanaMirror_Draw. Registers left.
* BgIkanaMirror_Draw matches. Data next. Adding some co-authors
* BgIkanaMirror_Draw matches. Data next. Adding some co-authors
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Tom-Overton <hensley.derek58@gmail.com>
Co-authored-by: Isghj5 <isghj5@gmail.com>
Co-authored-by: mzxrules <mzxrules@gmail.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
* Data imported and OK.
Co-authored-by: Maide <eeeedddccc@hotmail.co.uk>
Co-authored-by: mzxrules <mzxrules@gmail.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
* Removed commented lines of unused code and useless externs. Documenting C file and object next.
* Renamed fields in actor and variables in 3 functions for ovl_bg_ikana_mirror. Some conventions applied.
* Renamed more variables in the struct and C file for ovl_bg_ikana_mirror.
* More cleanups and naming in ovl_Bg_Ikana_Mirror.
* Renamed some functions in ovl_Bg_Ikana_Mirror. More cleanups. Object documentation next once function names confirmed.
* Renamed collision header, animated textures and display lists for ovl_Bg_Ikana_Mirror in ovl_Bg_Ikana_Mirror and object_ikana_obj. Some textures left to rename.
* Renamed textures only used by ovl_Bg_Ikana_Mirror. Must go back through docs for conventions and styles plus an extra cleanup before PR.
* Went through merging and review docs for extra cleanups. Adding co-authors for documentation.
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
* Creating branch to merge ovl_Bg_Ikana_Mirror.
* Fixed the merge from zeldaret/mm. ovl_Bg_Ikana_Mirror OK and documented. PR-ready.
* Applied first batch of fixes from PR comments. Adding co-authors for documentation and a function rewrite.
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
Co-authored-by: Kelebek1 <eeeedddccc@hotmail.co.uk>
* Renamed the colliders in ovl_Bg_Ikana_Mirror's struct and fixed naming in object file plus spacing cleanups.
* Full rename for data and temps with respect to the mirror's and light rays' respective colliders.
* Update src/overlays/actors/ovl_Bg_Ikana_Mirror/z_bg_ikana_mirror.h
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Update src/overlays/actors/ovl_Bg_Ikana_Mirror/z_bg_ikana_mirror.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Update src/overlays/actors/ovl_Bg_Ikana_Mirror/z_bg_ikana_mirror.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Update src/overlays/actors/ovl_Bg_Ikana_Mirror/z_bg_ikana_mirror.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Formatting needed to be applied after commiting suggestions.
* Renamed more textures and removed unnecessary array sizes in the data.
* Forgot to run formatter.
Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Isghj5 <isghj5@gmail.com>
Co-authored-by: mzxrules <mzxrules@gmail.com>
Co-authored-by: Maide <eeeedddccc@hotmail.co.uk>
* starting point
* add rabbitizer stuff, but commented out
* kinda works now, except for symbols
* trying to fix using symbols for disassembly
* more fixes
* fix branches and some format changes
* make disasm.py runnable again 😅
* fix double words
* hopefully fix jumptables
* fix delay slot spacing on entry.s
* Fix delay slot shenanigans
* minor format update
* re enable multithreading
* add rabbitizer to requirements.txt and cleanup the file
* cleanup
* more cleanup
* more cleanups
* getImmOverride
* black
* hopefully final cleanup
* diff.py requirements
* Install python dependencies on jenkinsfile
* --no-cache
* Remove `--no-cache --upgrade`
* branch_likely_delay_slot_save
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
* review
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* a
* Don't use $FpcCsr
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* PlayState rename
* Make this work with the latest master and run format
* Respond to hensldm's review
* Respond to Elliptic's review
* Add Effect_GetPlayState to namefixer.py
* Add missed comma
* test commit
* undoing test commit
* making sure this is the right repo
* removing test file
* init for OSH bombable wall started. put back Actor* in function declarations.
* BgKin2Bombwall_Init is matching.
* started z_bg_kin2_bombwall destroy function. One mismatch right now.
* BgKin2Bombwall_Destroy matches.
* BgKin2Bombwall_Draw matches.
* Fixed BgKin2Bombwall_Init
* BgKin2Bombwall_Init and BgKin2Bombwall_Destroy both match. Fixed s32 array in struct.
* BgKin2Bombwall_Draw and BgKin2Bombwall_Update match.
* Only func_80B6E020 and func_80B6E090 left to match in ovl_Bg_Kin2_Bombwall.
* func_80B6E020 from ovl_Bg_Kin2_Bombwall matches.
* Went from 8925 to about 5-6k diff score for func_80B6E090 in ovl_Bg_Kin2_Bombwall
* Took func_80B6E090 from about 5300 diff score to about 4300 diff score in ovl_Bg_Kin2_Bombwall.
* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 4k ish to 3277
* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 3277 to 2262.
* Diff score for ovl_Bg_Kin2_Bombwall func_80B6E090 went from 2262 to 1589.
* only slight progress on ovl_Bg_Kinw_Bombwall's func_80B6E090
* Got to 1473 diff score on ovl_Bg_Kinw_Bombwall's func_80B6E090
* Put in the changes made by EllipticEllipsis and hensldm for ovl_Bg_Kin2_Bombwall's func_8066E090.
* renamed some symbols. Fake symbol removal makes nonzero diff, but rom OK's after make.
* moving declarations around, ordering.
* One.word.away. from importing data in ovl_Bg_Kin2_Bombwall.
* ovl_Bg_Kin2_Bombwall data imported. Matching.
* Edited spec for reloc of ovl_Bg_Kin2_Bombwall.
* Removed extra comments for ovl_Bg_Kin2_Bombwall.
* unpushed stuff. dunno.
* forgot to save z_bg_kin2_bombwall.c
* need to commit before make-ing in master.
* Ported z_bg_kin2_bombwall's code. Data next.
* Imported data for merging z_bg_kin2_bombwall. Yes, I yelled when it OK'd.
* Added comments to remember what does what in z_bg_kin2_bombwall.
* Some comments in z_bg_kin2_bombwall.c and function names ideas.
* Added comments for function name ideas. Cleaned up temps in z_bg_kin2_bombwall except in func_80B6E090.
* Renamed most functions and some variables in z_bg_kin2_bombwall.
* Made a name suggestion for func_80B6E020 after testing in game.
* Ran format.sh.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
1 and 0 replaced by true and false in func_80B6E020.
Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Bending to the x-- supremacy.
Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>
* PR fixes (not done yet) including more consistent use of THIS, removing arg0 and arg1 variable names, standardizing params for z_bg_kin2_bombwall, turning some if-return to if-else, removing unnecessary casts.
* Applied isghj5's and EllipticEllipsis' suggestions except for the object file in z_bg_kin2_bombwall. Object file next.
* Screwd up formatting.
* Thinking of playing with object_kin2_obj.
* Documented most of object_kin2_obj based on bombwall, fence and shelf actors.
* Had forgotten an arg1 in z_bg_kin2_bombwall.c
* Replaced a float by its fractional representation. I need to learn float magic.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.h
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Applied more formatting and naming remarks from PR about the C file. Assets and object stuff next.
* Display lists and collision header in z_bg_kin2_bombwall.c renamed after their descriptive names in the object's XML file. Name for Ocean Spider House drawers chests left to change.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* One extra line in an if, collision naming convention applied and renamed Ocean Spider House nightstands to drawers chests.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Changed drawers chest to chest of drawers in object_kin2_obj and z_bg_kin2_shelf.
* Removed some unnecessary comment.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Fixed BgKin2Bombwall_SpawnEffects after the Rand_Next() type update.
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Rand_Next() update.
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Rand_Next() update.
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
* Adding Co-authors
Co-authored-by EllipticEllipsis 73679967+EllipticEllipsis@users.noreply.github.com
Co-authored-by Derek-Hensley hensley.derek58@gmail.com
Co-authored-by Maide eeeedddccc@hotmail.co.uk
Co-authored-by Tom-Overton tom.overton@outlook.com
Co-authored-by Fig02 fig02srl@gmail.com
Co-authored-by Parker-Burnett burnettparker@gmail.com
Co-authored-by isghj5 isghj5@gmail.com
* Adding Co-authors
Co-authored-by EllipticEllipsis 73679967+EllipticEllipsis@users.noreply.github.com
Co-authored-by Derek-Hensley hensley.derek58@gmail.com
Co-authored-by Maide eeeedddccc@hotmail.co.uk
Co-authored-by Tom-Overton tom.overton@outlook.com
Co-authored-by Fig02 fig02srl@gmail.com
Co-authored-by Parker-Burnett burnettparker@gmail.com
Co-authored-by isghj5 isghj5@gmail.com
* Adding Co-authors
Co-authored-by EllipticEllipsis 73679967+EllipticEllipsis@users.noreply.github.com
Co-authored-by Derek-Hensley hensley.derek58@gmail.com
Co-authored-by Maide eeeedddccc@hotmail.co.uk
Co-authored-by Tom-Overton tom.overton@outlook.com
Co-authored-by Fig02 fig02srl@gmail.com
Co-authored-by Parker-Burnett burnettparker@gmail.com
Co-authored-by isghj5 isghj5@gmail.com
* Adding Co-authors
Co-authored-by EllipticEllipsis 73679967+EllipticEllipsis@users.noreply.github.com
Co-authored-by Derek-Hensley hensley.derek58@gmail.com
Co-authored-by Maide eeeedddccc@hotmail.co.uk
Co-authored-by Tom-Overton tom.overton@outlook.com
Co-authored-by Fig02 fig02srl@gmail.com
Co-authored-by Parker-Burnett burnettparker@gmail.com
Co-authored-by isghj5 isghj5@gmail.com
* Adding Co-authors
Co-authored-by EllipticEllipsis 73679967+EllipticEllipsis@users.noreply.github.com
Co-authored-by Derek-Hensley hensley.derek58@gmail.com
Co-authored-by Maide eeeedddccc@hotmail.co.uk
Co-authored-by Tom-Overton tom.overton@outlook.com
Co-authored-by Fig02 fig02srl@gmail.com
Co-authored-by Parker-Burnett burnettparker@gmail.com
Co-authored-by isghj5 isghj5@gmail.com
* Adding Co-authors
Co-authored-by: EllipticEllipsis 73679967+EllipticEllipsis@users.noreply.github.com
Co-authored-by: Derek-Hensley hensley.derek58@gmail.com
Co-authored-by: Maide eeeedddccc@hotmail.co.uk
Co-authored-by: Tom-Overton tom.overton@outlook.com
Co-authored-by: Fig02 fig02srl@gmail.com
Co-authored-by: Parker-Burnett burnettparker@gmail.com
Co-authored-by: isghj5 isghj5@gmail.com
* Adding Co-authors
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
Co-authored-by: Maide <eeeedddccc@hotmail.co.uk>
Co-authored-by: Tom-Overton <tom.overton@outlook.com>
Co-authored-by: Fig02 <fig02srl@gmail.com>
Co-authored-by: Parker-Burnett <burnettparker@gmail.com>
Co-authored-by: isghj5 <isghj5@gmail.com>
* Update src/overlays/actors/ovl_Bg_Kin2_Bombwall/z_bg_kin2_bombwall.c
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Isghj <42048411+isghj5@users.noreply.github.com>
Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com>
Co-authored-by: Maide <eeeedddccc@hotmail.co.uk>
Co-authored-by: Tom-Overton <tom.overton@outlook.com>
Co-authored-by: Fig02 <fig02srl@gmail.com>
Co-authored-by: Parker-Burnett <burnettparker@gmail.com>
Co-authored-by: isghj5 <isghj5@gmail.com>
* Change "particle" to "effect" in most actors
* Undo accidental comment change
* Effect count defines
* Make struct names consistent
* Fix minislime
* Change particle to effect in Demo_Kankyo
* Some tiny things I missed
Tom Overton