falso
/
botw
mirror of https://github.com/zeldaret/botw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use sead::Buffer::fill where applicable 

Equivalent, shorter, more readable, and matching!
This commit is contained in:
Léo Lam 2022-03-25 21:33:00 +01:00
parent 0e8cad1d0d
commit 4b2c55b82b
No known key found for this signature in database
GPG Key ID: 0DF30F9081000741
5 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
data/uking_functions.csv
View File

@ -91512,7 +91512,7 @@ Address,Quality,Size,Name
0x00000071011ab1fc,O,000144,_ZThn664_N4ksys3res2ASD0Ev 0x00000071011ab1fc,O,000144,_ZThn664_N4ksys3res2ASD0Ev
0x00000071011ab28c,O,000004,_ZN4ksys3res2AS9doCreate_EPhjPN4sead4HeapE 0x00000071011ab28c,O,000004,_ZN4ksys3res2AS9doCreate_EPhjPN4sead4HeapE
0x00000071011ab290,O,000004,_ZThn632_N4ksys3res2AS9doCreate_EPhjPN4sead4HeapE 0x00000071011ab290,O,000004,_ZThn632_N4ksys3res2AS9doCreate_EPhjPN4sead4HeapE
0x00000071011ab294,m,001992,_ZN4ksys3res2AS6parse_EPhmPN4sead4HeapE 0x00000071011ab294,O,001992,_ZN4ksys3res2AS6parse_EPhmPN4sead4HeapE
0x00000071011aba5c,O,000028,_ZNK4ksys3res2AS16getFirstResourceEv 0x00000071011aba5c,O,000028,_ZNK4ksys3res2AS16getFirstResourceEv
0x00000071011aba78,O,000008,_ZThn632_N4ksys3res2AS6parse_EPhmPN4sead4HeapE 0x00000071011aba78,O,000008,_ZThn632_N4ksys3res2AS6parse_EPhmPN4sead4HeapE
0x00000071011aba80,O,000104,_ZN4ksys3res2AS9finalize_Ev 0x00000071011aba80,O,000104,_ZN4ksys3res2AS9finalize_Ev

Can't render this file because it is too large.

4
src/KingSystem/Resource/Actor/resResourceAS.cpp
View File

@ -18,7 +18,6 @@ AS::~AS() = default;
void AS::doCreate_(u8*, u32, sead::Heap*) {} void AS::doCreate_(u8*, u32, sead::Heap*) {}
// NON_MATCHING: SafeString vtable load is reordered
bool AS::parse_(u8* data, size_t size, sead::Heap* parent_heap) { bool AS::parse_(u8* data, size_t size, sead::Heap* parent_heap) {
mHeap = util::tryCreateDualHeap(parent_heap); mHeap = util::tryCreateDualHeap(parent_heap);
if (!mHeap) if (!mHeap)
@ -47,8 +46,7 @@ bool AS::parse_(u8* data, size_t size, sead::Heap* parent_heap) {
return false; return false;
} }
for (int i = 0, n = mElementResources.size(); i < n; ++i) mElementResources.fill(nullptr);
mElementResources(i) = nullptr;
ASResource::ParseArgs args; ASResource::ParseArgs args;
args.list = {}; args.list = {};

3
src/KingSystem/Resource/Actor/resResourceASResource.cpp
View File

@ -228,8 +228,7 @@ bool ASResourceWithChildren::doParse(const ASResource::ParseArgs& args) {
if (!mChildren.tryAllocBuffer(size, args.heap)) if (!mChildren.tryAllocBuffer(size, args.heap))
return false; return false;
for (int i = 0, n = mChildren.size(); i < n; ++i) mChildren.fill(nullptr);
mChildren(i) = nullptr;
for (auto it = mChildren.begin(), end = mChildren.end(); it != end; ++it) { for (auto it = mChildren.begin(), end = mChildren.end(); it != end; ++it) {
const auto idx = *Children.getParameterData<int>(it.getIndex()); const auto idx = *Children.getParameterData<int>(it.getIndex());

3
src/KingSystem/Resource/Actor/resResourceASResourceExtension.cpp
View File

@ -259,8 +259,7 @@ bool ASExtensions::parse(const ASExtensions::ParseArgs& args) {
if (!mParsers.tryAllocBuffer(num_extensions, args.heap)) if (!mParsers.tryAllocBuffer(num_extensions, args.heap))
return false; return false;
for (int i = 0, n = mParsers.size(); i < n; ++i) mParsers.fill(nullptr);
mParsers(i) = nullptr;
auto it = mParsers.begin(); auto it = mParsers.begin();
const auto end = mParsers.end(); const auto end = mParsers.end();

4
src/KingSystem/Utils/Container/LockFreeQueue.h
View File

@ -22,9 +22,7 @@ public:
void alloc(int capacity, sead::Heap* heap) { void alloc(int capacity, sead::Heap* heap) {
SEAD_ASSERT(sead::Mathi::isPow2(capacity)); SEAD_ASSERT(sead::Mathi::isPow2(capacity));
mBuffer.allocBufferAssert(capacity, heap); mBuffer.allocBufferAssert(capacity, heap);
mBuffer.fill(nullptr);
for (int i = 0, n = getCapacity(); i < n; ++i)
mBuffer(i) = nullptr;
} }
void freeBuffer() { mBuffer.freeBuffer(); } void freeBuffer() { mBuffer.freeBuffer(); }