* ringing in the bell
* another matching func
* stuck on func_80A357A8, needs a z_actor func...
* no luck on a fix, but got further...
* matched func_80A357A8, one left
* might be on the right track? saving progress...
* getting closer
* pushing up matching, it has warnign regarding Vecs
* all functions matching
* obj_bell OK, time for bed
* prepping for PR
* fixing suggestions
* Everything matches but func_80BDABCC
* Better names, still stuck on func_80BDABCC
* Some cleanup
* Add param macros and document not matching
* format
* PR suggestions
* Bring over data to c file
* Retry Jenkins
* Retry Jenkins take 2
* PR suggestions for comments
* PR comments
* Lots of progress
* OK
* Removed casts
* Run format.sh
* cleanup
* More cleanup
* Minor Doc
* More cleanup
* Format
* Add header description
* PR comments
* Convert raw pointers
* Update to new gSaveContext
* PR suggestions
* Adds a first pass of REVIEWING.md
* Update REVIEWING.md
* Clarifies better what files can be in the header.
* More clarity on how to resolve jenkins build errors.
* Adds a link to the Code Review Guidelines to README.md
* Adds code review guidelines link to contributing.md
* Clarifies trello procedures.
* Adds warning that NON_MATCHING equivalence isn't reviewed for yet.
* First pass
* second pass
* Everything matches now
* Fix ori
* final pass
* Add description
* Fix warnings (I hope)
* move dlist to top of the file
* Fix conflicts
* not ok, why?
* OK!
* fix data
* finish data etc
* work on save context
* save finished
* first func done
* roomInf
* done for now
* add missing file
* add most og names for struct members
* fix accidental change
* Update z_en_ginko_man.c
* Update z_scene.c
* maybe fix stuff hopefully
* proto
* sasa
* Update include/z64save.h
Co-authored-by: Anghelo Carvajal <anghelo.carvajal.14@sansano.usm.cl>
* Update z64save.h
Co-authored-by: Anghelo Carvajal <anghelo.carvajal.14@sansano.usm.cl>
* Fix `extract_assets` not properly checking if scenes files were updated
* fix `first_diff.py` path due to the baserom renaming
* FlexSkeletonHeader and other stuff
* fix some SkeletonHeader instead of FlexSkeletonHeader
* Add blob compilation to makefile
* CURRENT_DAY and type swaps
* Remove extra cast
* run format
* zbanks suggestions
* some easy functions
Signed-off-by: Angie <angheloalf95@gmail.com>
* init is cursed
Signed-off-by: Angie <angheloalf95@gmail.com>
* func_80919230 is weird
Signed-off-by: Angie <angheloalf95@gmail.com>
* I'm dumb
Signed-off-by: Angie <angheloalf95@gmail.com>
* func_80919768 nonmatching
Signed-off-by: Angie <angheloalf95@gmail.com>
* everything is wrong
Signed-off-by: Angie <angheloalf95@gmail.com>
* This thing still doesn't want to match
Signed-off-by: Angie <angheloalf95@gmail.com>
* improved a bit
Signed-off-by: Angie <angheloalf95@gmail.com>
* a bit of renaming, but it still doesn't work
Signed-off-by: Angie <angheloalf95@gmail.com>
* almost matching
* func_80919768 ok
* func_809199FC ok
* init was dumb
* add enum and other minor changes
* run format
* almost every function
* atans ok
* import data and rodata
* format `atan_first_8th_array`
* fix signature and rodata
* rename to angle
* Rename the functions to match their OoT counterparts
* rename code_0x8017FEB0 to sys_math_atan
* Small env fixes: for git submodules & python3
Using `/usr/bin/env python3` is preferred over `/usr/bin/python3`
because it is compatible with virtualenvs, etc. It picks the version of
`python3` currently on the `PATH`, rather than the system-wide default.
For the git submodules, I had two issues:
The ZAPD repo is currently pointing at a commit not on the master
branch, which has to be specifically fetched. Adding `--remote` to the
update command fixes this.
The decomp-permuter has primary branch `main` not `master` like this
repo, so this has to be specified in `.gitmodules` when using `--remote`.
* Rework `git submodule update...` part of Makefile
* adding changes to the README
* adding in progress shield
adding in the shield icon to show percentage complete
* updating the files, added gitignore for ctx.c
* fixing the typos
* fixing things to hopefully build now
* BgCtowerGear OK
* Added description header
* Updated functions.txt
* Added MACRO to get type
* Renamed init chains to match tyype
* Added one more use of Macro, and addressed PR comment
* Fixed data copy error and better naming
* Restore padding in ObjVisiblock struct
* Copy overlays out of compiled `code.elf` to put into the ROM
This is just a "tempory fix"
It seems like the built code/assets in `code.elf` should not be copied
into `build/baserom/...` (over the original ROM's files) but instead
into a `build/decomp/...` tree or similar.
`dmadata_table.txt` would also need to be updated to read from the
correct location.
* Use dmadata_table.txt to generate build rules
`makerom_files.txt` & `makerom_uncompressed_files.txt` contained a lot
of the same data in `dmadata_table.txt`, so I added a small python
script to generate this information into `build/`
Segments are no longer dumped out of `code.elf` into `build/baserom/``,
instead they are put in `build/binary/`.
`linker_scripts/dmadata_script.txt` was checked in, but generated by
`dmadata.py`. I deleted it / moved it to `build/dmadata_script.txt.pre`.
I also introduced some sentinel files (`dep`). I ended up needing these
to make incremental builds work smoothly? (Without them, there were a
lot of steps that were getting re-triggered on every build.) If this
style isn't welcome, I can try to fiddle with the Makefile more to try
to avoid having them?
* Restore padding in BgLbfshot struct
* Touch sentinel file before command; rm on failure
* Restore padding in ObjKepnKoya struct
* Ensure asm/ directories exist before disasm steps
* Clean up Makefile rules
* Set default goal; silent objcopy; fix code_script path
* Fix ovl_En_Ginko_Man, ovl_Obj_Lightswitch merge
ovl_En_Encount2 still needs work to bring back to matching
* Fix ovl_En_Encount2 merge
* EnEncount2: start
* EnEncount2: got some easy functions down, but now I have a really weird unk struct
* EnEncount2: draw function nowhere close
* EnEncount2: cleaning/docs
* EnEncount2: removed bad function attempt
* EnEncount2: function name change to match mster changes
* EnEncount2: corrected old BgMeshheader to CollisionHeader
* EnEncount2: requested changes
* EnEncount2: forgot to add these requested changes
* EnEncount2: requested changes
Co-authored-by: isghj8 <isghj8@gmail.com>
* match function
* major cleanups
* rename switch functions
* use graph_alloc to fix fake matches
* more documentation
* more matches, lots of changes
* lots more work
* format
* Update z_scene_proc.c
* very hard lagrange interpolation function OK!
* remove any remaining
* documentation done, only two functions left
* a few more things
* one function left!
* document another oot leftover
* last function decompiled, not matched yet
* scene_proc complete
* start work on z_scene
* done with z_scene
* remove unessecary typedefs
* fix some things to remove warnings
* Add z_scene_table and decomp data
* Delete ctx.c
* add draw cfg enum
* cleanup
* most scene table functions done
* done for now
* all scene files done
* Update include/z64scene.h
Co-authored-by: Anghelo Carvajal <anghelo.carvajal.14@sansano.usm.cl>
* add missing macros
* fix some renames
* scene texture file rename
* added temporary structs so it still builds
* more structs
* even more old structs
* fix boyo
* should fix compile error
* lets hope nothing broke
* ub comment back
Co-authored-by: Anghelo Carvajal <anghelo.carvajal.14@sansano.usm.cl>
* EnNutsball Match but one function with sp issues
* Updated ActorPlayer
* Renamed unk144 to timer and added data as comment
* Got update matched but stack issues with two vars
* add back new line
* Fixed stack issue based on PR comments. Added data
* more descriptive variable names
* Use OPEN_DISPS/CLOSE_DISPS macros in draw
* Address PR comments
* ovl_Dm_Ravine OK (Link Riding Through Lost Woods Cutscene - Tree Trunk)
* ovl_Dm_Ravine: respond to PR comments
* Rename/retype DmRavine_Action -> DmRavine_DoNothing
* ovl_Dm_Ravine: incorporate PR feedback from kyleburnette
* ovl_Dm_Ravine: rename fields; use enum for state
* starting actor
* close to being done
* updating txt files
* z_en_jc_mato OK
* Merge branch 'master' into en_jc_mato
* fixing some suggestions
* adding names
* changing name to movement
Nick