* EnInvadepohDemo (Aliens cutscene actors) OK and documented
* Make bss variables non-static
* Provide type to Actor_SpawnAsChild
* Respond to hensldm's review
* Introduce obvious misformat
* Format again, see if that fixes it?
* Push the misformat up so I can see how Jenkins complains
* Fix formatting on my end (again)
* Apparently I had to merge master to fix the formatting issue??????
* Respond to engineer's review
* Document EnTanron5 (destructible props, fragments, and item drops in Twinmold's arena)
* Respond to engineer's review
* Updated the type names, used "ruin" instead of "prop" in comments, and addressed Anon's review
* Missed this instance of "prop"
* Respond to engineer's review
* Update OutNames too
* Idle bss and cleanup
* main bss and cleanup
* format
* Remove pad comment about sAudioMgr
* PR
* Missed a couple size_t changes
* unused pads
* static
* Sync with OoT
* Macro cleanup
* Some cleanup/rename load system name to Fragment
* Format
* bss
* Some clarifying comments regarding fragments
* PR suggestions
* size_t and numRelocations
* Initial docs
* Tons of stuff done
* Fix spacing thing now that the function is actually named
* Temporarily add un-macro'd flags as comment
* Name and document EnSyatekiOkuta_IsHiddenByAnotherOctorok
* Finish naming all functions
* Better macros + explanations
* Comments on a lot of functions
* Some stuff I was supposed to revert
* Fix merge issue
* Another merge fix
* Make data static + move it in-function
* Respond to engineer's review
* circleOrCrossAlpha -> hitResultAlpha
* Respond to more of engineer's feedback
* octorokHitType -> lastHitOctorokType
* Animation enum stuff
* Start
* Try every function
* Import data
* Docs from message branch
* Fix non-equivalency for func_8016AE1C
* Everything looks NON_MATCHING
* Some more clean up and docs
* Some cleanup
* Small format
* Small improvements here and there
* Match a couple
* Anotha one
* and than there was 1
* and than there were none :)
* Lots of docs
* Finish code docs
* schedule static
* Macros + cleanup
* text ids array cleanup
* Entries cleanup
* Use sBombersNotebookEntries in macros
* Some docs from message branch
* eventIndex -> event
* Remove outdated comments
* PR
* BOMBERS_NOTEBOOK_ENTRY_SIZE
* tables
* Token pasting to simplify
* Some more fixes
* PR pt 1
* Format
* Bring over BombersNotebook docs from z_message branch
Co-authored-by: ZoeyZolotova <zoey.zolotova@gmail.com>
* Full enum glory
* Format
* Name weekeventregs
* typo
* Some comments
* bss
* Review
* bss
* Update src/code/z_play_hireso.c
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Fix
* Namefixer
* bss
* Format
* 0 = 0x0000
---------
Co-authored-by: ZoeyZolotova <zoey.zolotova@gmail.com>
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Everything below Main OK,
and some small ones at the top
* 3 more short ones
* FileChoose_Main
* SelectModeUpdate/Draw
* SelectMode update functions done
* 2 more small ones
* ConfigModeDraw
* SetWindowVtx
* FileChoose_FadeInMenuElements
* Rest of the Config Mode Update Functions
* Minor cleanup
* FileChoose_UpdateMainMenu
* Make xml for title_static
* Minor correction
* One nasty draw, thanks Synray
Co-Authored-By: Synray <31429825+Synray@users.noreply.github.com>
* import data
* some cleanup
* import OoT docs
* missed some docs
* some progress
* FileSelect_SetWindowContentVtx WIP
* improve FileSelect_SetWindowContentVtx
* match z_file_nameset_NES
* cleanup and docs
* title static
* a few more functions
* even more functions
* small cleanup
* Data Cleanup
* 2 more matches
* z_file_choose_80807940 OK
* cleanup
* fix merge master
* FileSelect_DrawFileInfo wip
* small cleanup
* minor
* fix merge
* match FileSelect_DrawFileInfo
* cleanup
* fix merge
* fix merge
* sram cleanup
* document select mode
* many docs
* more docs
* more cleanup
* small nitpick
* consistency
* more cleanup
* more cleanup
* small
* small typos
* octal bad
* pr review
* noop
* elliptic review
* more review
* non-matching
* oops
* more suggestions
* keyboard formatting
* fix master
* sound
* padding
---------
Co-authored-by: Elliptic Ellipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Synray <31429825+Synray@users.noreply.github.com>
* Match remaining functions in z_en_go:
- Changed some already matching functions for uniformity with the tricky match (early continue from loop). In some cases, this eliminated some strange constructs, in others, it didn't leave much difference.
- Comments/Notes to start understanding/naming process.
* WIP renaming
* More WIP renaming.
* More renaming, Effects (See oot for continuation) and some flags)
* MessageScript documenting.
* Util for dumping message data by textId value.
* Identify some messages.
* Formatting, figuring out event flags.
* More WIP naming
* WIP renaming.
* WIP renaming
* WIP naming and organizing
* WIP more renaming.
* WIP renaming/organizing.
* Near-Final Cleanup before review.
* Rename Taisou and Hakugin animations and associated functions/variables.
* Misc Cleanup.
* Undo changes to variables.txt
* Removed msgtableparser.py (Split to another branch)
* Removal of uncompiled Message Script details.
* Fixup spec file
* First part of hensldm's suggested changes from review. Awaiting discussion.
* Second part of hensldm's suggested changes.
* Fixup missed 'Animation' suffix and functions.txt
* Update .xml files and related source per tom-overton's comments
* Align w/ engineer124's Quake Cleanup #1102
* fixup
* Run format.sh after merge.
* Add brackets around one-line conditional blocks
* Remainder of hensldm's comments from review.
* First pass at Elliptic's comments.
* Rename functions UpdateToX -> ChangeToX
* Header cleanup.
* Run Format, remove accidental commit of .orig file.
* Fixup ActorInit
* Review comments addressed, plus a few unsolicited changes.
- Location of function declarations moved above static data, below types: References in the codebase were mixed, but this just made more sense.
- Function name changes: It didn't fit into subsystems based on Goron Type, so I quit trying to name functions that way. Loss of a bit of "which function applies to which type", but it looks a bit cleaner, sooo...
- Took a stab at making effectTable usage a bit clearer. Just using a EnGoEffect* everywhere and not inherently knowing if it was for one element, or an array really bugged me.
- "GraveBro" names changed. They're all "brothers".
* Changes from engineer124's review.
- "Stretcher" replaced with "Athletic" as a descriptor of goron type.
- Misc formatting and naming changes
* Restructure switch-case statment for early break, and added missing default cases. Removed #define for 0 for actionFlags bitmask.
* Relocate WEEKEVENTREG comments, remove SCENE comments.
* Updated WEEKEVENTREG define names
* Update WEEKEVENTREG names in Goron Shrine Door.
* ELDER -> ELDERS, and revert formatting on z64save.h
* Fixed re-applying changes over wrong defines.
* Adjust Weekeventreg names and comments.
* Update comment as well.
Derek Hensley