* Something not yet identified makes it current zeldaret's main and my documentation don't fit. Re-importing my code in steps. Now: imported function renaming from doc_ovl_en_dinofos.
* Ported missing function names from doc_ovl_en_dinofos branch and renamed a static variable. Everything external to the C file and its header should be accounted for right now.
* Branch now using same documented code as doc_ovl_en_dinofos and PR test works.
* Ready to PR EnDinofos' Documentation
* Applied first batch of review edits.
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
To make sure it'll actually get applied.
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* RecoilFromBlockedSlash is now Recoil. Small this-> missing before a suggestion inserted online was added.
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Updated last unnamed static variables and vertices names
* Renaming vertices in _PostLimbDraw and last unnamed static variables.
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
* Applied changes from hidden suggestions.
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Tom Overton <tom-overton@users.noreply.github.com>
* Update src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
Co-authored-by: Tom Overton <tom-overton@users.noreply.github.com>
* Renamed sBaseFireVelocity to sFireVelocityOffset.
* Inserted some enums for collider limbs. Continuing to address PR comments.
Co-authored-by: Tom-Overton <tom.overton@outlook.com>
---------
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
Co-authored-by: Tom Overton <tom-overton@users.noreply.github.com>
Co-authored-by: Tom-Overton <tom.overton@outlook.com>
* prefix in-function static data in z_scene_proc with s
prefix in-function static data in z_eff_blure with s
prefix in-function static data in Graph_TaskSet00 with s
prefix in-function static data in Fault_SetOptions with s
* Use uintptr_t in main
* hardware_regs.ld
* Remove some unessary blob comments
* object_link_child_TLUT_00DA80
* object_kz texture and tlut
* initialize typos
* Creating branch for ovl_bg_dblue_elevator's PR.
* OK
* Screwing with my Debian install. Safety commit.
* Applied first pass of review comments to PR and added authors.
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
Co-authored-by: fig02 <fig02srl@gmail.com>
Co-authored-by: Kelebek1 <eeeedddccc@hotmail.co.uk>
Co-authored-by: Isghj5 <isghj5@gmail.com>
Co-authored-by: petrie911 <pmontag@PHYS-S129.iowa.uiowa.edu>
Co-authored-by: AngheloAlf <angheloalf95@gmail.com>
* Found some review comments I missed and applied the suggestions.
* Added enum for water flow and renamed waterSurfaceYPos to waterSurfacePosY
* Forgot to add last contribution.
Co-authored-by: Tom-Overton <tom.overton@outlook.com>
---------
Co-authored-by: Derek-Hensley <hensley.derek58@gmail.com>
Co-authored-by: fig02 <fig02srl@gmail.com>
Co-authored-by: Kelebek1 <eeeedddccc@hotmail.co.uk>
Co-authored-by: Isghj5 <isghj5@gmail.com>
Co-authored-by: petrie911 <pmontag@PHYS-S129.iowa.uiowa.edu>
Co-authored-by: AngheloAlf <angheloalf95@gmail.com>
Co-authored-by: Tom-Overton <tom.overton@outlook.com>
* Parameter last functions
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Documentation for do actions and various gfx
* Suggested changes
* f prefix for texture scale numbers
* Player_SetBButtonAmmo
---------
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Match EnOkuta
* Match data
* Use the generated reloc
* Delete extern stuff and format
* Extract the DL
* Fix lots of stuff
* Copy a lot of names over from EnSyatekiOkuta
* SFX enums
* Lots more stuff
* Constants and other stuff
* Some more stuff I missed
* Name more functions using OoT/SyatekiOkuta as reference
* An easy function I missed
* Some floats
* Getter macros
* Types enum
* Name the cylinder inits a little clearer
* Create bodyparts enum and name all data
* Name all functions
* Name `timer` struct var and all temps
* Name the `jumpHeight` struct var
* Create damage effect enum
* Name the extracted DL
* Name `numConsecutiveProjectiles`
* Finish docs
* Document XML
* Clarify that this blue Octorok isn't the shooting gallery one
* Respond to reviews
* Stuff
---------
Co-authored-by: Synray <31429825+Synray@users.noreply.github.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* En_Death new build system edition
* Fix merge
* Matched
* Fix merge
* Some names
* Suggested changes
* Further suggested changes
* Add value comments to MinideathAction
* First batch of functions
* more ok
* z_map_data OK
* More OKs, MinimapList ZAPD breaking change
* func_80103A58 improvements, more OK
* func_80106D5C and func_801091F0 decomped
* func_801031D0 decomped and some fixes
* house cleaning, more OKs more decomp
* Even more OKs
* func_80105C40 almost OK, more OKs
* func_80108AF8 OK and more
* All functions attempted
* func_8010534C OK
* Start documentation, rename DoorCtx
* More OKs, split map_data.data, more doc
* incremental clean-up, more function names
* more function names
* func_801068FC OK
* old uncommitted changes
* minor tweaks
* implement easy fixes
* more fixes
* z_map_disp OK, implement more suggestions
* delete utility program
* migrate data
* TransiActor ->TransitionActor
* Major documentation pass
* first pass of changes
* warning fix attempt, revert ZFile.cpp
* Fix FAKE match
* Easy fixes
* implement gDPLoadTextureBlock_Runtime
* z_demo bss patch
* Extract white square texture
* Implement more suggestions
* rework MapIndex/DungeonIndex
* revert dungeonSceneIndex -> mapIndex in some spots, implement suggestions
* more suggestions
* minor nits
* fix #include
* Decompiled, some commands still unnamed
* Use full weekevent reg names
* Fix func_8094E69C
* Fix Player_GetMask
* Eventinf, mask worn, and item action argument formatting
* decimal rupees
* Times (day, hours, minutes) as decimal
* msgEventScriptPos
* Callbacks
* Name final commands
* Enum
* Arrays
* functions
* Small cleanups
* Clean up actors
* Remove event from some variable names to make them shorter
* Some more function renames
* newline
* Missed a few unks in commands
* Update functions.txt
* PlayerMask
* MSGMODE_PAUSED
* Script time macros
* EnSob1_GetWelcome default
* Whole bunch of renames
* Format
* Add CMD to commands
* Update code_functions
* structs for size
* z64scripts.h
* MsgEventCallback -> MsgScriptCallback
* format
* MsgEvent_RunScript stop
* Remove cmd handler comment
* cmd -> script in MsgEvent_RunScript
---------
Co-authored-by: Thar0 <17233964+Thar0@users.noreply.github.com>
* deimplementation complete
* newlines
* match
* data import
* back port cleanup changes
* stuff
* naming and such
* all funcs provisionally named
* more stuff
* merge
* Fix merge issues
* begin cleanup
* Use constants for all face animation data
* Use THIS like almost every actor does
* Change "Light Ball" to "UFO"
* Rename the alien types
* EnInvadePoh -> EnInvadepoh
* Rename the types
* Rename some Twinmold stuff
* ConfusedRomani -> SilentRomani
* Fix stack size issues with EnInvadepoh_Cremia_Init
* Move a struct out of the header to where it belongs
* Some header cleanup and struct names
* Name remaining struct vars
* Some more struct var renames
* Finish reviewing the struct var names
* Rename most of the interactInfo stuff
* Consistency
* Remove unused union
* Define EN_INVADEPOH_LIMB_MAX like EndingHero6 does
* Fix header
* Update functions.txt and variables.txt
* Create macros for accessing spawn time and kill count
* Some defines
* Some minor comments and cleanup
* Rename some functions
* Comments for those three functions
* Draw function cleanups
* Some damaged and dead cleanup
* Death scale stuff
* Good chunk of alien functions
* Invasion state naming
* Weekeventreg naming
* Happy with >20% of functions now
* A couple more functions
* More consistent names for BSS variables
* Some Init cleanup
* Happy with 30% of the functions now
* Finish the abductors
* Some random functions to get the functions I'm happy with >1/3rd
* Use `InitPath` for everything
* UFO functions done, >40% functions I'm happy with
* Do a lot of work on InvasionHandler action funcs
* Finish invasion handler code
* InitVars
* Rename the "closest alien" stuff to "closest alien threat"
* Finish most of the dog functions
* Lots of small stuff here and there
* Finish documenting the dog bug
* Document `EnInvadepoh_Dog_IsCloseToPath`
* `EnInvadepoh_Dog_MoveAlongPath` and other fixes
* Simple comment for `EnInvadepoh_Dog_Move`
* Various path functions, finish dog
* Consistently use "SetMatrixTranslation"
* Change all the angleToPlayer stuff to pitch/yaw
* Some RewardRomani functions
* Finish RewardRomani
* Finish Night1Romani and BarnRomani, >75% of functions done
* Some minor stuff
* Document bug
* Finish all of SilentRomani minus the Idle functions
* Finish EnInvadepoh_SilentRomani_Idle
* Finish Night3Cremia
* Finish Night3Romani
* Finish `EnInvadepoh_Ufo_SpawnSparkles`
* Finish some library functions
* Finish the alien pathing stuff
* Finish Romani path stuff
* Finish all non-InteractInfo stuff
* InteractInfo -> ModelInfo
* Create a `EnInvadepohFaceAnimBase` struct
* Name some of the animation data
* Switch to `Chained`/`ChainedDelay` and do some other cleanup
* Name all of the animation data
* Finish documenting and cleaning up the face animation functions
* Some comments at the top of the file
* Clean up forward declarations
* Clean some stuff up to the ModelInfo functions
* Fix build
* Move the animation data around so all the ModelInfo functions are adjacent
* Review
* Use `CLOCK_TIME_MINUTE` in `EnInvadepoh_Alien_PathComputeProgress`
* Respond to some of Anghelo's review
* Update comment on spawn time macros explaining what indices are usable
* Create a `DEATH_SCALE` define
* `WEEKEVENTREG_RECEIVED_MILK_BOTTLE` -> `WEEKEVENTREG_RECEIVED_ALIENS_BOTTLE`
* Forgot to do the bomber's notebook stuff too
* parallelogram -> rectangle
* Respond to engineer's review
* Slight spacing fix
---------
Co-authored-by: petrie911 <petrie911@users.noreply.github.com>
Co-authored-by: petrie911 <pmontag@Monday.localdomain>
Co-authored-by: angie <angheloalf95@gmail.com>
Co-authored-by: engineer124 <engineer124engineer124@gmail.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Obj_Mine
* Obj_Mine
* Fixups
* Nonmatchings + cleanup
* Small cleanup
* externs
* structs complete
* wew
* some docs. still baffling
* documented physics stuff
* docs. physics be wack
* forgot some things
* format
* more cleanup
* merge and such
* format
* more format and cleanup
* asm stuff
* Update src/overlays/actors/ovl_Obj_Mine/z_obj_mine.c
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
* now with decomp.me
* removed some extraneous macros I didn't end up using
* fixes and formats
* merge
* my god, it matches
* format
* removed macros
* more fixes
* format
* format
---------
Co-authored-by: Maide <eeeedddccc@hotmail.co.uk>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: petrie911 <petrie911@users.noreply.github.com>
Co-authored-by: petrie911 <pmontag@Monday.localdomain>
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
* EnDt deecomp first pass, two nonmatching
* Some cleanup, got the big boy matching
* Some light cleanup, documenting blinking behaviour
* Fixed last non-matching with some permuter silliness
* Decompilation complete
* Mayor documentation, first pass
* Updating some unknown vars in baisen
* Added an enum for mayor's cutscene state
* Formatting pass for mayor
* Cleaning up unk var in mayor meeting method
* Some cleanup and changes based on PR feedback
* Another cleanup and fix pass based on PR feedback
* Updated mayor event flags according to their usage
* All the parentheses
* Another round of PR feedback cleanup
* Having another crack at naming/cleanup based on PR feedback
* Renaming animation symbols
* Fixing broken references in other actors from anim rename
---------
Co-authored-by: GinNoOokami <noreply>
* z_message iconv
* voicecheckword iconv
* format
* TODO
* voice_external iconv
* Missed a few in message
* Use shiftjis_conv instead
* space comment in message_nes
* Use chars for cases
* Add ending single quote check as well
* table comments
* No look up table
* align makefile tools
* begin cleanup
* more cleanup
* more cleanup
* more cleanup
* more cleanup
* more cleanup
* fake matches
* more cleanup
* more cleanup
* small thing
* PR Review
* PR Review
* Fix struct
* 20/79 OK
* BossHakugin_Draw OK
* func_80B0D69C OK
* func_80B0D2B8 OK
* func_80B0D750 OK
* Shadow function docs
* Fix some non-matchings
* Apparently this matches now? It didn't before
* OverrideLimbDraw OK
* BossHakugin_PostLimbDraw
* Animation Cleanup: En_G* (#1395)
* wip
* more cleanup
* more cleanup
* one more thing
* one more default case
* missed brackets
* PR Review
* add more matches and fill stuct
* 3 more Draw functions
* func_80B0E5A4
* Finshed the Draw functions
* Small cleanup
* Most of the death-handling code done
* more matching
* functions
* Goht collab (#9)
* Animation Cleanup: En_G* (#1395)
* wip
* more cleanup
* more cleanup
* one more thing
* one more default case
* missed brackets
* PR Review
* z_message_nes (1 NON_MATCHING) (#1394)
* Bring over progress
* Some docs
* scratch urls + format
* Fixes
* Match Message_DrawTextNES
* String macros
* color structs
* Document object_mk (#1389)
* Updated object_mk animation, limb, and skeleton names
* Updated object_mk texture and DList names
* Added comment to object_mk.xml
* Remove "ing" from Anim names
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Update z_en_mk.c to not use "ing" in names
* Running formatter
---------
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Player Docs: Initial framework for "Action Change Lists" (#1397)
* copy fig docs
* adjust wording
* another fix
* fix bool
* PR Suggestion
* Animation Cleanup: En_H* (#1399)
* begin H
* more cleanup
* Animation Cleanup: En_I* (#1400)
* cleanup I
* oops
* Start Player Item Docs (#1396)
* Copy Fig Docs
* small cleanup
* ItemChangeType comment
* bool
* item change comments
* PR Review
* rm comments
* Animation Cleanup: En_K* (#1402)
* cleanup k
* one more name
* Animation Cleanup: En_J* (#1401)
* cleanup J
* small fix
* functions
---------
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: Zach North <zrnorth@gmail.com>
Co-authored-by: petrie911 <pmontag@Monday.localdomain>
* hotfix
* all functions decomped
* all functions decomped
* Now with more data
* small fix
* another small fix
* ok last small fix I swear
* cleanup
* func_80B0A8C4 OK
* func_80B0D9CC OK
* Use generated reloc for Goht + remove Goht's undefined_syms
* Bodyparts + other clean up
* cleanup
* oops
* fix merge
* begin docs
* fix merge
* cutscene docs
* effects docs
* small docs
* Document colliders
* Odds and ends in the struct
* Name some functions
* Name two functions
* Some action functions and other odds and ends
* Name the lightning segments and electric ball functions correctly
* Names and other cleanup
* Start on hakurock + more cleanup
* Name all hakurock functions
* Name hakurock effects + create a GET_TYPE macro for it
* Finish documenting Hakurock
* Name one more function in BossHakugin
* Name a few more things
* Name a lot of struct vars
* Wall-related stuff
* Fix some fake matches
* Name a couple more struct vars
* Document some more of the struct
* Name the limb flag stuff
* Name the last unnamed struct vars
* Name the horn colliders correctly
* Some initial work on documenting data
* Some function documentation
* A couple of cleanups
* Finish documenting BossHakugin_UpdateBaseRot
* Name BossHakugin_SetLightningSegmentColliderVertices
* Document BossHakugin_AddLightningSegments
* Document BossHakugin_RunUpdateCommon and related functions
* Document BossHakugin_AddMalfunctionEffects
* Document BossHakugin_StepVectorToTarget
* Rename to BossHakugin_StepVector
* Finish documenting BossHakugin_AddMalfunctionEffects for now, might come back later though
* Document BossHakugin_UpdateSubCam
* Document BossHakugin_Thaw
* Document BossHakugin_ChargeUpAttack
* Some scattered docs
* Finish documenting the top "library" functions
* Document intro cutscene functions
* Document running and charging
* Document downed
* Document throwing
* Document remaining non-death action functions
* Document most of the death cutscene
* Get started on documenting crushing rocks
* Separate out the crushing rocks into their own struct
* Document the ExplosionLimbHideInfo
* Finish documenting BossHakugin_DeathCutsceneCrushedByRocks
* Almost done with rocks I think
* Port over Odolwa shadow documentation
* Finish documenting draw functions
* Finish documenting BossHakugin_Update
* Name variables in BossHakugin_UpdateElectricBalls
* Document BossHakugin_CheckForBodyColliderHit
* Finish documenting BossHakugin_UpdateDamage
* I've convinced myself these names are fine
* Almost finish documenting every update function
* Remove TODOs from the header
* Finish documenting the C file
* Delete duplicate define
* Finish variables.txt for Goht
* Undo change that desync'd z_eff_ss_fhg_flash.h from other effect headers
* Missed a THIS
* Some low-hanging review responses
* Add comment explaining something in BossHakugin_ShouldWait
* Match BossHakugin_SpawnLargeStalactiteWalls using a for-loop
* Create GOHT_ELECTRIC_BALL_COUNT_MAX constant
* vector -> norm and targetVector -> targetNorm
* Add TODO comments for dynamic shadow functions
---------
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
Co-authored-by: Parker B <20159000+jpburnett@users.noreply.github.com>
Co-authored-by: petrie911 <pmontag@Monday.localdomain>
Co-authored-by: petrie911 <69443847+petrie911@users.noreply.github.com>
Co-authored-by: Zach North <zrnorth@gmail.com>
Co-authored-by: engineer124 <engineer124engineer124@gmail.com>
* Some Decoder WIPs
* Improvements
* POC
* Fix bss
* another newline
* Staff OK
* Cleanup + fix progress script
* script cleanup
* Some docs
* makefile
* Extract text from extract_assets.py
* More docs
* Even more docs
* Other message assets
* Small cleanups
* Clean up decoders/encoders
* Message_SetupLoadItemIcon -> Message_DecodeHeader
* Some more docs
* Remove mkdmadata
* Fade Skippable
* More cmd docs
* 1 left
* Last notes
* HS_TIMER -> HS_TIME
* More general docs
* Format
* Note the charmap conversion for buttons in message_data_fmt_nes.h
* Remove trailing whitespace
* Small fixes
* PR
* Matching dmatable
* Generate NON_MATCHING dmadata
* Clean up dmamgr
* Format
* Ignore tools/buildtools/mkdmadata
* Warnings
* Use SYMS flag instead of segment name
* PR + more notes
* PR cleanups
* begin R
* finish anim R
* cleanup
* small adj
* cleanup
* CS_STATE_IDLE
* CS_ID_NONE
* more cleanup
* sBssPad
* angles
* sneak in small fix
* small fix
* begin anim R
* sTexturesDesegmented
* more misc docs
* more misc cleanup
* small adjustments
* oh sneaky
* PR Review
* adj comment, reads better
* missed an enum
* this one actor reverses true/false
* bool
* CARNIVOROUS_LILY
* copy over docs
* more docs
* some docs
* more docs
* small cleanup
* more small cleanup
* more small cleanup
* lerp time
* small reordering
* feather type
* general owl warp docs
* more cleanup
* rm redundant info
* PR Review
* PR Review
* Move qrand to libc64
* use an union to avoid type punning
* __osMalloc
* math64.c
* fixed_point.h
* sleep
* aprintf.h
* sprintf
* malloc
* use original names on aprintf.c and malloc.c
* qrand cleanup pass
* use original names of sleep.c
* og names for sprintf
* more cleanup
* format
* fixes
* whoops
* use ARRAY_COUNT again
* comment
* Use `fu`
* forgot this one
* review
* fix
* sneak a tiny cleanup
* Init, Destroy, Update, easy actions
* Just the hard 3 + 1 left
* One left
* OK
Co-authored-by: petrie911 <69443847+petrie911@users.noreply.github.com>
* Data/bss in, extract colheader
* Clean up externs
* Better match for func_809EECBC
* Sfx
* Lot of naming
* fix build
* Name skel stuff
* name limbdraws
* name colliders
* Document `object_boss05`
* Port some names from Odolwa
* Name bio baba types (and relatedly clean up EnPp)
* Better names for the LimbDraw functions + some related vars
* Name all functions
* Name a lot of struct vars
* Colliders and body parts
* Name all struct vars (might come back for a few of these though)
* Name most stack vars
* Fragment states, ice data
* Limb rot index
* Damage effects
* Enum for hit reactions
* Enums for movement state/attack state
* Finish up
* Missed this in EnPp
* Respond to reviews
* Fix comment
* Reverse order for postlimbdraw, etc. functions
* Remove blank line at the top
* Respond to review
* Make a "getter" macro for the force detach timer
* Respond to review
---------
Co-authored-by: Elliptic Ellipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: petrie911 <69443847+petrie911@users.noreply.github.com>
Co-authored-by: angie <angheloalf95@gmail.com>
* Move player function declarations to z64player.h
* rename Actor_MountHorse to Player_MountHorse and similar functions
* whoops
* add missing includes
* format
* whoops
mzxrules